From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=jian.j.wang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B712121959CB2 for ; Fri, 29 Mar 2019 01:33:05 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Mar 2019 01:33:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,283,1549958400"; d="scan'208";a="156889716" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 29 Mar 2019 01:33:05 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 29 Mar 2019 01:33:05 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 29 Mar 2019 01:33:04 -0700 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.252]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.158]) with mapi id 14.03.0415.000; Fri, 29 Mar 2019 16:33:02 +0800 From: "Wang, Jian J" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Ye, Ting" , Gang Wei Thread-Topic: [PATCH v3 11/12] CryptoPkg/IntrinsicLib: Remove .S files for IA32 arch Thread-Index: AQHU5gF1BIx5Qi1LU0a49gG7dFZrP6YiR/9w Date: Fri, 29 Mar 2019 08:33:02 +0000 Message-ID: References: <20190329073117.25400-1-shenglei.zhang@intel.com> In-Reply-To: <20190329073117.25400-1-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDE1Mzc0MjYtNjJmMC00Mzg0LTk4YjQtNWVmOTRiYmZjMTFjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK2xRYlZyZkJ1QkRXRmpFbXhkK1kzUSswSmhjNkJmOEFYSHJiOEVzZlU3emk2U3B6bTRBS1VHN1ArNjE4S3h6NSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v3 11/12] CryptoPkg/IntrinsicLib: Remove .S files for IA32 arch X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Mar 2019 08:33:06 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jian J Wang > -----Original Message----- > From: Zhang, Shenglei > Sent: Friday, March 29, 2019 3:31 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Gang Wei ; Wang, Ji= an > J > Subject: [PATCH v3 11/12] CryptoPkg/IntrinsicLib: Remove .S files for IA3= 2 arch >=20 > .nasm file has been added for X86 arch. .S assembly code > is not required any more. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1594 >=20 > Cc: Ting Ye > Cc: Gang Wei > Cc: Jian Wang > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > --- > .../Library/IntrinsicLib/Ia32/MathLShiftS64.S | 62 ----------------- > .../Library/IntrinsicLib/Ia32/MathRShiftU64.S | 66 ------------------- > .../Library/IntrinsicLib/IntrinsicLib.inf | 2 - > 3 files changed, 130 deletions(-) > delete mode 100644 CryptoPkg/Library/IntrinsicLib/Ia32/MathLShiftS64.S > delete mode 100644 CryptoPkg/Library/IntrinsicLib/Ia32/MathRShiftU64.S >=20 > diff --git a/CryptoPkg/Library/IntrinsicLib/Ia32/MathLShiftS64.S > b/CryptoPkg/Library/IntrinsicLib/Ia32/MathLShiftS64.S > deleted file mode 100644 > index 7031a59a71..0000000000 > --- a/CryptoPkg/Library/IntrinsicLib/Ia32/MathLShiftS64.S > +++ /dev/null > @@ -1,62 +0,0 @@ > -#-----------------------------------------------------------------------= ------- > -# > -# Copyright (c) 2014, Intel Corporation. All rights reserved.
> -# This program and the accompanying materials > -# are licensed and made available under the terms and conditions of the = BSD > License > -# which accompanies this distribution. The full text of the license may= be found > at > -# http://opensource.org/licenses/bsd-license.php. > -# > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > -# > -# Module Name: > -# > -# MathLShiftS64.S > -# > -# Abstract: > -# > -# 64-bit Math Worker Function. > -# Shifts a 64-bit signed value left by a certain number of bits. > -# > -#-----------------------------------------------------------------------= ------- > - > - .686: > - .code: > - > -ASM_GLOBAL ASM_PFX(__ashldi3) > - > -#-----------------------------------------------------------------------= ------- > -# > -# void __cdecl __ashldi3 (void) > -# > -#-----------------------------------------------------------------------= ------- > -ASM_PFX(__ashldi3): > - # > - # Handle shifting of 64 or more bits (return 0) > - # > - cmpb $64, %cl > - jae ReturnZero > - > - # > - # Handle shifting of between 0 and 31 bits > - # > - cmpb $32, %cl > - jae More32 > - shld %cl, %eax, %edx > - shl %cl, %eax > - ret > - > - # > - # Handle shifting of between 32 and 63 bits > - # > -More32: > - movl %eax, %edx > - xor %eax, %eax > - and $31, %cl > - shl %cl, %edx > - ret > - > -ReturnZero: > - xor %eax, %eax > - xor %edx, %edx > - ret > diff --git a/CryptoPkg/Library/IntrinsicLib/Ia32/MathRShiftU64.S > b/CryptoPkg/Library/IntrinsicLib/Ia32/MathRShiftU64.S > deleted file mode 100644 > index 24142b088e..0000000000 > --- a/CryptoPkg/Library/IntrinsicLib/Ia32/MathRShiftU64.S > +++ /dev/null > @@ -1,66 +0,0 @@ > -#-----------------------------------------------------------------------= ------- > -# > -# Copyright (c) 2014, Intel Corporation. All rights reserved.
> -# This program and the accompanying materials > -# are licensed and made available under the terms and conditions of the = BSD > License > -# which accompanies this distribution. The full text of the license may= be found > at > -# http://opensource.org/licenses/bsd-license.php. > -# > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > -# > -# Module Name: > -# > -# MathRShiftU64.S > -# > -# Abstract: > -# > -# 64-bit Math Worker Function. > -# Shifts a 64-bit unsigned value right by a certain number of bits. > -# > -#-----------------------------------------------------------------------= ------- > - > - > - .686: > - .code: > - > -ASM_GLOBAL ASM_PFX(__ashrdi3) > - > -#-----------------------------------------------------------------------= ------- > -# > -# void __cdecl __ashrdi3 (void) > -# > -#-----------------------------------------------------------------------= ------- > -ASM_PFX(__ashrdi3): > - # > - # Checking: Only handle 64bit shifting or more > - # > - cmpb $64, %cl > - jae _Exit > - > - # > - # Handle shifting between 0 and 31 bits > - # > - cmpb $32, %cl > - jae More32 > - shrd %cl, %edx, %eax > - shr %cl, %edx > - ret > - > - # > - # Handle shifting of 32-63 bits > - # > -More32: > - movl %edx, %eax > - xor %edx, %edx > - and $31, %cl > - shr %cl, %eax > - ret > - > - # > - # Invalid number (less then 32bits), return 0 > - # > -_Exit: > - xor %eax, %eax > - xor %edx, %edx > - ret > diff --git a/CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > b/CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > index a91c850013..9704b9ea7d 100644 > --- a/CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > +++ b/CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > @@ -39,8 +39,6 @@ > Ia32/MathLShiftS64.c | INTEL > Ia32/MathRShiftU64.c | INTEL >=20 > - Ia32/MathLShiftS64.S | GCC > - Ia32/MathRShiftU64.S | GCC > Ia32/MathLShiftS64.nasm | GCC > Ia32/MathRShiftU64.nasm | GCC >=20 > -- > 2.18.0.windows.1