From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: jian.j.wang@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Tue, 16 Apr 2019 23:09:23 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2019 23:09:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,360,1549958400"; d="scan'208";a="292225494" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 16 Apr 2019 23:09:22 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 16 Apr 2019 23:09:22 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 16 Apr 2019 23:09:21 -0700 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.153]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.25]) with mapi id 14.03.0415.000; Wed, 17 Apr 2019 14:09:19 +0800 From: "Wang, Jian J" To: "Gao, Zhichao" , "Yao, Jiewen" , "devel@edk2.groups.io" CC: "Ye, Ting" , Michael Turner , Bret Barkelew , "Gao, Liming" Subject: Re: [edk2] [PATCH 0/6] Add new APIs for BaseCryptLib Thread-Topic: [edk2] [PATCH 0/6] Add new APIs for BaseCryptLib Thread-Index: AQHU4r9n+l3WAhqYS0GxpE4nq/o1dqYbfAuAgARvGICAH44jgIAAiRFQ Date: Wed, 17 Apr 2019 06:09:19 +0000 Message-ID: References: <20190325040113.18848-1-zhichao.gao@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503F58E264@shsmsx102.ccr.corp.intel.com> <3CE959C139B4C44DBEA1810E3AA6F9000B7B2477@SHSMSX101.ccr.corp.intel.com> <3CE959C139B4C44DBEA1810E3AA6F9000B7C305C@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B7C305C@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWY2ZDRkYmEtNDEwOC00MWEyLWI5NGUtMGMzZjU3NTY5OGVmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidXVcL2UrUndBakNXMDFYN3JxcUI4SkV4eWhpY1ZOUStjN1NlVW43b1loUmFRb1VmMUZncndHRjlIQ2J3Y0pBQmwifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jian.j.wang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Zhichao, Thanks for update. Reviewed-by: Jian J Wang Jian > -----Original Message----- > From: Gao, Zhichao > Sent: Wednesday, April 17, 2019 1:57 PM > To: Gao, Zhichao ; Yao, Jiewen > ; devel@edk2.groups.io > Cc: Ye, Ting ; Michael Turner > ; Bret Barkelew > ; Gao, Liming ; Wang, > Jian J > Subject: RE: [edk2] [PATCH 0/6] Add new APIs for BaseCryptLib >=20 > Resend to the groups.io. > Testcase is update in my branch. And all unit test is passed. > By the way, the new interface is not supported in Runtime phase. >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Gao, Zhichao > > Sent: Thursday, March 28, 2019 12:05 PM > > To: Yao, Jiewen ; edk2-devel@lists.01.org > > Cc: Ye, Ting ; Michael Turner > > ; Bret Barkelew > > ; Gang Wei ; Gao, > > Liming > > Subject: Re: [edk2] [PATCH 0/6] Add new APIs for BaseCryptLib > > > > Sorry for late reply. I have write a very simple test case for these ne= w APIs. > > And the test result is as expected. > > Refer to > > https://github.com/ZhichaoGao/edk2/commit/31938b606c6a6a1fdb560e3d0 > > dd4e41a78e1d7e9 > > The section to test VerifyEKUsInPkcs7Signature is refer to > > https://github.com/Microsoft/mu_tiano_plus/tree/release/201808/CryptoP > > kg/UnitTests/VerifyPkcs7EkuUnitTestApp > > > > Thanks, > > Zhichao > > > > > -----Original Message----- > > > From: Yao, Jiewen > > > Sent: Monday, March 25, 2019 4:22 PM > > > To: Gao, Zhichao ; edk2-devel@lists.01.org > > > Cc: Ye, Ting ; Michael Turner > > > ; Bret Barkelew > > > ; Gao, Liming ; > > > Gang Wei > > > Subject: RE: [edk2] [PATCH 0/6] Add new APIs for BaseCryptLib > > > > > > Hi > > > Would you please describe what unit test has been run for the new API= ? > > > > > > > > > > -----Original Message----- > > > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf > > > > Of Zhichao Gao > > > > Sent: Monday, March 25, 2019 12:01 PM > > > > To: edk2-devel@lists.01.org > > > > Cc: Ye, Ting ; Michael Turner > > > > ; Bret Barkelew > > > > ; Gao, Liming ; > > > > Gang Wei > > > > Subject: [edk2] [PATCH 0/6] Add new APIs for BaseCryptLib > > > > > > > > Add new API to get organization name Add new API > > > > VerifyEKUsInPkcs7Signature Add PKCS1v2 (RSAES-OAEP) support > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > Signed-off-by: Zhichao Gao > > > > Cc: Ting Ye > > > > Cc: Gang Wei > > > > Cc: Wang Jian J > > > > Cc: Liming Gao > > > > Cc: Sean Brogan > > > > Cc: Michael Turner > > > > Cc: Bret Barkelew > > > > > > > > Bret Barkelew (6): > > > > CryptoPkg/BaseCryptLib.h: Add new API to get organization name > > > > CryptoPkg/BaseCryptLib: Add new API to get organization name > > > > CryptoPkg/BaseCryptLib.h: Add new API VerifyEKUsInPkcs7Signature > > > > CryptoPkg/BaseCryptLib: Add new API VerifyEKUsInPkcs7Signature > > > > CryptoPkg/BaseCryptLib.h: Add PKCS1v2 (RSAES-OAEP) support. > > > > CryptoPkg/BaseCryptLib: Add PKCS1v2 (RSAES-OAEP) support. > > > > > > > > CryptoPkg/Include/Library/BaseCryptLib.h | 121 ++++- > > > > CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 2 + > > > > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 4 +- > > > > CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs1Oaep.c | 218 +++++++++ > > > > .../Library/BaseCryptLib/Pk/CryptPkcs1OaepNull.c | 61 +++ > > > > .../Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c | 539 > > > > +++++++++++++++++++++ > > > > .../BaseCryptLib/Pk/CryptPkcs7VerifyEkuRuntime.c | 75 +++ > > > > CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c | 102 +++- > > > > CryptoPkg/Library/BaseCryptLib/Pk/CryptX509Null.c | 32 ++ > > > > CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 2 + > > > > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 + > > > > 11 files changed, 1144 insertions(+), 14 deletions(-) create mode > > > > 100644 CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs1Oaep.c > > > > create mode 100644 > > > > CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs1OaepNull.c > > > > create mode 100644 > > > > CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c > > > > create mode 100644 > > > > CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEkuRuntime.c > > > > > > > > -- > > > > 2.16.2.windows.1 > > > > > > > > _______________________________________________ > > > > edk2-devel mailing list > > > > edk2-devel@lists.01.org > > > > https://lists.01.org/mailman/listinfo/edk2-devel > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel