From: "Wang, Jian J" <jian.j.wang@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Gao, Zhichao" <zhichao.gao@intel.com>
Cc: "Ye, Ting" <ting.ye@intel.com>
Subject: Re: [edk2-devel] [PATCH] CryptoPkg/BaseCryptLib: Remove the blank line in the comments
Date: Mon, 29 Apr 2019 09:08:51 +0000 [thread overview]
Message-ID: <D827630B58408649ACB04F44C5100036258EF59D@SHSMSX107.ccr.corp.intel.com> (raw)
In-Reply-To: <1599949D48F01C54.4588@groups.io>
Pushed at 038f929c921c3b6f2fb47a79f0e89caa0ed649c0
Regards,
Jian
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wang,
> Jian J
> Sent: Sunday, April 28, 2019 4:02 PM
> To: Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io
> Cc: Ye, Ting <ting.ye@intel.com>
> Subject: Re: [edk2-devel] [PATCH] CryptoPkg/BaseCryptLib: Remove the blank
> line in the comments
>
>
>
> Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
>
> > -----Original Message-----
> > From: Gao, Zhichao
> > Sent: Sunday, April 28, 2019 10:26 AM
> > To: devel@edk2.groups.io
> > Cc: Wang, Jian J <jian.j.wang@intel.com>; Ye, Ting <ting.ye@intel.com>
> > Subject: [PATCH] CryptoPkg/BaseCryptLib: Remove the blank line in the
> > comments
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1736
> >
> > For accroding with the doxygen special documention blocks
> > in section 2.3.5, removing the blank line in the file comments
> > of the file header for PeiCryptLib.inf
> >
> > Cc: Jian Wang <jian.j.wang@intel.com>
> > Cc: Ting Ye <ting.ye@intel.com>
> > Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> > ---
> > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> > b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> > index 0166f0b360..415dda3078 100644
> > --- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> > +++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> > @@ -15,7 +15,6 @@
> > #
> > # Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.<BR>
> > # SPDX-License-Identifier: BSD-2-Clause-Patent
> > -
> > #
> > ##
> >
> > --
> > 2.21.0.windows.1
>
>
>
next prev parent reply other threads:[~2019-04-29 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-28 2:25 [PATCH] CryptoPkg/BaseCryptLib: Remove the blank line in the comments Gao, Zhichao
2019-04-28 8:02 ` Wang, Jian J
[not found] ` <1599949D48F01C54.4588@groups.io>
2019-04-29 9:08 ` Wang, Jian J [this message]
[not found] <1599823C4F64DBB5.8796@groups.io>
2019-04-28 3:30 ` [edk2-devel] " Gao, Zhichao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D827630B58408649ACB04F44C5100036258EF59D@SHSMSX107.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox