public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wang, Jian J" <jian.j.wang@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Gao, Zhichao" <zhichao.gao@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>,
	"Ye, Ting" <ting.ye@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>,
	Sean Brogan <sean.brogan@microsoft.com>,
	Michael Turner <Michael.Turner@microsoft.com>
Subject: Re: [edk2-devel] [PATCH] CryptoPkg: Add lacking instances for build only
Date: Wed, 12 Jun 2019 17:05:45 +0000	[thread overview]
Message-ID: <D827630B58408649ACB04F44C51000362591DA2C@SHSMSX108.ccr.corp.intel.com> (raw)
In-Reply-To: <20190612023956.9180-1-zhichao.gao@intel.com>

With the wording/spelling addressed (see Laszlo's comment,
https://edk2.groups.io/g/devel/message/42273),

Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gao,
> Zhichao
> Sent: Wednesday, June 12, 2019 10:40 AM
> To: devel@edk2.groups.io
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Ye, Ting <ting.ye@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Michael
> Turner <Michael.Turner@microsoft.com>
> Subject: [edk2-devel] [PATCH] CryptoPkg: Add lacking instances for build only
> 
> From: Bret Barkelew <Bret.Barkelew@microsoft.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1900
> 
> Add the lacking instance to [Componnets] of dsc file
> for build only.
> 
> Cc: Jian Wang <jian.j.wang@intel.com>
> Cc: Ting Ye <ting.ye@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Turner <Michael.Turner@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
>  CryptoPkg/CryptoPkg.dsc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/CryptoPkg/CryptoPkg.dsc b/CryptoPkg/CryptoPkg.dsc
> index 9dfa349f6d..c90e76c721 100644
> --- a/CryptoPkg/CryptoPkg.dsc
> +++ b/CryptoPkg/CryptoPkg.dsc
> @@ -116,6 +116,7 @@
>    CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
>    CryptoPkg/Library/TlsLib/TlsLib.inf
>    CryptoPkg/Library/OpensslLib/OpensslLib.inf
> +  CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> 
>  [Components.IA32, Components.X64]
>    CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> --
> 2.21.0.windows.1
> 
> 
> 


      parent reply	other threads:[~2019-06-12 17:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-12  2:39 [PATCH] CryptoPkg: Add lacking instances for build only Gao, Zhichao
2019-06-12  2:39 ` [PATCH] SourceLevelDebugPkg: " Gao, Zhichao
2019-06-13  8:03   ` Wu, Hao A
2019-06-17  1:23     ` [edk2-devel] " Wu, Hao A
2019-06-12  2:39 ` [PATCH] SecurityPkg: " Gao, Zhichao
2019-06-12  2:39 ` [PATCH] MdeModulePkg: " Gao, Zhichao
2019-06-13  8:19   ` Wu, Hao A
2019-06-17  1:26     ` [edk2-devel] " Wu, Hao A
2019-06-12  8:38 ` [edk2-devel] [PATCH] CryptoPkg: " Laszlo Ersek
2019-06-13  0:32   ` Gao, Zhichao
2019-06-12 17:05 ` Wang, Jian J [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D827630B58408649ACB04F44C51000362591DA2C@SHSMSX108.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox