From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: jian.j.wang@intel.com)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by groups.io with SMTP; Wed, 12 Jun 2019 10:05:48 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
  by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jun 2019 10:05:47 -0700
X-ExtLoop1: 1
Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206])
  by FMSMGA003.fm.intel.com with ESMTP; 12 Jun 2019 10:05:47 -0700
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
 FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Wed, 12 Jun 2019 10:05:47 -0700
Received: from shsmsx108.ccr.corp.intel.com ([169.254.8.188]) by
 SHSMSX101.ccr.corp.intel.com ([169.254.1.104]) with mapi id 14.03.0439.000;
 Thu, 13 Jun 2019 01:05:45 +0800
From: "Wang, Jian J" <jian.j.wang@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>, "Gao, Zhichao"
	<zhichao.gao@intel.com>
CC: Bret Barkelew <Bret.Barkelew@microsoft.com>, "Ye, Ting"
	<ting.ye@intel.com>, "Gao, Liming" <liming.gao@intel.com>, Sean Brogan
	<sean.brogan@microsoft.com>, Michael Turner <Michael.Turner@microsoft.com>
Subject: Re: [edk2-devel] [PATCH] CryptoPkg: Add lacking instances for build only
Thread-Topic: [edk2-devel] [PATCH] CryptoPkg: Add lacking instances for
 build only
Thread-Index: AQHVIMglMS9mXG3Tu02k6RlKbT3AQaaYP4eg
Date: Wed, 12 Jun 2019 17:05:45 +0000
Message-ID: <D827630B58408649ACB04F44C51000362591DA2C@SHSMSX108.ccr.corp.intel.com>
References: <20190612023956.9180-1-zhichao.gao@intel.com>
In-Reply-To: <20190612023956.9180-1-zhichao.gao@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzQwNTFkNTAtNzIyMi00YzY5LTk3NjUtMTVmZjE2ODJiMDg0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNm81bWhUVU5GRXRqM2RRUlVZblp5d2xBSmVyUzVtZ1NrSmw2THpiTmlkWUVEQlg5XC9zS3VcL2tReVkyYzh2YXY1In0=
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: jian.j.wang@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

With the wording/spelling addressed (see Laszlo's comment,
https://edk2.groups.io/g/devel/message/42273),

Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ga=
o,
> Zhichao
> Sent: Wednesday, June 12, 2019 10:40 AM
> To: devel@edk2.groups.io
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Ye, Ting <ting.ye@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Michael
> Turner <Michael.Turner@microsoft.com>
> Subject: [edk2-devel] [PATCH] CryptoPkg: Add lacking instances for build=
 only
>=20
> From: Bret Barkelew <Bret.Barkelew@microsoft.com>
>=20
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1900
>=20
> Add the lacking instance to [Componnets] of dsc file
> for build only.
>=20
> Cc: Jian Wang <jian.j.wang@intel.com>
> Cc: Ting Ye <ting.ye@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Turner <Michael.Turner@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
>  CryptoPkg/CryptoPkg.dsc | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/CryptoPkg/CryptoPkg.dsc b/CryptoPkg/CryptoPkg.dsc
> index 9dfa349f6d..c90e76c721 100644
> --- a/CryptoPkg/CryptoPkg.dsc
> +++ b/CryptoPkg/CryptoPkg.dsc
> @@ -116,6 +116,7 @@
>    CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
>    CryptoPkg/Library/TlsLib/TlsLib.inf
>    CryptoPkg/Library/OpensslLib/OpensslLib.inf
> +  CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
>=20
>  [Components.IA32, Components.X64]
>    CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> --
> 2.21.0.windows.1
>=20
>=20
>=20