public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wang, Jian J" <jian.j.wang@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Lu, XiaoyuX" <xiaoyux.lu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>, "Ye, Ting" <ting.ye@intel.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/OpensslLib: Exclude err_all.c in process_files.py
Date: Thu, 20 Jun 2019 00:34:51 +0000	[thread overview]
Message-ID: <D827630B58408649ACB04F44C510003625929BC4@SHSMSX107.ccr.corp.intel.com> (raw)
In-Reply-To: <1560928761-1867-1-git-send-email-xiaoyux.lu@intel.com>

Reviewed-by: Jian J Wang <jian.j.wang@intel.com>


> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Xiaoyu Lu
> Sent: Wednesday, June 19, 2019 3:19 PM
> To: devel@edk2.groups.io
> Cc: Lu, XiaoyuX <xiaoyux.lu@intel.com>; Laszlo Ersek <lersek@redhat.com>;
> Wang, Jian J <jian.j.wang@intel.com>; Ye, Ting <ting.ye@intel.com>
> Subject: [edk2-devel] [PATCH v1 1/1] CryptoPkg/OpensslLib: Exclude err_all.c in
> process_files.py
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1881
> 
> Commit(0a1b13fd4d2210e2c3) fix VS2017 build failure
> remove useless file in OpensslLib[Crypto].inf,
> but we use process_files.py to generate files.
> So exclude err_all.c file in process_files.py
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Ting Ye <ting.ye@intel.com>
> Signed-off-by: Xiaoyu Lu <xiaoyux.lu@intel.com>
> ---
>  CryptoPkg/Library/OpensslLib/process_files.pl | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/CryptoPkg/Library/OpensslLib/process_files.pl
> b/CryptoPkg/Library/OpensslLib/process_files.pl
> index e277108f0734..2783ff54f95a 100755
> --- a/CryptoPkg/Library/OpensslLib/process_files.pl
> +++ b/CryptoPkg/Library/OpensslLib/process_files.pl
> @@ -132,6 +132,7 @@ foreach my $product ((@{$unified_info{libraries}},
>              # So it can reduce porting time, compile time, library size.
>              next if $s =~ "crypto/rand/randfile.c";
>              next if $s =~ "crypto/store/";
> +            next if $s =~ "crypto/err/err_all.c";
> 
>              if ($product =~ "libssl") {
>                  push @sslfilelist, '  $(OPENSSL_PATH)/' . $s . "\r\n";
> --
> 2.7.4
> 
> 
> 


  parent reply	other threads:[~2019-06-20  0:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-19  7:19 [PATCH v1 1/1] CryptoPkg/OpensslLib: Exclude err_all.c in process_files.py Xiaoyu Lu
2019-06-19 22:59 ` Laszlo Ersek
2019-06-20  0:34 ` Wang, Jian J [this message]
2019-06-20  7:54 ` [edk2-devel] " David Woodhouse
2019-06-20 14:46   ` Laszlo Ersek
2019-06-20 22:33     ` David Woodhouse
2019-06-21  8:37       ` Wang, Jian J
2019-06-24 19:54         ` Laszlo Ersek
2019-06-25  8:58           ` Wang, Jian J
2019-06-26 12:46             ` Laszlo Ersek
2019-06-26 13:16               ` Wang, Jian J

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D827630B58408649ACB04F44C510003625929BC4@SHSMSX107.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox