public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH v2] SecurityPkg: Add missing instances for build only
@ 2019-06-14  8:34 Gao, Zhichao
  2019-06-14  8:47 ` [edk2-devel] " Yao, Jiewen
  0 siblings, 1 reply; 5+ messages in thread
From: Gao, Zhichao @ 2019-06-14  8:34 UTC (permalink / raw)
  To: devel
  Cc: Bret Barkelew, Chao Zhang, Jiewen Yao, Jian Wang, Liming Gao,
	Sean Brogan, Michael Turner, Leif Lindholm, Zhichao gao

From: Bret Barkelew <Bret.Barkelew@microsoft.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1902

Add the missing instances to the [Components] of dsc file
for build only.

Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian Wang <jian.j.wang@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Signed-off-by: Zhichao gao <zhichao.gao@intel.com>
---
  V2: fix with Laszlo's comment: https://edk2.groups.io/g/devel/message/42273

 SecurityPkg/SecurityPkg.dsc | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc
index a2ee0528f0..ed0da7563d 100644
--- a/SecurityPkg/SecurityPkg.dsc
+++ b/SecurityPkg/SecurityPkg.dsc
@@ -199,6 +199,12 @@
   SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.inf
   SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.inf
 
+  SecurityPkg/Library/DxeDeferImageLoadLib/DxeDeferImageLoadLib.inf
+  SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasurementLib.inf
+  SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf
+  SecurityPkg/Library/Tcg2PpVendorLibNull/Tcg2PpVendorLibNull.inf
+  SecurityPkg/Library/TcgPpVendorLibNull/TcgPpVendorLibNull.inf
+
 [Components.IA32, Components.X64, Components.ARM, Components.AARCH64]
   SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
 
-- 
2.21.0.windows.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances for build only
  2019-06-14  8:34 [PATCH v2] SecurityPkg: Add missing instances for build only Gao, Zhichao
@ 2019-06-14  8:47 ` Yao, Jiewen
  2019-06-14  8:49   ` Ni, Ray
  0 siblings, 1 reply; 5+ messages in thread
From: Yao, Jiewen @ 2019-06-14  8:47 UTC (permalink / raw)
  To: devel@edk2.groups.io, Gao, Zhichao
  Cc: Bret Barkelew, Zhang, Chao B, Wang, Jian J, Gao, Liming,
	Sean Brogan, Michael Turner, Leif Lindholm

Hi
It is good to add those to build.

However, I think we should remove SecurityPkg\Library\DxeDeferImageLoadLib from the code base.

This lib supports old UID and may conflict with MdeModulePkg\Universal\SecurityStubDxe\Defer3rdPartyImageLoad.c


Thank you
Yao Jiewen

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Gao, Zhichao
> Sent: Friday, June 14, 2019 4:35 PM
> To: devel@edk2.groups.io
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>; Zhang, Chao B
> <chao.b.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wang,
> Jian J <jian.j.wang@intel.com>; Gao, Liming <liming.gao@intel.com>; Sean
> Brogan <sean.brogan@microsoft.com>; Michael Turner
> <Michael.Turner@microsoft.com>; Leif Lindholm <leif.lindholm@linaro.org>;
> Gao, Zhichao <zhichao.gao@intel.com>
> Subject: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances for build
> only
> 
> From: Bret Barkelew <Bret.Barkelew@microsoft.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1902
> 
> Add the missing instances to the [Components] of dsc file
> for build only.
> 
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Turner <Michael.Turner@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Signed-off-by: Zhichao gao <zhichao.gao@intel.com>
> ---
>   V2: fix with Laszlo's comment:
> https://edk2.groups.io/g/devel/message/42273
> 
>  SecurityPkg/SecurityPkg.dsc | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc
> index a2ee0528f0..ed0da7563d 100644
> --- a/SecurityPkg/SecurityPkg.dsc
> +++ b/SecurityPkg/SecurityPkg.dsc
> @@ -199,6 +199,12 @@
> 
> SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7
> .inf
> 
> SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticatio
> nLibRsa2048Sha256.inf
> 
> +  SecurityPkg/Library/DxeDeferImageLoadLib/DxeDeferImageLoadLib.inf
> +
> SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasurementLib.inf
> +  SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf
> +  SecurityPkg/Library/Tcg2PpVendorLibNull/Tcg2PpVendorLibNull.inf
> +  SecurityPkg/Library/TcgPpVendorLibNull/TcgPpVendorLibNull.inf
> +
>  [Components.IA32, Components.X64, Components.ARM,
> Components.AARCH64]
>    SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
> 
> --
> 2.21.0.windows.1
> 
> 
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances for build only
  2019-06-14  8:47 ` [edk2-devel] " Yao, Jiewen
@ 2019-06-14  8:49   ` Ni, Ray
  2019-06-17  7:53     ` Gao, Zhichao
  0 siblings, 1 reply; 5+ messages in thread
From: Ni, Ray @ 2019-06-14  8:49 UTC (permalink / raw)
  To: devel@edk2.groups.io, Yao, Jiewen, Gao, Zhichao
  Cc: Bret Barkelew, Zhang, Chao B, Wang, Jian J, Gao, Liming,
	Sean Brogan, Michael Turner, Leif Lindholm

Yes I agree.
Since UID feature was completely dropped early this year, this is a missing library that should be
removed together with UID.

Zhichao,
Can you help submit a BZ for this removal?
I am ok with your current patch to include this library. This library can be removed by further patch
that removes DxeDeferImageLoadLib.

Thanks,
Ray

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao,
> Jiewen
> Sent: Friday, June 14, 2019 4:48 PM
> To: devel@edk2.groups.io; Gao, Zhichao <zhichao.gao@intel.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>; Zhang, Chao B
> <chao.b.zhang@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Gao,
> Liming <liming.gao@intel.com>; Sean Brogan <sean.brogan@microsoft.com>;
> Michael Turner <Michael.Turner@microsoft.com>; Leif Lindholm
> <leif.lindholm@linaro.org>
> Subject: Re: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances for
> build only
> 
> Hi
> It is good to add those to build.
> 
> However, I think we should remove
> SecurityPkg\Library\DxeDeferImageLoadLib from the code base.
> 
> This lib supports old UID and may conflict with
> MdeModulePkg\Universal\SecurityStubDxe\Defer3rdPartyImageLoad.c
> 
> 
> Thank you
> Yao Jiewen
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Gao, Zhichao
> > Sent: Friday, June 14, 2019 4:35 PM
> > To: devel@edk2.groups.io
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>; Zhang, Chao B
> > <chao.b.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wang,
> > Jian J <jian.j.wang@intel.com>; Gao, Liming <liming.gao@intel.com>;
> > Sean Brogan <sean.brogan@microsoft.com>; Michael Turner
> > <Michael.Turner@microsoft.com>; Leif Lindholm
> > <leif.lindholm@linaro.org>; Gao, Zhichao <zhichao.gao@intel.com>
> > Subject: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances
> > for build only
> >
> > From: Bret Barkelew <Bret.Barkelew@microsoft.com>
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1902
> >
> > Add the missing instances to the [Components] of dsc file for build
> > only.
> >
> > Cc: Chao Zhang <chao.b.zhang@intel.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Jian Wang <jian.j.wang@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Michael Turner <Michael.Turner@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Signed-off-by: Zhichao gao <zhichao.gao@intel.com>
> > ---
> >   V2: fix with Laszlo's comment:
> > https://edk2.groups.io/g/devel/message/42273
> >
> >  SecurityPkg/SecurityPkg.dsc | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc
> > index a2ee0528f0..ed0da7563d 100644
> > --- a/SecurityPkg/SecurityPkg.dsc
> > +++ b/SecurityPkg/SecurityPkg.dsc
> > @@ -199,6 +199,12 @@
> >
> >
> SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs
> > 7
> > .inf
> >
> >
> SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticatio
> > nLibRsa2048Sha256.inf
> >
> > +  SecurityPkg/Library/DxeDeferImageLoadLib/DxeDeferImageLoadLib.inf
> > +
> >
> SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasurementLib.inf
> > +  SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf
> > +  SecurityPkg/Library/Tcg2PpVendorLibNull/Tcg2PpVendorLibNull.inf
> > +  SecurityPkg/Library/TcgPpVendorLibNull/TcgPpVendorLibNull.inf
> > +
> >  [Components.IA32, Components.X64, Components.ARM,
> Components.AARCH64]
> >    SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
> >
> > --
> > 2.21.0.windows.1
> >
> >
> >
> 
> 
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances for build only
  2019-06-14  8:49   ` Ni, Ray
@ 2019-06-17  7:53     ` Gao, Zhichao
  2019-06-25  6:56       ` Wang, Jian J
  0 siblings, 1 reply; 5+ messages in thread
From: Gao, Zhichao @ 2019-06-17  7:53 UTC (permalink / raw)
  To: Ni, Ray, devel@edk2.groups.io, Yao, Jiewen, Zhang, Shenglei
  Cc: Bret Barkelew, Zhang, Chao B, Wang, Jian J, Gao, Liming,
	Sean Brogan, Michael Turner, Leif Lindholm

Added: https://bugzilla.tianocore.org/show_bug.cgi?id=1919

Thanks,
Zhichao

> -----Original Message-----
> From: Ni, Ray
> Sent: Friday, June 14, 2019 4:50 PM
> To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Gao,
> Zhichao <zhichao.gao@intel.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>; Zhang, Chao B
> <chao.b.zhang@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Gao,
> Liming <liming.gao@intel.com>; Sean Brogan <sean.brogan@microsoft.com>;
> Michael Turner <Michael.Turner@microsoft.com>; Leif Lindholm
> <leif.lindholm@linaro.org>
> Subject: RE: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances for
> build only
> 
> Yes I agree.
> Since UID feature was completely dropped early this year, this is a missing
> library that should be removed together with UID.
> 
> Zhichao,
> Can you help submit a BZ for this removal?
> I am ok with your current patch to include this library. This library can be
> removed by further patch that removes DxeDeferImageLoadLib.
> 
> Thanks,
> Ray
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao,
> > Jiewen
> > Sent: Friday, June 14, 2019 4:48 PM
> > To: devel@edk2.groups.io; Gao, Zhichao <zhichao.gao@intel.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>; Zhang, Chao B
> > <chao.b.zhang@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Gao,
> > Liming <liming.gao@intel.com>; Sean Brogan
> > <sean.brogan@microsoft.com>; Michael Turner
> > <Michael.Turner@microsoft.com>; Leif Lindholm
> > <leif.lindholm@linaro.org>
> > Subject: Re: [edk2-devel] [PATCH v2] SecurityPkg: Add missing
> > instances for build only
> >
> > Hi
> > It is good to add those to build.
> >
> > However, I think we should remove
> > SecurityPkg\Library\DxeDeferImageLoadLib from the code base.
> >
> > This lib supports old UID and may conflict with
> > MdeModulePkg\Universal\SecurityStubDxe\Defer3rdPartyImageLoad.c
> >
> >
> > Thank you
> > Yao Jiewen
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> > > Of Gao, Zhichao
> > > Sent: Friday, June 14, 2019 4:35 PM
> > > To: devel@edk2.groups.io
> > > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>; Zhang, Chao B
> > > <chao.b.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wang,
> > > Jian J <jian.j.wang@intel.com>; Gao, Liming <liming.gao@intel.com>;
> > > Sean Brogan <sean.brogan@microsoft.com>; Michael Turner
> > > <Michael.Turner@microsoft.com>; Leif Lindholm
> > > <leif.lindholm@linaro.org>; Gao, Zhichao <zhichao.gao@intel.com>
> > > Subject: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances
> > > for build only
> > >
> > > From: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > >
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1902
> > >
> > > Add the missing instances to the [Components] of dsc file for build
> > > only.
> > >
> > > Cc: Chao Zhang <chao.b.zhang@intel.com>
> > > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > > Cc: Jian Wang <jian.j.wang@intel.com>
> > > Cc: Liming Gao <liming.gao@intel.com>
> > > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > > Cc: Michael Turner <Michael.Turner@microsoft.com>
> > > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > > Signed-off-by: Zhichao gao <zhichao.gao@intel.com>
> > > ---
> > >   V2: fix with Laszlo's comment:
> > > https://edk2.groups.io/g/devel/message/42273
> > >
> > >  SecurityPkg/SecurityPkg.dsc | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > >
> > > diff --git a/SecurityPkg/SecurityPkg.dsc
> > > b/SecurityPkg/SecurityPkg.dsc index a2ee0528f0..ed0da7563d 100644
> > > --- a/SecurityPkg/SecurityPkg.dsc
> > > +++ b/SecurityPkg/SecurityPkg.dsc
> > > @@ -199,6 +199,12 @@
> > >
> > >
> >
> SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs
> > > 7
> > > .inf
> > >
> > >
> >
> SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticatio
> > > nLibRsa2048Sha256.inf
> > >
> > > +
> SecurityPkg/Library/DxeDeferImageLoadLib/DxeDeferImageLoadLib.inf
> > > +
> > >
> >
> SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasurementLib.inf
> > > +
> > > + SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.in
> > > + f  SecurityPkg/Library/Tcg2PpVendorLibNull/Tcg2PpVendorLibNull.inf
> > > +  SecurityPkg/Library/TcgPpVendorLibNull/TcgPpVendorLibNull.inf
> > > +
> > >  [Components.IA32, Components.X64, Components.ARM,
> > Components.AARCH64]
> > >    SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
> > >
> > > --
> > > 2.21.0.windows.1
> > >
> > >
> > >
> >
> >
> > 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances for build only
  2019-06-17  7:53     ` Gao, Zhichao
@ 2019-06-25  6:56       ` Wang, Jian J
  0 siblings, 0 replies; 5+ messages in thread
From: Wang, Jian J @ 2019-06-25  6:56 UTC (permalink / raw)
  To: Gao, Zhichao, Ni, Ray, devel@edk2.groups.io, Yao, Jiewen,
	Zhang, Shenglei
  Cc: Bret Barkelew, Zhang, Chao B, Gao, Liming, Sean Brogan,
	Michael Turner, Leif Lindholm

Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

> -----Original Message-----
> From: Gao, Zhichao
> Sent: Monday, June 17, 2019 3:54 PM
> To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io; Yao, Jiewen
> <jiewen.yao@intel.com>; Zhang, Shenglei <shenglei.zhang@intel.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>; Zhang, Chao B
> <chao.b.zhang@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Michael
> Turner <Michael.Turner@microsoft.com>; Leif Lindholm
> <leif.lindholm@linaro.org>
> Subject: RE: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances for build
> only
> 
> Added: https://bugzilla.tianocore.org/show_bug.cgi?id=1919
> 
> Thanks,
> Zhichao
> 
> > -----Original Message-----
> > From: Ni, Ray
> > Sent: Friday, June 14, 2019 4:50 PM
> > To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Gao,
> > Zhichao <zhichao.gao@intel.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>; Zhang, Chao B
> > <chao.b.zhang@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Gao,
> > Liming <liming.gao@intel.com>; Sean Brogan <sean.brogan@microsoft.com>;
> > Michael Turner <Michael.Turner@microsoft.com>; Leif Lindholm
> > <leif.lindholm@linaro.org>
> > Subject: RE: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances for
> > build only
> >
> > Yes I agree.
> > Since UID feature was completely dropped early this year, this is a missing
> > library that should be removed together with UID.
> >
> > Zhichao,
> > Can you help submit a BZ for this removal?
> > I am ok with your current patch to include this library. This library can be
> > removed by further patch that removes DxeDeferImageLoadLib.
> >
> > Thanks,
> > Ray
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao,
> > > Jiewen
> > > Sent: Friday, June 14, 2019 4:48 PM
> > > To: devel@edk2.groups.io; Gao, Zhichao <zhichao.gao@intel.com>
> > > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>; Zhang, Chao B
> > > <chao.b.zhang@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Gao,
> > > Liming <liming.gao@intel.com>; Sean Brogan
> > > <sean.brogan@microsoft.com>; Michael Turner
> > > <Michael.Turner@microsoft.com>; Leif Lindholm
> > > <leif.lindholm@linaro.org>
> > > Subject: Re: [edk2-devel] [PATCH v2] SecurityPkg: Add missing
> > > instances for build only
> > >
> > > Hi
> > > It is good to add those to build.
> > >
> > > However, I think we should remove
> > > SecurityPkg\Library\DxeDeferImageLoadLib from the code base.
> > >
> > > This lib supports old UID and may conflict with
> > > MdeModulePkg\Universal\SecurityStubDxe\Defer3rdPartyImageLoad.c
> > >
> > >
> > > Thank you
> > > Yao Jiewen
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> > > > Of Gao, Zhichao
> > > > Sent: Friday, June 14, 2019 4:35 PM
> > > > To: devel@edk2.groups.io
> > > > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>; Zhang, Chao B
> > > > <chao.b.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wang,
> > > > Jian J <jian.j.wang@intel.com>; Gao, Liming <liming.gao@intel.com>;
> > > > Sean Brogan <sean.brogan@microsoft.com>; Michael Turner
> > > > <Michael.Turner@microsoft.com>; Leif Lindholm
> > > > <leif.lindholm@linaro.org>; Gao, Zhichao <zhichao.gao@intel.com>
> > > > Subject: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances
> > > > for build only
> > > >
> > > > From: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > > >
> > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1902
> > > >
> > > > Add the missing instances to the [Components] of dsc file for build
> > > > only.
> > > >
> > > > Cc: Chao Zhang <chao.b.zhang@intel.com>
> > > > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > > > Cc: Jian Wang <jian.j.wang@intel.com>
> > > > Cc: Liming Gao <liming.gao@intel.com>
> > > > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > > > Cc: Michael Turner <Michael.Turner@microsoft.com>
> > > > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > > > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > > > Signed-off-by: Zhichao gao <zhichao.gao@intel.com>
> > > > ---
> > > >   V2: fix with Laszlo's comment:
> > > > https://edk2.groups.io/g/devel/message/42273
> > > >
> > > >  SecurityPkg/SecurityPkg.dsc | 6 ++++++
> > > >  1 file changed, 6 insertions(+)
> > > >
> > > > diff --git a/SecurityPkg/SecurityPkg.dsc
> > > > b/SecurityPkg/SecurityPkg.dsc index a2ee0528f0..ed0da7563d 100644
> > > > --- a/SecurityPkg/SecurityPkg.dsc
> > > > +++ b/SecurityPkg/SecurityPkg.dsc
> > > > @@ -199,6 +199,12 @@
> > > >
> > > >
> > >
> > SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs
> > > > 7
> > > > .inf
> > > >
> > > >
> > >
> > SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticatio
> > > > nLibRsa2048Sha256.inf
> > > >
> > > > +
> > SecurityPkg/Library/DxeDeferImageLoadLib/DxeDeferImageLoadLib.inf
> > > > +
> > > >
> > >
> > SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasurementLib.inf
> > > > +
> > > > + SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.in
> > > > + f  SecurityPkg/Library/Tcg2PpVendorLibNull/Tcg2PpVendorLibNull.inf
> > > > +  SecurityPkg/Library/TcgPpVendorLibNull/TcgPpVendorLibNull.inf
> > > > +
> > > >  [Components.IA32, Components.X64, Components.ARM,
> > > Components.AARCH64]
> > > >    SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
> > > >
> > > > --
> > > > 2.21.0.windows.1
> > > >
> > > >
> > > >
> > >
> > >
> > > 


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-06-25  6:56 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-14  8:34 [PATCH v2] SecurityPkg: Add missing instances for build only Gao, Zhichao
2019-06-14  8:47 ` [edk2-devel] " Yao, Jiewen
2019-06-14  8:49   ` Ni, Ray
2019-06-17  7:53     ` Gao, Zhichao
2019-06-25  6:56       ` Wang, Jian J

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox