From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: jian.j.wang@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Mon, 24 Jun 2019 23:56:18 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jun 2019 23:56:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,415,1557212400"; d="scan'208";a="166586360" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga006.jf.intel.com with ESMTP; 24 Jun 2019 23:56:17 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 24 Jun 2019 23:56:16 -0700 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.173]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.72]) with mapi id 14.03.0439.000; Tue, 25 Jun 2019 14:56:15 +0800 From: "Wang, Jian J" To: "Gao, Zhichao" , "Ni, Ray" , "devel@edk2.groups.io" , "Yao, Jiewen" , "Zhang, Shenglei" CC: Bret Barkelew , "Zhang, Chao B" , "Gao, Liming" , Sean Brogan , Michael Turner , Leif Lindholm Subject: Re: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances for build only Thread-Topic: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances for build only Thread-Index: AQHVIowiGRltDD3FgkqNIZk1ih4qHqaaUIKAgAAAkoCABKdIgIANCKRw Date: Tue, 25 Jun 2019 06:56:14 +0000 Message-ID: References: <20190614083438.10728-1-zhichao.gao@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503F6B3E82@shsmsx102.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5C1C6A69@SHSMSX104.ccr.corp.intel.com> <3CE959C139B4C44DBEA1810E3AA6F9000B7F5C50@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B7F5C50@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjJlYzhjZTctOGJiNy00MTY5LThkN2ItZmJjYmRjNjcwYTI3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSFZRMzdOUUtQZVhuR0hjSWhFUDdKc2kxOFlkWVBWVSs4cXA2aVN6RFwvT3BHMHhzdzduWGJBRXNZZE1taThxVXUifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jian.j.wang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jian J Wang > -----Original Message----- > From: Gao, Zhichao > Sent: Monday, June 17, 2019 3:54 PM > To: Ni, Ray ; devel@edk2.groups.io; Yao, Jiewen > ; Zhang, Shenglei > Cc: Bret Barkelew ; Zhang, Chao B > ; Wang, Jian J ; Gao, Lim= ing > ; Sean Brogan ; Michael > Turner ; Leif Lindholm > > Subject: RE: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances = for build > only >=20 > Added: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1919 >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: Ni, Ray > > Sent: Friday, June 14, 2019 4:50 PM > > To: devel@edk2.groups.io; Yao, Jiewen ; Gao, > > Zhichao > > Cc: Bret Barkelew ; Zhang, Chao B > > ; Wang, Jian J ; Gao, > > Liming ; Sean Brogan = ; > > Michael Turner ; Leif Lindholm > > > > Subject: RE: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instance= s for > > build only > > > > Yes I agree. > > Since UID feature was completely dropped early this year, this is a mi= ssing > > library that should be removed together with UID. > > > > Zhichao, > > Can you help submit a BZ for this removal? > > I am ok with your current patch to include this library. This library = can be > > removed by further patch that removes DxeDeferImageLoadLib. > > > > Thanks, > > Ray > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of Yao, > > > Jiewen > > > Sent: Friday, June 14, 2019 4:48 PM > > > To: devel@edk2.groups.io; Gao, Zhichao > > > Cc: Bret Barkelew ; Zhang, Chao B > > > ; Wang, Jian J ; Gao, > > > Liming ; Sean Brogan > > > ; Michael Turner > > > ; Leif Lindholm > > > > > > Subject: Re: [edk2-devel] [PATCH v2] SecurityPkg: Add missing > > > instances for build only > > > > > > Hi > > > It is good to add those to build. > > > > > > However, I think we should remove > > > SecurityPkg\Library\DxeDeferImageLoadLib from the code base. > > > > > > This lib supports old UID and may conflict with > > > MdeModulePkg\Universal\SecurityStubDxe\Defer3rdPartyImageLoad.c > > > > > > > > > Thank you > > > Yao Jiewen > > > > > > > -----Original Message----- > > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf > > > > Of Gao, Zhichao > > > > Sent: Friday, June 14, 2019 4:35 PM > > > > To: devel@edk2.groups.io > > > > Cc: Bret Barkelew ; Zhang, Chao B > > > > ; Yao, Jiewen ; Wang= , > > > > Jian J ; Gao, Liming = ; > > > > Sean Brogan ; Michael Turner > > > > ; Leif Lindholm > > > > ; Gao, Zhichao > > > > Subject: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instance= s > > > > for build only > > > > > > > > From: Bret Barkelew > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1902 > > > > > > > > Add the missing instances to the [Components] of dsc file for buil= d > > > > only. > > > > > > > > Cc: Chao Zhang > > > > Cc: Jiewen Yao > > > > Cc: Jian Wang > > > > Cc: Liming Gao > > > > Cc: Sean Brogan > > > > Cc: Michael Turner > > > > Cc: Bret Barkelew > > > > Cc: Leif Lindholm > > > > Signed-off-by: Zhichao gao > > > > --- > > > > V2: fix with Laszlo's comment: > > > > https://edk2.groups.io/g/devel/message/42273 > > > > > > > > SecurityPkg/SecurityPkg.dsc | 6 ++++++ > > > > 1 file changed, 6 insertions(+) > > > > > > > > diff --git a/SecurityPkg/SecurityPkg.dsc > > > > b/SecurityPkg/SecurityPkg.dsc index a2ee0528f0..ed0da7563d 100644 > > > > --- a/SecurityPkg/SecurityPkg.dsc > > > > +++ b/SecurityPkg/SecurityPkg.dsc > > > > @@ -199,6 +199,12 @@ > > > > > > > > > > > > > SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs > > > > 7 > > > > .inf > > > > > > > > > > > > > SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticatio > > > > nLibRsa2048Sha256.inf > > > > > > > > + > > SecurityPkg/Library/DxeDeferImageLoadLib/DxeDeferImageLoadLib.inf > > > > + > > > > > > > > > SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasurementLib.inf > > > > + > > > > + SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.= in > > > > + f SecurityPkg/Library/Tcg2PpVendorLibNull/Tcg2PpVendorLibNull.i= nf > > > > + SecurityPkg/Library/TcgPpVendorLibNull/TcgPpVendorLibNull.inf > > > > + > > > > [Components.IA32, Components.X64, Components.ARM, > > > Components.AARCH64] > > > > SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf > > > > > > > > -- > > > > 2.21.0.windows.1 > > > > > > > > > > > > > > > > > > > > >=20