From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: jian.j.wang@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Tue, 25 Jun 2019 22:34:22 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jun 2019 22:34:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,418,1557212400"; d="scan'208";a="360629898" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga006.fm.intel.com with ESMTP; 25 Jun 2019 22:34:20 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 25 Jun 2019 22:34:21 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 25 Jun 2019 22:34:20 -0700 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.173]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.246]) with mapi id 14.03.0439.000; Wed, 26 Jun 2019 13:34:17 +0800 From: "Wang, Jian J" To: "Yao, Jiewen" , "devel@edk2.groups.io" CC: "Zhang, Chao B" , "Hernandez Beltran, Jorge" , "Han, Harry" Subject: Re: [PATCH v4 0/3] Common OBB verification feature Thread-Topic: [PATCH v4 0/3] Common OBB verification feature Thread-Index: AQHVJwvAHWpXTgC3n0K1LcEDuU4J+aasb5XQgAEDLcA= Date: Wed, 26 Jun 2019 05:34:17 +0000 Message-ID: References: <20190620015859.6424-1-jian.j.wang@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503F6CC3FD@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503F6CC3FD@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTQ0ZjIwMjUtOGMyNi00ZmU5LThlZDgtYjE0MWFiOTdkZDQ1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVFhqbXA5MnJPMXhOTE1cL0lPUk1JTU1XXC9weEUwTnhFTkpQOUx1bk9YV01KdktNdU56QkhndkRtcjBrenBLTE9hIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jian.j.wang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Jiewen. I'll add it with a few code style corrections. Anyone else has any comments? Regards, Jian > -----Original Message----- > From: Yao, Jiewen > Sent: Tuesday, June 25, 2019 10:09 PM > To: Wang, Jian J ; devel@edk2.groups.io > Cc: Zhang, Chao B ; Hernandez Beltran, Jorge > ; Han, Harry > Subject: RE: [PATCH v4 0/3] Common OBB verification feature >=20 > Thanks Jian. Comment below: >=20 > 1) My previous comment 8 is NOT addressed. >=20 > Please add assert for "StoredHashFvPpi->FvNumber". > if (!EFI_ERROR(Status) && StoredHashFvPpi !=3D NULL && StoredHashFvPpi- > >FvNumber > 0) { >=20 > With that fixed, reviewed-by: Jiewen.yao@intel.com >=20 >=20 > Thank you > Yao Jiewen >=20 >=20 > > -----Original Message----- > > From: Wang, Jian J > > Sent: Thursday, June 20, 2019 9:59 AM > > To: devel@edk2.groups.io > > Cc: Zhang, Chao B ; Yao, Jiewen > > ; Hernandez Beltran, Jorge > > ; Han, Harry > > Subject: [PATCH v4 0/3] Common OBB verification feature > > > > >V4: change FV_HASH_FLAG_BOOT_MODE definition > > > > >V3: update per Jiewen's comments > > > > >V2: fix parameter description error found by ECC > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1617 > > > > Cc: Chao Zhang > > Cc: Jiewen Yao > > Cc: "Hernandez Beltran, Jorge" > > Cc: Harry Han > > > > Jian J Wang (3): > > SecurityPkg: add definitions for OBB verification > > SecurityPkg/FvReportPei: implement a common FV verifier and reporter > > SecurityPkg: add FvReportPei.inf in dsc for build validation > > > > SecurityPkg/FvReportPei/FvReportPei.c | 416 > > ++++++++++++++++++ > > SecurityPkg/FvReportPei/FvReportPei.h | 122 +++++ > > SecurityPkg/FvReportPei/FvReportPei.inf | 57 +++ > > SecurityPkg/FvReportPei/FvReportPei.uni | 14 + > > .../FvReportPei/FvReportPeiPeiExtra.uni | 12 + > > .../Ppi/FirmwareVolumeInfoStoredHashFv.h | 62 +++ > > SecurityPkg/SecurityPkg.dec | 9 + > > SecurityPkg/SecurityPkg.dsc | 5 + > > 8 files changed, 697 insertions(+) > > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.c > > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.h > > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.inf > > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.uni > > create mode 100644 SecurityPkg/FvReportPei/FvReportPeiPeiExtra.uni > > create mode 100644 > > SecurityPkg/Include/Ppi/FirmwareVolumeInfoStoredHashFv.h > > > > -- > > 2.17.1.windows.2