From: "Wang, Jian J" <jian.j.wang@intel.com>
To: "Zhang, Chao B" <chao.b.zhang@intel.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Hernandez Beltran, Jorge" <jorge.hernandez.beltran@intel.com>,
"Han, Harry" <harry.han@intel.com>
Subject: Re: [PATCH v4 0/3] Common OBB verification feature
Date: Wed, 26 Jun 2019 07:43:38 +0000 [thread overview]
Message-ID: <D827630B58408649ACB04F44C51000362592C8EF@SHSMSX107.ccr.corp.intel.com> (raw)
In-Reply-To: <FF72C7E4248F3C4E9BDF19D4918E90F24DEDF136@shsmsx102.ccr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 4492 bytes --]
Thanks, Chao. You're right your way is better. I'll update it.
Regards,
Jian
From: Zhang, Chao B
Sent: Wednesday, June 26, 2019 3:29 PM
To: Wang, Jian J <jian.j.wang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io
Cc: Hernandez Beltran, Jorge <jorge.hernandez.beltran@intel.com>; Han, Harry <harry.han@intel.com>
Subject: RE: [PATCH v4 0/3] Common OBB verification feature
Hi Jian:
Patch is good to me. Just one comment for coding style
If (AlgInfo->HashAll (FvBuffer, (UINTN)FvInfo[FvIndex].Length, FvHashValue) == FALSE)
Is it better to be if (!AlgInfo->HashAll (FvBuffer, (UINTN)FvInfo[FvIndex].Length, FvHashValue) ) ?
From: Wang, Jian J
Sent: Wednesday, June 26, 2019 1:34 PM
To: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Zhang, Chao B <chao.b.zhang@intel.com<mailto:chao.b.zhang@intel.com>>; Hernandez Beltran, Jorge <jorge.hernandez.beltran@intel.com<mailto:jorge.hernandez.beltran@intel.com>>; Han, Harry <harry.han@intel.com<mailto:harry.han@intel.com>>
Subject: RE: [PATCH v4 0/3] Common OBB verification feature
Thanks Jiewen. I'll add it with a few code style corrections.
Anyone else has any comments?
Regards,
Jian
> -----Original Message-----
> From: Yao, Jiewen
> Sent: Tuesday, June 25, 2019 10:09 PM
> To: Wang, Jian J <jian.j.wang@intel.com<mailto:jian.j.wang@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> Cc: Zhang, Chao B <chao.b.zhang@intel.com<mailto:chao.b.zhang@intel.com>>; Hernandez Beltran, Jorge
> <jorge.hernandez.beltran@intel.com<mailto:jorge.hernandez.beltran@intel.com>>; Han, Harry <harry.han@intel.com<mailto:harry.han@intel.com>>
> Subject: RE: [PATCH v4 0/3] Common OBB verification feature
>
> Thanks Jian. Comment below:
>
> 1) My previous comment 8 is NOT addressed.
>
> Please add assert for "StoredHashFvPpi->FvNumber".
> if (!EFI_ERROR(Status) && StoredHashFvPpi != NULL && StoredHashFvPpi-
> >FvNumber > 0) {
>
> With that fixed, reviewed-by: Jiewen.yao@intel.com<mailto:Jiewen.yao@intel.com>
>
>
> Thank you
> Yao Jiewen
>
>
> > -----Original Message-----
> > From: Wang, Jian J
> > Sent: Thursday, June 20, 2019 9:59 AM
> > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> > Cc: Zhang, Chao B <chao.b.zhang@intel.com<mailto:chao.b.zhang@intel.com>>; Yao, Jiewen
> > <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; Hernandez Beltran, Jorge
> > <jorge.hernandez.beltran@intel.com<mailto:jorge.hernandez.beltran@intel.com>>; Han, Harry <harry.han@intel.com<mailto:harry.han@intel.com>>
> > Subject: [PATCH v4 0/3] Common OBB verification feature
> >
> > >V4: change FV_HASH_FLAG_BOOT_MODE definition
> >
> > >V3: update per Jiewen's comments
> >
> > >V2: fix parameter description error found by ECC
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=1617
> >
> > Cc: Chao Zhang <chao.b.zhang@intel.com<mailto:chao.b.zhang@intel.com>>
> > Cc: Jiewen Yao <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
> > Cc: "Hernandez Beltran, Jorge" <jorge.hernandez.beltran@intel.com<mailto:jorge.hernandez.beltran@intel.com>>
> > Cc: Harry Han <harry.han@intel.com<mailto:harry.han@intel.com>>
> >
> > Jian J Wang (3):
> > SecurityPkg: add definitions for OBB verification
> > SecurityPkg/FvReportPei: implement a common FV verifier and reporter
> > SecurityPkg: add FvReportPei.inf in dsc for build validation
> >
> > SecurityPkg/FvReportPei/FvReportPei.c | 416
> > ++++++++++++++++++
> > SecurityPkg/FvReportPei/FvReportPei.h | 122 +++++
> > SecurityPkg/FvReportPei/FvReportPei.inf | 57 +++
> > SecurityPkg/FvReportPei/FvReportPei.uni | 14 +
> > .../FvReportPei/FvReportPeiPeiExtra.uni | 12 +
> > .../Ppi/FirmwareVolumeInfoStoredHashFv.h | 62 +++
> > SecurityPkg/SecurityPkg.dec | 9 +
> > SecurityPkg/SecurityPkg.dsc | 5 +
> > 8 files changed, 697 insertions(+)
> > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.c
> > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.h
> > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.inf
> > create mode 100644 SecurityPkg/FvReportPei/FvReportPei.uni
> > create mode 100644 SecurityPkg/FvReportPei/FvReportPeiPeiExtra.uni
> > create mode 100644
> > SecurityPkg/Include/Ppi/FirmwareVolumeInfoStoredHashFv.h
> >
> > --
> > 2.17.1.windows.2
[-- Attachment #2: Type: text/html, Size: 15068 bytes --]
next prev parent reply other threads:[~2019-06-26 7:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 1:58 [PATCH v4 0/3] Common OBB verification feature Wang, Jian J
2019-06-20 1:58 ` [PATCH v4 1/3] SecurityPkg: add definitions for OBB verification Wang, Jian J
2019-06-20 1:58 ` [PATCH v4 2/3] SecurityPkg/FvReportPei: implement a common FV verifier and reporter Wang, Jian J
2019-06-20 1:58 ` [PATCH v4 3/3] SecurityPkg: add FvReportPei.inf in dsc for build validation Wang, Jian J
2019-06-25 14:08 ` [PATCH v4 0/3] Common OBB verification feature Yao, Jiewen
2019-06-26 5:34 ` Wang, Jian J
2019-06-26 7:29 ` Zhang, Chao B
2019-06-26 7:43 ` Wang, Jian J [this message]
2019-06-26 8:18 ` Zhang, Chao B
[not found] ` <15ABA8C58ECE3396.16820@groups.io>
2019-06-26 7:59 ` [edk2-devel] " Wang, Jian J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D827630B58408649ACB04F44C51000362592C8EF@SHSMSX107.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox