Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/OpensslLib: Exclude err_all.c in process_files.py

["Wang, Jian J" <jian.j.wang@intel.com>]

Laszlo,

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Wednesday, June 26, 2019 8:46 PM
> To: devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>;
> dwmw2@infradead.org; Lu, XiaoyuX <xiaoyux.lu@intel.com>
> Cc: Ye, Ting <ting.ye@intel.com>; Richard Levitte <levitte@openssl.org>
> Subject: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/OpensslLib: Exclude
> err_all.c in process_files.py
> 
> Jian,
> 
> On 06/25/19 10:58, Wang, Jian J wrote:
> 
> > I take this as agreement. I pushed this patch at (fixed file ext)
> >
> > 51f7a3e6c5192d3f9a0fa63b0b5617c151180ad7
> 
> Please pay more attention to the process.
> 
> First, you pushed the patch, but the BZ (1881) is still open. You or
> XiaoyuX should have closed the BZ with a reference to the commit. I'm
> doing that now.
> 

Got it. I'll keep it in mind. Thanks.

> Second, in commit 51f7a3e6c519, you failed to pick up my R-b from the list:
> 
> http://mid.mail-archive.com/22434e9b-745c-671c-2b71-
> 43f5ecb49848@redhat.com
> 
> My suggestion is, just before you push a patch, go through the entire
> mailing list thread for one last time, to make sure no feedback is lost.
> 
> (Obviously, if your MUA doesn't offer a threaded view, this is quite
> difficult. Even in that case though, you could filter the list folder
> for the particular subject, at the least.)
> 

My apologies. I remember I did go through the list but still missed it.

Regards,
Jian
> > Above one is in our plan. I added BZ#1936 for this one.
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=1936
> 
> That's appreciated.
> 
> Laszlo
> 
>