From: "Wang, Jian J" <jian.j.wang@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"lersek@redhat.com" <lersek@redhat.com>,
"Desai, Imran" <imran.desai@intel.com>
Cc: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
"Zhang, Chao B" <chao.b.zhang@intel.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
"Leif Lindholm" <leif.lindholm@linaro.org>,
"Gao, Liming" <liming.gao@intel.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Stefan Berger" <stefanb@linux.ibm.com>
Subject: Re: [edk2-devel] [PATCH 0/5] MdePkg, SecurityPkg, OvmfPkg: revert unreviewed SM3 patches
Date: Fri, 5 Jul 2019 03:08:12 +0000 [thread overview]
Message-ID: <D827630B58408649ACB04F44C51000362593A3C4@SHSMSX107.ccr.corp.intel.com> (raw)
In-Reply-To: <ac5b02f7-3645-d8c4-5b05-bdcc785be684@redhat.com>
Hi Laszlo,
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Friday, July 05, 2019 12:05 AM
> To: edk2-devel-groups-io <devel@edk2.groups.io>; Desai, Imran
> <imran.desai@intel.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Zhang, Chao B
> <chao.b.zhang@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Yao,
> Jiewen <jiewen.yao@intel.com>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Gao,
> Liming <liming.gao@intel.com>; Marc-André Lureau
> <marcandre.lureau@redhat.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Stefan Berger <stefanb@linux.ibm.com>
> Subject: Re: [edk2-devel] [PATCH 0/5] MdePkg, SecurityPkg, OvmfPkg:
> revert unreviewed SM3 patches
>
> On 07/04/19 11:46, Laszlo Ersek wrote:
> > Repo: https://github.com/lersek/edk2.git
> > Branch: revert_unreviewed_bz1781
> >
> > The MdePkg patch and the OvmfPkg patch committed for
> > <https://bugzilla.tianocore.org/show_bug.cgi?id=1781> had not been
> > reviewed appropriately, so they must be reverted. Due to the MdePkg
> > patch being the basis of the entire series, the SecurityPkg patches in
> > the middle have to be reverted as well. (Leif pointed out that at least
> > some of the SecurityPkg patches were not reviewed *on the list* either,
> > so there's that too.)
>
> I've now pushed this series (commit range 1ec05b81e59f..6a34c1ce7054),
> with Leif's (as a steward's) R-b, and Phil's R-b.
>
> If these patches had been normal patches, obviously I would have waited
> for package maintainer review. However, these are *not* normal patches;
> they are reverts which return the tree to an earlier state -- to a state
> where unreviewed patches had not gone in yet. There's an argument to be
> made that Jian should have reverted the original patches without me
> having to post a revert series to the list at all -- either way, this
> has been urgent because the delta with the unreviewed patches "in"
> should be as minimal as possible. (Which is why I took it upon me to
> send the set.) For example, a bisection should preferably not hit the
> unreviewed range (good point from Leif). Furthermore, if we diverge too
> much meanwhile, then the reverts themselves could become messy.
>
Understood. Thanks for doing this for me.
Regards,
Jian
> Imran: please resubmit your patches now. Please pay attention to shallow
> threading, and to actually working CC's. Regarding the SecurityPkg
> patches, if you are going to post them unchanged, please preserve the
> Reviewed-by tags from the SecurityPkg maintainers, but *ONLY IF* those
> Reviewed-by tags had been given publicly, on the list. (In other words,
> if they can be found in the mailing list archive.)
>
> Thanks
> Laszlo
>
>
prev parent reply other threads:[~2019-07-05 3:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 9:46 [PATCH 0/5] MdePkg, SecurityPkg, OvmfPkg: revert unreviewed SM3 patches Laszlo Ersek
2019-07-04 9:46 ` [PATCH 1/5] Revert "OvmfPkg: link SM3 support into Tcg2Pei and Tcg2Dxe" Laszlo Ersek
2019-07-04 9:46 ` [PATCH 2/5] Revert "SecurityPkg: set SM3 bit in TPM 2.0 hash mask by default" Laszlo Ersek
2019-07-04 9:46 ` [PATCH 3/5] Revert "SecurityPkg/HashLibBaseCryptoRouter: recognize the SM3 digest algorithm" Laszlo Ersek
2019-07-04 9:46 ` [PATCH 4/5] Revert "SecurityPkg: introduce " Laszlo Ersek
2019-07-04 9:46 ` [PATCH 5/5] Revert "MdePkg/Protocol/Hash: introduce GUID for SM3" Laszlo Ersek
2019-07-04 9:59 ` [edk2-devel] [PATCH 0/5] MdePkg, SecurityPkg, OvmfPkg: revert unreviewed SM3 patches Leif Lindholm
2019-07-04 10:58 ` Philippe Mathieu-Daudé
2019-07-04 16:05 ` Laszlo Ersek
2019-07-04 18:13 ` Philippe Mathieu-Daudé
2019-07-05 3:08 ` Wang, Jian J [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D827630B58408649ACB04F44C51000362593A3C4@SHSMSX107.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox