From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: jian.j.wang@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Tue, 09 Jul 2019 02:54:43 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jul 2019 02:54:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,470,1557212400"; d="scan'208";a="173520304" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 09 Jul 2019 02:54:42 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 9 Jul 2019 02:54:42 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 9 Jul 2019 02:54:41 -0700 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.162]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.55]) with mapi id 14.03.0439.000; Tue, 9 Jul 2019 17:54:40 +0800 From: "Wang, Jian J" To: "devel@edk2.groups.io" , "leif.lindholm@linaro.org" CC: Ard Biesheuvel , "Kinney, Michael D" , "Gao, Liming" Subject: Re: [edk2-devel] [edk2-platforms: PATCH] Readme.md: Change way of cloning edk2 repo Thread-Topic: [edk2-devel] [edk2-platforms: PATCH] Readme.md: Change way of cloning edk2 repo Thread-Index: AQHVNjiZTDkdrrENGUiclj5T/2P22abCC1hg Date: Tue, 9 Jul 2019 09:54:39 +0000 Message-ID: References: <20190709072142.6500-1-jian.j.wang@intel.com> <20190709092800.vz5osqhm6w436pix@bivouac.eciton.net> In-Reply-To: <20190709092800.vz5osqhm6w436pix@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODZkODgzZTctNjJjZS00ODRmLWFhY2YtNjUzNWE4M2UzMzhjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQ01JTTFyUVUyWjBOZU52c05BMnZXdEhOcTBQXC9kZVBEMGd2eStteUZBM0tydkthOGR6Y0tidG40ZFh1RHBlbncifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jian.j.wang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leif, I'll try push first (not sure I have write access right). If I can't, plea= se do it for me. Regards, Jian > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Tuesday, July 09, 2019 5:28 PM > To: Wang, Jian J > Cc: devel@edk2.groups.io; Ard Biesheuvel ; > Kinney, Michael D ; Gao, Liming > > Subject: Re: [edk2-devel] [edk2-platforms: PATCH] Readme.md: Change way > of cloning edk2 repo >=20 > On Tue, Jul 09, 2019 at 03:21:42PM +0800, Jian J Wang wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1910 > > > > '--recursive' in cloning edk2 repo might cause failure on machine > > behind proxy. It's not actually necessary for edk2. This patch removed > > it from git command. A separate command > > > > $ git submodule update --init > > > > is added to retrieve repo specified via submodule. > > > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Michael D Kinney > > Cc: Liming Gao > > Signed-off-by: Jian J Wang >=20 > Reviewed-by: Leif Lindholm >=20 > Can you push it yourself, or would you like me to do it? >=20 > > --- > > Readme.md | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/Readme.md b/Readme.md > > index e203795d47..63e59f60b4 100644 > > --- a/Readme.md > > +++ b/Readme.md > > @@ -83,7 +83,8 @@ target-specific binutils. These are included with an= y > prepackaged GCC toolchain > > 1. [edk2-non-osi](https://github.com/tianocore/edk2-non-osi) (if > building > > platforms that need it) > > ``` > > - $ git clone https://github.com/tianocore/edk2.git --recursive > > + $ git clone https://github.com/tianocore/edk2.git > > + $ git submodule update --init > > ... > > $ git clone https://github.com/tianocore/edk2-platforms.git > > ... > > -- > > 2.17.1.windows.2 > > >=20 >=20