* [edk2-platforms: PATCH] Readme.md: Change way of cloning edk2 repo @ 2019-07-09 7:21 Wang, Jian J 2019-07-09 9:28 ` Leif Lindholm 0 siblings, 1 reply; 4+ messages in thread From: Wang, Jian J @ 2019-07-09 7:21 UTC (permalink / raw) To: devel; +Cc: Leif Lindholm, Ard Biesheuvel, Michael D Kinney, Liming Gao BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1910 '--recursive' in cloning edk2 repo might cause failure on machine behind proxy. It's not actually necessary for edk2. This patch removed it from git command. A separate command $ git submodule update --init is added to retrieve repo specified via submodule. Cc: Leif Lindholm <leif.lindholm@linaro.org> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Liming Gao <liming.gao@intel.com> Signed-off-by: Jian J Wang <jian.j.wang@intel.com> --- Readme.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Readme.md b/Readme.md index e203795d47..63e59f60b4 100644 --- a/Readme.md +++ b/Readme.md @@ -83,7 +83,8 @@ target-specific binutils. These are included with any prepackaged GCC toolchain 1. [edk2-non-osi](https://github.com/tianocore/edk2-non-osi) (if building platforms that need it) ``` - $ git clone https://github.com/tianocore/edk2.git --recursive + $ git clone https://github.com/tianocore/edk2.git + $ git submodule update --init ... $ git clone https://github.com/tianocore/edk2-platforms.git ... -- 2.17.1.windows.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-platforms: PATCH] Readme.md: Change way of cloning edk2 repo 2019-07-09 7:21 [edk2-platforms: PATCH] Readme.md: Change way of cloning edk2 repo Wang, Jian J @ 2019-07-09 9:28 ` Leif Lindholm 2019-07-09 9:54 ` [edk2-devel] " Wang, Jian J [not found] ` <15AFB486125DAF75.12453@groups.io> 0 siblings, 2 replies; 4+ messages in thread From: Leif Lindholm @ 2019-07-09 9:28 UTC (permalink / raw) To: Jian J Wang; +Cc: devel, Ard Biesheuvel, Michael D Kinney, Liming Gao On Tue, Jul 09, 2019 at 03:21:42PM +0800, Jian J Wang wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1910 > > '--recursive' in cloning edk2 repo might cause failure on machine > behind proxy. It's not actually necessary for edk2. This patch removed > it from git command. A separate command > > $ git submodule update --init > > is added to retrieve repo specified via submodule. > > Cc: Leif Lindholm <leif.lindholm@linaro.org> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Liming Gao <liming.gao@intel.com> > Signed-off-by: Jian J Wang <jian.j.wang@intel.com> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> Can you push it yourself, or would you like me to do it? > --- > Readme.md | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Readme.md b/Readme.md > index e203795d47..63e59f60b4 100644 > --- a/Readme.md > +++ b/Readme.md > @@ -83,7 +83,8 @@ target-specific binutils. These are included with any prepackaged GCC toolchain > 1. [edk2-non-osi](https://github.com/tianocore/edk2-non-osi) (if building > platforms that need it) > ``` > - $ git clone https://github.com/tianocore/edk2.git --recursive > + $ git clone https://github.com/tianocore/edk2.git > + $ git submodule update --init > ... > $ git clone https://github.com/tianocore/edk2-platforms.git > ... > -- > 2.17.1.windows.2 > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [edk2-platforms: PATCH] Readme.md: Change way of cloning edk2 repo 2019-07-09 9:28 ` Leif Lindholm @ 2019-07-09 9:54 ` Wang, Jian J [not found] ` <15AFB486125DAF75.12453@groups.io> 1 sibling, 0 replies; 4+ messages in thread From: Wang, Jian J @ 2019-07-09 9:54 UTC (permalink / raw) To: devel@edk2.groups.io, leif.lindholm@linaro.org Cc: Ard Biesheuvel, Kinney, Michael D, Gao, Liming Leif, I'll try push first (not sure I have write access right). If I can't, please do it for me. Regards, Jian > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Tuesday, July 09, 2019 5:28 PM > To: Wang, Jian J <jian.j.wang@intel.com> > Cc: devel@edk2.groups.io; Ard Biesheuvel <ard.biesheuvel@linaro.org>; > Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming > <liming.gao@intel.com> > Subject: Re: [edk2-devel] [edk2-platforms: PATCH] Readme.md: Change way > of cloning edk2 repo > > On Tue, Jul 09, 2019 at 03:21:42PM +0800, Jian J Wang wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1910 > > > > '--recursive' in cloning edk2 repo might cause failure on machine > > behind proxy. It's not actually necessary for edk2. This patch removed > > it from git command. A separate command > > > > $ git submodule update --init > > > > is added to retrieve repo specified via submodule. > > > > Cc: Leif Lindholm <leif.lindholm@linaro.org> > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > > Cc: Liming Gao <liming.gao@intel.com> > > Signed-off-by: Jian J Wang <jian.j.wang@intel.com> > > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > > Can you push it yourself, or would you like me to do it? > > > --- > > Readme.md | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/Readme.md b/Readme.md > > index e203795d47..63e59f60b4 100644 > > --- a/Readme.md > > +++ b/Readme.md > > @@ -83,7 +83,8 @@ target-specific binutils. These are included with any > prepackaged GCC toolchain > > 1. [edk2-non-osi](https://github.com/tianocore/edk2-non-osi) (if > building > > platforms that need it) > > ``` > > - $ git clone https://github.com/tianocore/edk2.git --recursive > > + $ git clone https://github.com/tianocore/edk2.git > > + $ git submodule update --init > > ... > > $ git clone https://github.com/tianocore/edk2-platforms.git > > ... > > -- > > 2.17.1.windows.2 > > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <15AFB486125DAF75.12453@groups.io>]
* Re: [edk2-devel] [edk2-platforms: PATCH] Readme.md: Change way of cloning edk2 repo [not found] ` <15AFB486125DAF75.12453@groups.io> @ 2019-07-10 1:36 ` Wang, Jian J 0 siblings, 0 replies; 4+ messages in thread From: Wang, Jian J @ 2019-07-10 1:36 UTC (permalink / raw) To: devel@edk2.groups.io, Wang, Jian J, leif.lindholm@linaro.org Cc: Ard Biesheuvel, Kinney, Michael D, Gao, Liming Pushed at 369c177357312c3e66721f1ea6216ce06c90f569 Regards, Jian > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wang, Jian J > Sent: Tuesday, July 09, 2019 5:55 PM > To: devel@edk2.groups.io; leif.lindholm@linaro.org > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney, Michael D > <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com> > Subject: Re: [edk2-devel] [edk2-platforms: PATCH] Readme.md: Change way > of cloning edk2 repo > > Leif, > > I'll try push first (not sure I have write access right). If I can't, please do it > for me. > > Regards, > Jian > > > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Leif Lindholm > > Sent: Tuesday, July 09, 2019 5:28 PM > > To: Wang, Jian J <jian.j.wang@intel.com> > > Cc: devel@edk2.groups.io; Ard Biesheuvel <ard.biesheuvel@linaro.org>; > > Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming > > <liming.gao@intel.com> > > Subject: Re: [edk2-devel] [edk2-platforms: PATCH] Readme.md: Change > way > > of cloning edk2 repo > > > > On Tue, Jul 09, 2019 at 03:21:42PM +0800, Jian J Wang wrote: > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1910 > > > > > > '--recursive' in cloning edk2 repo might cause failure on machine > > > behind proxy. It's not actually necessary for edk2. This patch removed > > > it from git command. A separate command > > > > > > $ git submodule update --init > > > > > > is added to retrieve repo specified via submodule. > > > > > > Cc: Leif Lindholm <leif.lindholm@linaro.org> > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > > > Cc: Liming Gao <liming.gao@intel.com> > > > Signed-off-by: Jian J Wang <jian.j.wang@intel.com> > > > > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > > > > Can you push it yourself, or would you like me to do it? > > > > > --- > > > Readme.md | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/Readme.md b/Readme.md > > > index e203795d47..63e59f60b4 100644 > > > --- a/Readme.md > > > +++ b/Readme.md > > > @@ -83,7 +83,8 @@ target-specific binutils. These are included with > any > > prepackaged GCC toolchain > > > 1. [edk2-non-osi](https://github.com/tianocore/edk2-non-osi) (if > > building > > > platforms that need it) > > > ``` > > > - $ git clone https://github.com/tianocore/edk2.git --recursive > > > + $ git clone https://github.com/tianocore/edk2.git > > > + $ git submodule update --init > > > ... > > > $ git clone https://github.com/tianocore/edk2-platforms.git > > > ... > > > -- > > > 2.17.1.windows.2 > > > > > > > > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-10 1:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-09 7:21 [edk2-platforms: PATCH] Readme.md: Change way of cloning edk2 repo Wang, Jian J
2019-07-09 9:28 ` Leif Lindholm
2019-07-09 9:54 ` [edk2-devel] " Wang, Jian J
[not found] ` <15AFB486125DAF75.12453@groups.io>
2019-07-10 1:36 ` Wang, Jian J
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox