From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: jian.j.wang@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Sun, 21 Jul 2019 22:48:25 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jul 2019 22:48:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,293,1559545200"; d="scan'208";a="159778657" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga007.jf.intel.com with ESMTP; 21 Jul 2019 22:48:24 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 21 Jul 2019 22:48:24 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 21 Jul 2019 22:48:24 -0700 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.162]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.174]) with mapi id 14.03.0439.000; Mon, 22 Jul 2019 13:48:22 +0800 From: "Wang, Jian J" To: Laszlo Ersek , edk2-devel-groups-io Subject: Re: [PATCH 3/4] CryptoPkg/BaseCryptLib: list module-internal header files in INF [Sources] Thread-Topic: [PATCH 3/4] CryptoPkg/BaseCryptLib: list module-internal header files in INF [Sources] Thread-Index: AQHVPlEe6abAJWTfAkua20/sIwlAkqbWJXDA Date: Mon, 22 Jul 2019 05:48:22 +0000 Message-ID: References: <20190719164319.9070-1-lersek@redhat.com> <20190719164319.9070-4-lersek@redhat.com> In-Reply-To: <20190719164319.9070-4-lersek@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTI4MDYyNDQtYWZiNy00NmFiLWE4NzgtM2ZhNzcxNWExMTIxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVFRjeHQ4NTBxbWpsaDd6TnFXZFZKbHVcL2NyaEdBQU9VRWZVenBlZVRcL3lSRGRZVDlENEJlNkEwZ1k1UUMxc0wrIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jian.j.wang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jian J Wang > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Saturday, July 20, 2019 12:43 AM > To: edk2-devel-groups-io > Cc: Wang, Jian J ; Ye, Ting > Subject: [PATCH 3/4] CryptoPkg/BaseCryptLib: list module-internal header > files in INF [Sources] >=20 > The BaseTools build feature introduced for TianoCore#1804 / in commit > 1fa6699e6cd4 ("BaseTools: Add a checking for Sources section in INF file"= , > 2019-06-10) logs some (non-fatal) warnings about unlisted internal header > files. List those files explicitly. >=20 > Note: header files are added in lexicographical order only if the > underlying INF file already keeps the [Sources] and [LibraryClasses] > sections in lexicographical order. Otherwise, header files are added in > rough "logical" order. >=20 > Cc: Jian Wang > Cc: Ting Ye > Signed-off-by: Laszlo Ersek > --- > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 1 + > CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 1 + > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 1 + > 3 files changed, 3 insertions(+) >=20 > diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > index 4c4353747622..99dbad23ed5d 100644 > --- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > @@ -34,6 +34,7 @@ [Defines] > # >=20 > [Sources] > + InternalCryptLib.h > Hash/CryptMd4Null.c > Hash/CryptMd5.c > Hash/CryptSha1.c > diff --git a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > index a59079d99e05..0e58d2b5b0ea 100644 > --- a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > @@ -33,6 +33,7 @@ [Defines] > # >=20 > [Sources] > + InternalCryptLib.h > Hash/CryptMd4Null.c > Hash/CryptMd5.c > Hash/CryptSha1.c > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > index 3fd7d65abfca..c79f2bf4c6c0 100644 > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > @@ -33,6 +33,7 @@ [Defines] > # >=20 > [Sources] > + InternalCryptLib.h > Hash/CryptMd4Null.c > Hash/CryptMd5.c > Hash/CryptSha1.c > -- > 2.19.1.3.g30247aa5d201 >=20