From: "Wang, Jian J" <jian.j.wang@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Yao, Jiewen" <jiewen.yao@intel.com>
Cc: "Zhang, Chao B" <chao.b.zhang@intel.com>
Subject: Re: [edk2-devel] [PATCH 0/3] Add Laml/Lasa to TPM2 acpi table
Date: Mon, 30 Sep 2019 05:23:23 +0000 [thread overview]
Message-ID: <D827630B58408649ACB04F44C51000362598A159@SHSMSX107.ccr.corp.intel.com> (raw)
In-Reply-To: <20190929061558.22512-1-jiewen.yao@intel.com>
Thanks for implementing this feature. Just one minor comment. The BZ link should also
be mentioned in patch1-3, not just cover letter. With this addressed, for the whole series,
Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, Jiewen
> Sent: Sunday, September 29, 2019 2:16 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Zhang, Chao B
> <chao.b.zhang@intel.com>
> Subject: [edk2-devel] [PATCH 0/3] Add Laml/Lasa to TPM2 acpi table
>
> Bugzilla https://bugzilla.tianocore.org/show_bug.cgi?id=978
>
> This patch series adds Laml/Lasa to TPM2 ACPI table.
>
> This is defined by TPM2 ACPI table Version 1.2, Revision 8.
> It only impacts the TPM2 ACPI table version 4 or above.
> The default TPM2 ACPI table version is still 3 to keep maximum compatibility.
>
> The new fields are only for TCG2 log format, but not TCG1.2 log format.
>
> This new fields are optional and won't be consumed by OS/Loader, because
> the OS/loader still uses TCG2_PROTOCOL to get the event log.
>
> These fields are important for OS utility, because the OS utility can
> not use TCG2_PROTOCOL.
>
> Test:
> Use default TPM2 version 3. No ALMA/ALSA shown in TPM2 table.
> Use TPM2 version 4. The DXE driver reports ALMA/ALSA PCD and the SMM driver
> installs ALMA/ALSA in TPM2 table.
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
>
> Jiewen Yao (3):
> MdePkg/Include: correct Lasa in Tpm2Acpi.
> SecurityPkg/dsc: Add PCD for Laml, Lasa for TPM2.
> SecurityPkg/Tcg2: Add Support Laml, Lasa for TPM2 ACPI.
>
> MdePkg/Include/IndustryStandard/Tpm2Acpi.h | 2 +-
> SecurityPkg/SecurityPkg.dec | 8 ++++++
> SecurityPkg/SecurityPkg.uni | 9 ++++++
> SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 32 ++++++++++++++++++----
> SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf | 3 ++
> SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 32 ++++++++++++++++++++--
> SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf | 2 ++
> 7 files changed, 78 insertions(+), 10 deletions(-)
>
> --
> 2.19.2.windows.1
>
>
>
next prev parent reply other threads:[~2019-09-30 5:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-29 6:15 [PATCH 0/3] Add Laml/Lasa to TPM2 acpi table Yao, Jiewen
2019-09-29 6:15 ` [PATCH 1/3] MdePkg/Include: correct Lasa in Tpm2Acpi Yao, Jiewen
2019-09-30 5:36 ` Liming Gao
2019-09-29 6:15 ` [PATCH 2/3] SecurityPkg/dsc: Add PCD for Laml, Lasa for TPM2 Yao, Jiewen
2019-09-29 6:15 ` [PATCH 3/3] SecurityPkg/Tcg2: Add Support Laml, Lasa for TPM2 ACPI Yao, Jiewen
2019-09-30 5:23 ` Wang, Jian J [this message]
2019-09-30 5:25 ` [edk2-devel] [PATCH 0/3] Add Laml/Lasa to TPM2 acpi table Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D827630B58408649ACB04F44C51000362598A159@SHSMSX107.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox