From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: jian.j.wang@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Sun, 29 Sep 2019 22:23:26 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Sep 2019 22:23:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,565,1559545200"; d="scan'208";a="390719936" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 29 Sep 2019 22:23:25 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 29 Sep 2019 22:23:25 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 29 Sep 2019 22:23:25 -0700 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.33]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.112]) with mapi id 14.03.0439.000; Mon, 30 Sep 2019 13:23:23 +0800 From: "Wang, Jian J" To: "devel@edk2.groups.io" , "Yao, Jiewen" CC: "Zhang, Chao B" Subject: Re: [edk2-devel] [PATCH 0/3] Add Laml/Lasa to TPM2 acpi table Thread-Topic: [edk2-devel] [PATCH 0/3] Add Laml/Lasa to TPM2 acpi table Thread-Index: AQHVdo1uZBTihEb34keYwCPYixMtoqdDr07A Date: Mon, 30 Sep 2019 05:23:23 +0000 Message-ID: References: <20190929061558.22512-1-jiewen.yao@intel.com> In-Reply-To: <20190929061558.22512-1-jiewen.yao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTIxOGVlOGItNDAyOS00NDA0LWE3NmUtYWY1ODRlNzk3YmJjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUnZaRDluS2hxVDhCXC8zeWhMcFloTWtKeDk3S3ZDTTJyOFFraTM5am1KelZ3YnJYN0E2aTI5b1pRN2NDbWpsOVEifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jian.j.wang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for implementing this feature. Just one minor comment. The BZ link s= hould also be mentioned in patch1-3, not just cover letter. With this addressed, for = the whole series, Reviewed-by: Jian J Wang > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Yao, Jiew= en > Sent: Sunday, September 29, 2019 2:16 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Zhang, Chao B > > Subject: [edk2-devel] [PATCH 0/3] Add Laml/Lasa to TPM2 acpi table >=20 > Bugzilla https://bugzilla.tianocore.org/show_bug.cgi?id=3D978 >=20 > This patch series adds Laml/Lasa to TPM2 ACPI table. >=20 > This is defined by TPM2 ACPI table Version 1.2, Revision 8. > It only impacts the TPM2 ACPI table version 4 or above. > The default TPM2 ACPI table version is still 3 to keep maximum compatibi= lity. >=20 > The new fields are only for TCG2 log format, but not TCG1.2 log format. >=20 > This new fields are optional and won't be consumed by OS/Loader, because > the OS/loader still uses TCG2_PROTOCOL to get the event log. >=20 > These fields are important for OS utility, because the OS utility can > not use TCG2_PROTOCOL. >=20 > Test: > Use default TPM2 version 3. No ALMA/ALSA shown in TPM2 table. > Use TPM2 version 4. The DXE driver reports ALMA/ALSA PCD and the SMM dri= ver > installs ALMA/ALSA in TPM2 table. >=20 > Cc: Jian J Wang > Cc: Chao Zhang > Signed-off-by: Jiewen Yao >=20 > Jiewen Yao (3): > MdePkg/Include: correct Lasa in Tpm2Acpi. > SecurityPkg/dsc: Add PCD for Laml, Lasa for TPM2. > SecurityPkg/Tcg2: Add Support Laml, Lasa for TPM2 ACPI. >=20 > MdePkg/Include/IndustryStandard/Tpm2Acpi.h | 2 +- > SecurityPkg/SecurityPkg.dec | 8 ++++++ > SecurityPkg/SecurityPkg.uni | 9 ++++++ > SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 32 ++++++++++++++++++---- > SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf | 3 ++ > SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 32 ++++++++++++++++++++-- > SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf | 2 ++ > 7 files changed, 78 insertions(+), 10 deletions(-) >=20 > -- > 2.19.2.windows.1 >=20 >=20 >=20