Re: [Patch v4 08/22] CryptoPkg: Add YAML file for CI builds

["Wang, Jian J" <jian.j.wang@intel.com>]

Hi Mike,


> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Thursday, November 07, 2019 9:14 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [Patch v4 08/22] CryptoPkg: Add YAML file for CI builds
> 
> Add YAML file to the package directory with the
> configuration of the checks to perform during a
> CI build.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Signed-off-by: Kinney <michael.d.kinney@intel.com>
> ---
>  CryptoPkg/CryptoPkg.ci.yaml | 48
> +++++++++++++++++++++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100644 CryptoPkg/CryptoPkg.ci.yaml
> 
> diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml
> new file mode 100644
> index 0000000000..a20ac79d0e
> --- /dev/null
> +++ b/CryptoPkg/CryptoPkg.ci.yaml
> @@ -0,0 +1,48 @@
> +##
> +# CI configuration for CryptoPkg
> +#
> +# Copyright (c) Microsoft Corporation
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +##
> +{
> +    "CompilerPlugin": {
> +        "DscPath": "CryptoPkg.dsc"
> +    },
> +    "CharEncodingCheck": {
> +        "IgnoreFiles": []
> +    },
> +    "DependencyCheck": {
> +        "AcceptableDependencies": [
> +            "MdePkg/MdePkg.dec",
> +            "MdeModulePkg/MdeModulePkg.dec",
> +            "CryptoPkg/CryptoPkg.dec",
> +            #"SecurityPkg/SecurityPkg.dec"

It'd be better to remove above line instead of commenting out. I don't
think CryptoPkg will depend on SecurityPkg anyway.

With it addressed,

Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

Regards,
Jian
> +        ],
> +        # For host based unit tests
> +        "AcceptableDependencies-HOST_APPLICATION":[],
> +        # For UEFI shell based apps
> +        "AcceptableDependencies-UEFI_APPLICATION":[],
> +        "IgnoreInf": []
> +    },
> +    "DscCompleteCheck": {
> +        "DscPath": "CryptoPkg.dsc",
> +        "IgnoreInf": []
> +    },
> +    "GuidCheck": {
> +        "IgnoreGuidName": [],
> +        "IgnoreGuidValue": [],
> +        "IgnoreFoldersAndFiles": []
> +    },
> +    "LibraryClassCheck": {
> +        "IgnoreHeaderFile": []
> +    },
> +
> +    ## options defined ci/Plugin/SpellCheck
> +    "SpellCheck": {
> +        "skip": True,
> +        "IgnoreFiles": [],           # use gitignore syntax to ignore errors in matching
> files
> +        "ExtendWords": [],           # words to extend to the dictionary for this
> package
> +        "IgnoreStandardPaths": [],   # Standard Plugin defined paths that should be
> ignore
> +        "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards
> supported)
> +    }
> +}
> --
> 2.21.0.windows.1