From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.7750.1573538478466225908 for ; Mon, 11 Nov 2019 22:01:18 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: jian.j.wang@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Nov 2019 22:01:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,295,1569308400"; d="scan'208";a="215928140" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 11 Nov 2019 22:01:17 -0800 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 Nov 2019 22:01:17 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 Nov 2019 22:01:16 -0800 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.63]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.60]) with mapi id 14.03.0439.000; Tue, 12 Nov 2019 14:01:14 +0800 From: "Wang, Jian J" To: "devel@edk2.groups.io" , "Wang, Jian J" CC: "Yao, Jiewen" , "Zhang, Chao B" , "Kinney, Michael D" , "Gao, Liming" , Laszlo Ersek , "Ard Biesheuvel" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH] SecurityPkg/RngLibNull: add null version of RngLib Thread-Topic: [edk2-devel] [PATCH] SecurityPkg/RngLibNull: add null version of RngLib Thread-Index: AQHVmR3bhbJS2oegmEazrfKog4+2vaeHCZqQ Date: Tue, 12 Nov 2019 06:01:13 +0000 Message-ID: References: <15D6549BEEE2C5E9.20285@groups.io> In-Reply-To: <15D6549BEEE2C5E9.20285@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2E4NzcyYjEtNmUyYy00NDQ5LTk1NDUtOGJiODMxMmVkNzg3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiekdxRTVWZ0lXMFo4aHNHajJDZE1wVDBwN2pBV0RFa25sUTQzR0RXa3QwK0R4dzlnV0MzXC95MEdcL3N5MlZsbGt2In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jian.j.wang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Required by BZ1871, this null version of RngLib needs to be pushed first to= solve build problem once we removed the dependency of TimerLib from OpensslLib. I have to send this patch separately from other patches for bz1871 because= there will be patches cross repo. Regards, Jian > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Wang, Jia= n > J > Sent: Tuesday, November 12, 2019 1:56 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Zhang, Chao B > ; Kinney, Michael D = ; > Gao, Liming ; Laszlo Ersek ; Ar= d > Biesheuvel ; Ni, Ray > Subject: [edk2-devel] [PATCH] SecurityPkg/RngLibNull: add null version o= f RngLib >=20 > This is null version of RngLib which is used for those platforms or > components which don't need random number. >=20 > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1871 > Cc: Jiewen Yao > Cc: Chao Zhang > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Ray Ni > Signed-off-by: Jian J Wang > --- > .../RngLibNull/RngLibNull.c | 95 +++++++++++++++++++ > .../RngLibNull/RngLibNull.inf | 31 ++++++ > .../RngLibNull/RngLibNull.uni | 14 +++ > 3 files changed, 140 insertions(+) > create mode 100644 > SecurityPkg/RandomNumberGenerator/RngLibNull/RngLibNull.c > create mode 100644 > SecurityPkg/RandomNumberGenerator/RngLibNull/RngLibNull.inf > create mode 100644 > SecurityPkg/RandomNumberGenerator/RngLibNull/RngLibNull.uni >=20 > diff --git a/SecurityPkg/RandomNumberGenerator/RngLibNull/RngLibNull.c > b/SecurityPkg/RandomNumberGenerator/RngLibNull/RngLibNull.c > new file mode 100644 > index 0000000000..13677abc84 > --- /dev/null > +++ b/SecurityPkg/RandomNumberGenerator/RngLibNull/RngLibNull.c > @@ -0,0 +1,95 @@ > +/** @file > + Null version of Random number generator services. > + > +Copyright (c) 2019, Intel Corporation. All rights reserved.
> +SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#include > +#include > +#include > + > +/** > + Generates a 16-bit random number. > + > + if Rand is NULL, then ASSERT(). > + > + @param[out] Rand Buffer pointer to store the 16-bit random value. > + > + @retval TRUE Random number generated successfully. > + @retval FALSE Failed to generate the random number. > + > +**/ > +BOOLEAN > +EFIAPI > +GetRandomNumber16 ( > + OUT UINT16 *Rand > + ) > +{ > + ASSERT (FALSE); > + return FALSE; > +} > + > +/** > + Generates a 32-bit random number. > + > + if Rand is NULL, then ASSERT(). > + > + @param[out] Rand Buffer pointer to store the 32-bit random value. > + > + @retval TRUE Random number generated successfully. > + @retval FALSE Failed to generate the random number. > + > +**/ > +BOOLEAN > +EFIAPI > +GetRandomNumber32 ( > + OUT UINT32 *Rand > + ) > +{ > + ASSERT (FALSE); > + return FALSE; > +} > + > +/** > + Generates a 64-bit random number. > + > + if Rand is NULL, then ASSERT(). > + > + @param[out] Rand Buffer pointer to store the 64-bit random value. > + > + @retval TRUE Random number generated successfully. > + @retval FALSE Failed to generate the random number. > + > +**/ > +BOOLEAN > +EFIAPI > +GetRandomNumber64 ( > + OUT UINT64 *Rand > + ) > +{ > + ASSERT (FALSE); > + return FALSE; > +} > + > +/** > + Generates a 128-bit random number. > + > + if Rand is NULL, then ASSERT(). > + > + @param[out] Rand Buffer pointer to store the 128-bit random value= . > + > + @retval TRUE Random number generated successfully. > + @retval FALSE Failed to generate the random number. > + > +**/ > +BOOLEAN > +EFIAPI > +GetRandomNumber128 ( > + OUT UINT64 *Rand > + ) > +{ > + ASSERT (FALSE); > + return FALSE; > +} > diff --git a/SecurityPkg/RandomNumberGenerator/RngLibNull/RngLibNull.inf > b/SecurityPkg/RandomNumberGenerator/RngLibNull/RngLibNull.inf > new file mode 100644 > index 0000000000..f6494cdb82 > --- /dev/null > +++ b/SecurityPkg/RandomNumberGenerator/RngLibNull/RngLibNull.inf > @@ -0,0 +1,31 @@ > +## @file > +# Null instance of RNG (Random Number Generator) Library. > +# > +# Copyright (c) 2019, Intel Corporation. All rights reserved.
> +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +[Defines] > + INF_VERSION =3D 0x00010005 > + BASE_NAME =3D RngLibNull > + MODULE_UNI_FILE =3D RngLibNull.uni > + FILE_GUID =3D CD8991F8-2061-4084-8C9E-9C6F352DC5= 8D > + MODULE_TYPE =3D BASE > + VERSION_STRING =3D 1.0 > + LIBRARY_CLASS =3D RngLib > + > +# > +# VALID_ARCHITECTURES =3D IA32 X64 ARM AARCH64 > +# > + > +[Sources] > + RngLibNull.c > + > +[Packages] > + MdePkg/MdePkg.dec > + > +[LibraryClasses] > + BaseLib > + DebugLib > diff --git a/SecurityPkg/RandomNumberGenerator/RngLibNull/RngLibNull.uni > b/SecurityPkg/RandomNumberGenerator/RngLibNull/RngLibNull.uni > new file mode 100644 > index 0000000000..40b2ec3fe1 > --- /dev/null > +++ b/SecurityPkg/RandomNumberGenerator/RngLibNull/RngLibNull.uni > @@ -0,0 +1,14 @@ > +// /** @file > +// Null Instance of RNG (Random Number Generator) Library. > +// > +// Copyright (c) 2019, Intel Corporation. All rights reserved.
> +// > +// SPDX-License-Identifier: BSD-2-Clause-Patent > +// > +// **/ > + > + > +#string STR_MODULE_ABSTRACT #language en-US "Null Instance = of > RNG Library" > + > +#string STR_MODULE_DESCRIPTION #language en-US "Caution: This = is a > null version of RNG library and SHOULD NOT be used on any product ever." > + > -- > 2.17.1.windows.2 >=20 >=20 >=20