From: "Wang, Jian J" <jian.j.wang@intel.com>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Ni, Ray" <ray.ni@intel.com>,
"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH] Maintainers.txt: add file filter to let GetMaintainer.py work properly
Date: Tue, 12 Nov 2019 14:39:35 +0000 [thread overview]
Message-ID: <D827630B58408649ACB04F44C5100036259ADAA7@SHSMSX107.ccr.corp.intel.com> (raw)
In-Reply-To: <20191112100150.GA7323@bivouac.eciton.net>
Hi Leif,
Sorry I didn't notice there's already patch out there. I don't work on edk2-platforms
very often. I forgot to setup the git environment for edk2-platforms. Anyway, let's
drop this patch.
Regards,
Jian
> -----Original Message-----
> From: Leif Lindholm <leif.lindholm@linaro.org>
> Sent: Tuesday, November 12, 2019 6:02 PM
> To: Wang, Jian J <jian.j.wang@intel.com>
> Cc: devel@edk2.groups.io; Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney,
> Michael D <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao,
> Liming <liming.gao@intel.com>
> Subject: Re: [PATCH] Maintainers.txt: add file filter to let GetMaintainer.py work
> properly
>
> Hi Jian,
>
> The subject line does not indicate that this refers to the
> edk2-platorms repository. Have you executed the SetupGit.py script in
> your tree?
>
> Other than that, this is sort of a duplicate of
> https://edk2.groups.io/g/devel/topic/34462371
> which I sent out over a month ago (before I went out traveling for 2
> weeks and forgot about it).
>
> I will send out a v2 and cc you on it.
>
> /
> Leif
>
> On Tue, Nov 12, 2019 at 03:41:14PM +0800, Jian J Wang wrote:
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
> > ---
> > Maintainers.txt | 46 +++++++++++++++++++++++++++++++++++++++++++++-
> > 1 file changed, 45 insertions(+), 1 deletion(-)
> >
> > diff --git a/Maintainers.txt b/Maintainers.txt
> > index 9599024e20..a4c39000c6 100644
> > --- a/Maintainers.txt
> > +++ b/Maintainers.txt
> > @@ -11,7 +11,8 @@ Descriptions of section entries:
> >
> > L: Mailing list that is relevant to this area (default is edk2-devel)
> > Patches and questions should be sent to the email list.
> > - M: Cc address for patches and questions (ie, the package maintainer)
> > + M: Package Maintainer: Cc address for patches and questions. Responsible
> > + for reviewing and pushing package changes to source control.
> > R: Package Reviewer: Cc address for patches and questions. Reviewers help
> > maintainers review code, but don't have push access. A designated Package
> > Reviewer is reasonably familiar with the Package (or some modules
> > @@ -29,6 +30,22 @@ Descriptions of section entries:
> > Obsolete: Old code. Something tagged obsolete generally means
> > it has been replaced by a better system and you
> > should be using that.
> > + F: Files and directories with wildcard patterns.
> > + A trailing slash includes all files and subdirectory files.
> > + F: MdeModulePkg/ all files in and below MdeModulePkg
> > + F: MdeModulePkg/* all files in MdeModulePkg, but not below
> > + F: */Pci/* all files in a directory called Pci, at any depth in
> > + the hierarchy, but not below
> > + One pattern per line. Multiple F: lines per section acceptable.
> > + X: Files and directories that are NOT maintained, same rules as F:
> > + Files exclusions are tested after file matches.
> > + Can be useful for excluding a specific subdirectory, for instance:
> > + F: NetworkPkg/
> > + X: NetworkPkg/Ip6Dxe/
> > + matches all files in and below NetworkPkg excluding NetworkPkg/Ip6Dxe/
> > + Filenames not caught by any F: rule get matched as being located in the top-
> > + level directory. (Internally, the script looks for a match called '<default>',
> > + so please don't add a file called that in the top-level directory.)
> >
> > EDK II
> > ------
> > @@ -44,115 +61,142 @@ EDK II Packages:
> > ----------------
> >
> > Drivers/OptionRomPkg
> > +F: Drivers/OptionRomPkg/
> > W: https://github.com/tianocore/tianocore.github.io/wiki/OptionRomPkg
> > M: Ray Ni <ray.ni@intel.com>
> >
> > Drivers/DisplayLink
> > +F: Drivers/DisplayLink/
> > M: Leif Lindholm <leif.lindholm@linaro.org>
> > M: Ard Bieshuevel <ard.bieshuevel@linaro.org>
> > R: Andy Hayes <andy.hayes@displaylink.com>
> >
> > Platform
> > +F: Platform/
> > M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > M: Leif Lindholm <leif.lindholm@linaro.org>
> > M: Michael D Kinney <michael.d.kinney@intel.com>
> >
> > Platform/Intel/QuarkPlatformPkg
> > +F: Platform/Intel/QuarkPlatformPkg/
> > M: Michael D Kinney <michael.d.kinney@intel.com>
> > M: Kelly Steele <kelly.steele@intel.com>
> >
> > Platform/Intel/Vlv2TbltDevicePkg
> > +F: Platform/Intel/Vlv2TbltDevicePkg/
> > M: Zailiang Sun <zailiang.sun@intel.com>
> > M: Yi Qian <yi.qian@intel.com>
> >
> > Platform/Intel/AdvancedFeaturePkg
> > +F: Platform/Intel/AdvancedFeaturePkg/
> > M: Michael Kubacki <michael.a.kubacki@intel.com>
> > M: Sai Chaganty <rangasai.v.chaganty@intel.com>
> > R: Liming Gao <liming.gao@intel.com>
> >
> > Platform/Intel/BoardModulePkg
> > +F: Platform/Intel/BoardModulePkg/
> > M: Eric Dong <eric.dong@intel.com>
> > R: Liming Gao <liming.gao@intel.com>
> >
> > Platform/Intel/DebugFeaturePkg
> > +F: Platform/Intel/DebugFeaturePkg/
> > M: Eric Dong <eric.dong@intel.com>
> > R: Liming Gao <liming.gao@intel.com>
> >
> > Platform/Intel/UserInterfaceFeaturePkg
> > +F: Platform/Intel/UserInterfaceFeaturePkg/
> > M: Dandan Bi <dandan.bi@intel.com>
> > R: Liming Gao <liming.gao@intel.com>
> >
> > Platform/Intel/KabylakeOpenBoardPkg
> > +F: Platform/Intel/KabylakeOpenBoardPkg/
> > M: Chasel Chiu <chasel.chiu@intel.com>
> > M: Michael Kubacki <michael.a.kubacki@intel.com>
> > M: Nate DeSimone <nathaniel.l.desimone@intel.com>
> >
> > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3
> > +F: Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/
> > R: Jeremy Soller <jeremy@system76.com>
> >
> > Platform/Intel/MinPlatformPkg
> > +F: Platform/Intel/MinPlatformPkg/
> > M: Michael Kubacki <michael.a.kubacki@intel.com>
> > M: Chasel Chiu <chasel.chiu@intel.com>
> > M: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > R: Liming Gao <liming.gao@intel.com>
> >
> > Platform/Intel/WhiskeylakeOpenBoardPkg
> > +F: Platform/Intel/WhiskeylakeOpenBoardPkg/
> > M: Chasel Chiu <chasel.chiu@intel.com>
> > M: Michael Kubacki <michael.a.kubacki@intel.com>
> > M: Nate DeSimone <nathaniel.l.desimone@intel.com>
> >
> > Platform/Intel/SimicsOpenBoardPkg
> > +F: Platform/Intel/SimicsOpenBoardPkg/
> > M: Wei David Y <david.y.wei@intel.com>
> > M: Agyeman Prince <prince.agyeman@intel.com>
> >
> > Platform/Intel/Tools
> > +F: Platform/Intel/Tools/
> > M: Bob Feng <bob.c.feng@intel.com>
> > M: Liming Gao <liming.gao@intel.com>
> >
> > Platform/Marvell
> > +F: Platform/Marvell/
> > R: Marcin Wojtas <mw@semihalf.com>
> >
> > Platform/SolidRun/Armada80x0McBin
> > +F: Platform/SolidRun/Armada80x0McBin/
> > R: Marcin Wojtas <mw@semihalf.com>
> >
> > Silicon
> > +F: Silicon/
> > M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > M: Leif Lindholm <leif.lindholm@linaro.org>
> > M: Michael D Kinney <michael.d.kinney@intel.com>
> >
> > Silicon/Intel/IntelSiliconPkg
> > +F: Silicon/Intel/IntelSiliconPkg/
> > M: Ray Ni <ray.ni@intel.com>
> > M: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> >
> > Silicon/Intel/QuarkSocPkg
> > +F: Silicon/Intel/QuarkSocPkg/
> > M: Michael D Kinney <michael.d.kinney@intel.com>
> > M: Kelly Steele <kelly.steele@intel.com>
> >
> > Silicon/Intel/Vlv2DeviceRefCodePkg
> > +F: Silicon/Intel/Vlv2DeviceRefCodePkg/
> > M: Zailiang Sun <zailiang.sun@intel.com>
> > M: Yi Qian <yi.qian@intel.com>
> >
> > Silicon/Intel/CoffeelakeSiliconPkg
> > +F: Silicon/Intel/CoffeelakeSiliconPkg/
> > M: Chasel Chiu <chasel.chiu@intel.com>
> > M: Michael Kubacki <michael.a.kubacki@intel.com>
> > M: Sai Chaganty <rangasai.v.chaganty@intel.com>
> >
> > Silicon/Intel/KabylakeSiliconPkg
> > +F: Silicon/Intel/KabylakeSiliconPkg/
> > M: Chasel Chiu <chasel.chiu@intel.com>
> > M: Michael Kubacki <michael.a.kubacki@intel.com>
> > M: Sai Chaganty <rangasai.v.chaganty@intel.com>
> >
> > Silicon/Intel/SimicsX58SktPkg
> > +F: Silicon/Intel/SimicsX58SktPkg/
> > M: Wei David Y <david.y.wei@intel.com>
> > M: Agyeman Prince <prince.agyeman@intel.com>
> >
> > Silicon/Intel/SimicsIch10Pkg
> > +F: Silicon/Intel/SimicsIch10Pkg/
> > M: Wei David Y <david.y.wei@intel.com>
> > M: Agyeman Prince <prince.agyeman@intel.com>
> >
> > Silicon/Intel/Tools
> > +F: Silicon/Intel/Tools/
> > M: Bob Feng <bob.c.feng@intel.com>
> > M: Liming Gao <liming.gao@intel.com>
> >
> > Silicon/Marvell
> > +F: Silicon/Marvell/
> > R: Marcin Wojtas <mw@semihalf.com>
> > --
> > 2.17.1.windows.2
> >
prev parent reply other threads:[~2019-11-12 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 7:41 [PATCH] Maintainers.txt: add file filter to let GetMaintainer.py work properly Wang, Jian J
2019-11-12 10:01 ` Leif Lindholm
2019-11-12 14:39 ` Wang, Jian J [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D827630B58408649ACB04F44C5100036259ADAA7@SHSMSX107.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox