From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.4750.1573741617037451047 for ; Thu, 14 Nov 2019 06:26:57 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: jian.j.wang@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Nov 2019 06:26:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,304,1569308400"; d="scan'208";a="207803258" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 14 Nov 2019 06:26:56 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 14 Nov 2019 06:26:55 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 14 Nov 2019 06:26:55 -0800 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.63]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.213]) with mapi id 14.03.0439.000; Thu, 14 Nov 2019 22:26:53 +0800 From: "Wang, Jian J" To: "devel@edk2.groups.io" , "lersek@redhat.com" CC: Leif Lindholm , Ard Biesheuvel Subject: Re: [edk2-devel] [PATCH 09/11] ArmVirtPkg/ArmVirt.dsc.inc: specify RngLib instances in dsc files Thread-Topic: [edk2-devel] [PATCH 09/11] ArmVirtPkg/ArmVirt.dsc.inc: specify RngLib instances in dsc files Thread-Index: AQHVmtdw66XDeiwBt0WMs/CxjXGOW6eKuSiQ Date: Thu, 14 Nov 2019 14:26:53 +0000 Message-ID: References: <20191114021743.3876-1-jian.j.wang@intel.com> <20191114021743.3876-10-jian.j.wang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmM0MjQyN2UtMjA4ZS00Zjg4LThkYjctYThmNTExNDFiZDY1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUnB0K1Q0Vzg3MGpYUXNVcU4xZDVlenhmOVZ4TGhtdmgwUVl0VVB2RmpiVkdDd1FCZzRFaXJENGZCXC9WT3hMZWkifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jian.j.wang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Laszlo, > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Laszlo Er= sek > Sent: Thursday, November 14, 2019 6:37 PM > To: devel@edk2.groups.io; Wang, Jian J > Cc: Leif Lindholm ; Ard Biesheuvel > > Subject: Re: [edk2-devel] [PATCH 09/11] ArmVirtPkg/ArmVirt.dsc.inc: spec= ify > RngLib instances in dsc files >=20 > On 11/14/19 03:17, Wang, Jian J wrote: > > Per BZ1871, OpensslLib will depend on RngLib instead of TimerLib. Upda= te > > ArmVirt.dsc.inc file to accommodate the coming changes. It's supposed > > that only TlsDxe needs random number. The RngDxeLib is added for it. F= or > > all other drivers, RngLibNull is used by default. > > > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1871 > > Cc: Leif Lindholm > > Cc: Laszlo Ersek > > Cc: Ard Biesheuvel > > Signed-off-by: Jian J Wang > > --- > > ArmVirtPkg/ArmVirt.dsc.inc | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > > index 10037c938e..10e0890699 100644 > > --- a/ArmVirtPkg/ArmVirt.dsc.inc > > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > > @@ -156,8 +156,10 @@ > > IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > > !if $(NETWORK_TLS_ENABLE) =3D=3D TRUE > > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > > + > RngLib|SecurityPkg/RandomNumberGenerator/DxeRngLibRngProtocol/DxeRng > LibRngProtocol.inf > > !else > > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > > + RngLib|MdePkg/Library/BaseRngLibNull/BaseRngLibNull.inf > > !endif > > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > > > > >=20 > (1) This is not right: the non-Null lib instance should be linked into > TlsDxe only, like in the OvmfPkg patch. >=20 > Please locate TlsAuthConfigDxe in both "ArmVirtQemu.dsc" and > "ArmVirtQemuKernel.dsc", and implement the same approach as in OvmfPkg > near "TlsAuthConfigDxe". >=20 Got it. I'll update them all. > (2) See other comments in my OvmfPkg patch review. >=20 Thanks, Jian > Thanks > Laszlo >=20 >=20 >=20