From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.6339.1574089873250556251 for ; Mon, 18 Nov 2019 07:11:13 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: jian.j.wang@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Nov 2019 07:11:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,320,1569308400"; d="scan'208";a="356807580" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 18 Nov 2019 07:11:12 -0800 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 18 Nov 2019 07:11:11 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 18 Nov 2019 07:11:11 -0800 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.63]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.213]) with mapi id 14.03.0439.000; Mon, 18 Nov 2019 23:11:09 +0800 From: "Wang, Jian J" To: "devel@edk2.groups.io" , "Kubacki, Michael A" CC: "Bi, Dandan" , "Gao, Liming" , "Wu, Hao A" Subject: Re: [edk2-devel] [PATCH V1 1/1] MdeModulePkg PeiCore: Improve PeiInstallPeiMemory() description Thread-Topic: [edk2-devel] [PATCH V1 1/1] MdeModulePkg PeiCore: Improve PeiInstallPeiMemory() description Thread-Index: AQHVneDCqKXTzZv2UE2K5TuCm4CouqeRCP+A Date: Mon, 18 Nov 2019 15:11:08 +0000 Message-ID: References: <20191118072103.2436-1-michael.a.kubacki@intel.com> In-Reply-To: <20191118072103.2436-1-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjk4MjJmNmYtYTQ0Yi00NTQ3LTkzOTgtNzZjNDA2YzM3OGY4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicmtnc0E2SGtseXZ0eEdqZmNkNFNsOUF1WUt0UUxjTVQxOVRlMzJpU2p4SXBnZGtEMlU1UlwvMGNoU3JZMXJtTE4ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jian.j.wang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jian J Wang Regards, Jian > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Kubacki, > Michael A > Sent: Monday, November 18, 2019 3:21 PM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming = ; > Wang, Jian J ; Wu, Hao A > Subject: [edk2-devel] [PATCH V1 1/1] MdeModulePkg PeiCore: Improve > PeiInstallPeiMemory() description >=20 > Updates the function description for PeiInstallPeiMemory () to be > more helpful. The description is based on that given in the PI > Specification Version 1.7. >=20 > Cc: Dandan Bi > Cc: Liming Gao > Cc: Jian J Wang > Cc: Hao A Wu > Signed-off-by: Michael Kubacki > --- > MdeModulePkg/Core/Pei/PeiMain.h | 23 ++++++++++++++---- > MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 25 +++++++++++++----- > -- > 2 files changed, 35 insertions(+), 13 deletions(-) >=20 > diff --git a/MdeModulePkg/Core/Pei/PeiMain.h > b/MdeModulePkg/Core/Pei/PeiMain.h > index f2aa97c664..14dfb20d05 100644 > --- a/MdeModulePkg/Core/Pei/PeiMain.h > +++ b/MdeModulePkg/Core/Pei/PeiMain.h > @@ -898,13 +898,26 @@ InitializeMemoryServices ( > ); >=20 > /** > + Registers the found memory configuration with the PEI Foundation. >=20 > - Install the permanent memory is now available. > - Creates HOB (PHIT and Stack). > + This service enables PEIMs to register the permanent memory configura= tion > that has been initialized > + with the PEI Foundation. The result of this call-set is the creation = of the > appropriate Hand-Off Block > + (HOB) describing the physical memory. >=20 > - @param PeiServices An indirect pointer to the EFI_PEI_SERVICES ta= ble > published by the PEI Foundation. > - @param MemoryBegin Start of memory address. > - @param MemoryLength Length of memory. > + The usage model is that the PEIM that discovers the permanent memory = shall > invoke this service. > + This routine will store discovered memory information in the PeiCore'= s private > data, and set the > + SwitchStackSignal flag. After the PEIM who discovered memory is dispa= tched, > the PeiDispatcher will > + migrate temporary memory to permanent memory. > + > + The memory reported is a single contiguous run. It should be enough t= o > allocate a PEI stack and > + some HOB list. The full memory map will be reported using the appropr= iate > memory HOBs. The > + PEI Foundation will follow up with an installation of > EFI_PEI_PERMANENT_MEMORY_INSTALLED_PPI. > + > + Any invocations of this service after the first invocation which retu= rns > EFI_SUCCESS will be ignored. > + > + @param[in] PeiServices An indirect pointer to the EFI_PEI_SERVICE= S table > published by the PEI Foundation. > + @param[in] MemoryBegin Start of memory address. > + @param[in] MemoryLength Length of memory. >=20 > @return EFI_SUCCESS Always success. >=20 > diff --git a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c > b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c > index 706837890f..b6ac876145 100644 > --- a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c > +++ b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c > @@ -1,7 +1,7 @@ > /** @file > EFI PEI Core memory services >=20 > -Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
> +Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -55,17 +55,26 @@ InitializeMemoryServices ( > } >=20 > /** > + Registers the found memory configuration with the PEI Foundation. >=20 > - This function registers the found memory configuration with the PEI > Foundation. > + This service enables PEIMs to register the permanent memory configura= tion > that has been initialized > + with the PEI Foundation. The result of this call-set is the creation = of the > appropriate Hand-Off Block > + (HOB) describing the physical memory. >=20 > The usage model is that the PEIM that discovers the permanent memory = shall > invoke this service. > - This routine will hold discoveried memory information into PeiCore's = private > data, > - and set SwitchStackSignal flag. After PEIM who discovery memory is > dispatched, > - PeiDispatcher will migrate temporary memory to permenement memory. > + This routine will store discovered memory information in the PeiCore'= s private > data, and set the > + SwitchStackSignal flag. After the PEIM who discovered memory is dispa= tched, > the PeiDispatcher will > + migrate temporary memory to permanent memory. >=20 > - @param PeiServices An indirect pointer to the EFI_PEI_SERVICES= table > published by the PEI Foundation. > - @param MemoryBegin Start of memory address. > - @param MemoryLength Length of memory. > + The memory reported is a single contiguous run. It should be enough t= o > allocate a PEI stack and > + some HOB list. The full memory map will be reported using the appropr= iate > memory HOBs. The > + PEI Foundation will follow up with an installation of > EFI_PEI_PERMANENT_MEMORY_INSTALLED_PPI. > + > + Any invocations of this service after the first invocation which retu= rns > EFI_SUCCESS will be ignored. > + > + @param[in] PeiServices An indirect pointer to the EFI_PEI_SERVICE= S table > published by the PEI Foundation. > + @param[in] MemoryBegin Start of memory address. > + @param[in] MemoryLength Length of memory. >=20 > @return EFI_SUCCESS Always success. >=20 > -- > 2.16.2.windows.1 >=20 >=20 >=20