From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.19021.1574306788996071979 for ; Wed, 20 Nov 2019 19:26:29 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: jian.j.wang@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2019 19:26:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,224,1571727600"; d="scan'208";a="197088938" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga007.jf.intel.com with ESMTP; 20 Nov 2019 19:26:27 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 Nov 2019 19:26:27 -0800 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 Nov 2019 19:26:27 -0800 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.63]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.225]) with mapi id 14.03.0439.000; Thu, 21 Nov 2019 11:26:24 +0800 From: "Wang, Jian J" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Gao, Liming" , "Kinney, Michael D" , "Wu, Hao A" Subject: Re: [PATCH V1 1/1] MdeModulePkg/Variable: Initialize local variable Thread-Topic: [PATCH V1 1/1] MdeModulePkg/Variable: Initialize local variable Thread-Index: AQHVoBQO12Mgl6lBNkCxKgwDOxw73qeU9rTQ Date: Thu, 21 Nov 2019 03:26:24 +0000 Message-ID: References: <20191121023256.24820-1-michael.a.kubacki@intel.com> In-Reply-To: <20191121023256.24820-1-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDE2YzczYjctY2FhNC00YWFlLThkNTgtNjJmNzY4NzBmNGFkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiODZNTDRsclVQZjQ4TVNtZ3oxaE5yR1h0Skt4bXVqMU5UbmhwWFVPcGM4UmZOaUU4MXFySXo5ZGUyMDI2Z3E4eiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jian.j.wang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jian J Wang Regards, Jian > -----Original Message----- > From: Kubacki, Michael A > Sent: Thursday, November 21, 2019 10:33 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael D > ; Wang, Jian J ; Wu, H= ao > A > Subject: [PATCH V1 1/1] MdeModulePkg/Variable: Initialize local variable >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2364 >=20 > Fixes a new build warning in VS2012 introduced in f8ff4cca7c. >=20 > This patch initializes the local variable "Variable" in > VariableServiceGetNextVariableInternal () and the local > variable "RtPtrTrack" in FindVariableInRuntimeCache (). > This enusres the pointers in the structures are initialized > in the case no variable stores exist in the list of variable > stores. >=20 > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Jian J Wang > Cc: Hao A Wu > Signed-off-by: Michael Kubacki > --- > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableParsing.c | 2 += + > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c | 2 > ++ > 2 files changed, 4 insertions(+) >=20 > diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableParsing.c > b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableParsing.c > index d458f1c608..f6d187543d 100644 > --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableParsing.c > +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableParsing.c > @@ -551,6 +551,8 @@ VariableServiceGetNextVariableInternal ( > return EFI_INVALID_PARAMETER; > } >=20 > + ZeroMem (&Variable, sizeof (Variable)); > + > // Check if the variable exists in the given variable store list > for (StoreType =3D (VARIABLE_STORE_TYPE) 0; StoreType < > VariableStoreTypeMax; StoreType++) { > if (VariableStoreList[StoreType] =3D=3D NULL) { > diff --git > a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c > b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c > index d525998ae3..2cf0ed32ae 100644 > --- > a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c > +++ > b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c > @@ -590,6 +590,8 @@ FindVariableInRuntimeCache ( > return EFI_INVALID_PARAMETER; > } >=20 > + ZeroMem (&RtPtrTrack, sizeof (RtPtrTrack)); > + > // > // The UEFI specification restricts Runtime Services callers from invo= king the > same or certain other Runtime Service > // functions prior to completion and return from a previous Runtime Se= rvice > call. These restrictions prevent > -- > 2.16.2.windows.1