From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.24577.1574347425598107200 for ; Thu, 21 Nov 2019 06:43:45 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: jian.j.wang@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 06:43:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,226,1571727600"; d="scan'208";a="238199990" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 21 Nov 2019 06:43:44 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 06:43:44 -0800 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.63]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.127]) with mapi id 14.03.0439.000; Thu, 21 Nov 2019 22:43:42 +0800 From: "Wang, Jian J" To: "devel@edk2.groups.io" , "lersek@redhat.com" CC: Leif Lindholm , "Zhang, Shenglei" , "Lu, XiaoyuX" Subject: Re: [edk2-devel] [PATCH 3/3] CryptoPkg/OpensslLib.inf: list OpenSSL local header "ms/uplink.h" Thread-Topic: [edk2-devel] [PATCH 3/3] CryptoPkg/OpensslLib.inf: list OpenSSL local header "ms/uplink.h" Thread-Index: AQHVoE+AZo0dDFo8vkai2X7uBMj9/KeVs2Sg Date: Thu, 21 Nov 2019 14:43:41 +0000 Message-ID: References: <20191121093833.13840-1-lersek@redhat.com> <20191121093833.13840-4-lersek@redhat.com> In-Reply-To: <20191121093833.13840-4-lersek@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTAyNmEzZmUtNTA5NC00YTgyLTk0YjUtZWE0YTc0MzE5NmZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQWpcL0ZuZld4b0s2U2ZkUmpvbzZ6dERMNzlhanpJdjhOVHJIMkZkTU1aUDRwNHJiMk9BOXZsR1dDSUErOHh0Y3AifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jian.j.wang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Laszlo, Thanks for fixing this.=20 Reviewed-by: Jian J Wang Regards, Jian > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Laszlo Er= sek > Sent: Thursday, November 21, 2019 5:39 PM > To: edk2-devel-groups-io > Cc: Wang, Jian J ; Leif Lindholm > ; Zhang, Shenglei ; = Lu, > XiaoyuX > Subject: [edk2-devel] [PATCH 3/3] CryptoPkg/OpensslLib.inf: list OpenSSL= local > header "ms/uplink.h" >=20 > Commit 8906f076de35 ("CryptoPkg/OpensslLib: Add missing header files in > INF file", 2019-08-16) incorrectly placed "ms/uplink.h" in the > auto-generated part of [Sources], in "OpensslLib.inf". >=20 > ("ms/uplink.h" was added in the right spot in "OpensslLibCrypto.inf".) >=20 > Subsequently, when commit 9f4fbd56d430 ("CryptoPkg/OpensslLib: Update > process_files.pl to generate .h files", 2019-10-30) re-generated that pa= rt > of "OpensslLib.inf", the "ms/uplink.h" file reference was lost. This > triggers a warning from the "build" utility now. >=20 > Name the header file in the right spot in [Sources]. >=20 > This change makes "OpensslLib.inf" consistent with "OpensslLibCrypto.inf= ". >=20 > Cc: Jian J Wang > Cc: Leif Lindholm > Cc: Shenglei Zhang > Cc: Xiaoyu Lu > Fixes: 8906f076de35b222a7d62bcf6ed1a4a2498a5791 > Signed-off-by: Laszlo Ersek > --- >=20 > Notes: > Targeting edk2-stable201911. >=20 > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > index 58202f83118d..3fa52f554320 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > @@ -23,6 +23,7 @@ [Defines] >=20 > [Sources] > $(OPENSSL_PATH)/e_os.h > + $(OPENSSL_PATH)/ms/uplink.h > # Autogenerated files list starts here > $(OPENSSL_PATH)/crypto/aes/aes_cbc.c > $(OPENSSL_PATH)/crypto/aes/aes_cfb.c > -- > 2.19.1.3.g30247aa5d201 >=20 >=20 >=20