From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by mx.groups.io with SMTP id smtpd.web11.25703.1574351704398259762
 for <devel@edk2.groups.io>;
 Thu, 21 Nov 2019 07:55:04 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: jian.j.wang@intel.com)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga007.jf.intel.com ([10.7.209.58])
  by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 07:55:03 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.69,226,1571727600"; 
   d="scan'208";a="197282745"
Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204])
  by orsmga007.jf.intel.com with ESMTP; 21 Nov 2019 07:55:03 -0800
Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by
 FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Thu, 21 Nov 2019 07:55:03 -0800
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
 FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Thu, 21 Nov 2019 07:55:02 -0800
Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.63]) by
 SHSMSX151.ccr.corp.intel.com ([169.254.3.149]) with mapi id 14.03.0439.000;
 Thu, 21 Nov 2019 23:55:00 +0800
From: "Wang, Jian J" <jian.j.wang@intel.com>
To: Laszlo Ersek <lersek@redhat.com>, edk2-devel-groups-io
	<devel@edk2.groups.io>
CC: "Wu, Hao A" <hao.a.wu@intel.com>, Leif Lindholm
	<leif.lindholm@linaro.org>, "Gao, Liming" <liming.gao@intel.com>, "Kubacki,
 Michael A" <michael.a.kubacki@intel.com>
Subject: Re: [PATCH 1/3] MdeModulePkg/VariableSmmRuntimeDxe.inf: list local header "Variable.h"
Thread-Topic: [PATCH 1/3] MdeModulePkg/VariableSmmRuntimeDxe.inf: list local
 header "Variable.h"
Thread-Index: AQHVoE97/TJ1jw3PTEG8/NhdbnOG6KeVx2FA
Date: Thu, 21 Nov 2019 15:55:00 +0000
Message-ID: <D827630B58408649ACB04F44C5100036259B56F9@SHSMSX107.ccr.corp.intel.com>
References: <20191121093833.13840-1-lersek@redhat.com>
 <20191121093833.13840-2-lersek@redhat.com>
In-Reply-To: <20191121093833.13840-2-lersek@redhat.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjk2OWEyMTQtZThmNS00MjQ1LThhODctYjdmMjY2NWNkYmNhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK0tTcDFYXC82Tkp5SlZYS1Q1eldhRng4QTFmSUM1U0szaWNUVDBnVGJFOVwvVFwvRWFtSkF2cFdxOUlcLzhwcys0b3MifQ==
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: jian.j.wang@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable


Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

Regards,
Jian

> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Thursday, November 21, 2019 5:39 PM
> To: edk2-devel-groups-io <devel@edk2.groups.io>
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> Leif Lindholm <leif.lindholm@linaro.org>; Gao, Liming <liming.gao@intel.c=
om>;
> Kubacki, Michael A <michael.a.kubacki@intel.com>
> Subject: [PATCH 1/3] MdeModulePkg/VariableSmmRuntimeDxe.inf: list local
> header "Variable.h"
>=20
> Commit aab3b9b9a1e5 ("MdeModulePkg/Variable: Add RT GetVariable() cache
> support", 2019-11-05) added "VariableParsing.h" to
> "VariableSmmRuntimeDxe.inf".
>=20
> "VariableParsing.h" includes "Variable.h", so the "build" utility is righ=
t
> to warn us that "Variable.h" should be listed in [Sources] too.
>=20
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Fixes: aab3b9b9a1e5e1f3fa966fb1667fc3e6c47e7706
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>=20
> Notes:
>     Targeting edk2-stable201911.
>=20
>  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf |
> 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git
> a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf
> b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf
> index a250533a534f..592862773390 100644
> ---
> a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf
> +++
> b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf
> @@ -41,6 +41,7 @@ [Sources]
>    Measurement.c
>    VariableParsing.c
>    VariableParsing.h
> +  Variable.h
>=20
>  [Packages]
>    MdePkg/MdePkg.dec
> --
> 2.19.1.3.g30247aa5d201
>=20