From: "Wang, Jian J" <jian.j.wang@intel.com>
To: "Kubacki, Michael A" <michael.a.kubacki@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Bi, Dandan" <dandan.bi@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Wu, Hao A" <hao.a.wu@intel.com>
Subject: Re: [PATCH V2 0/2] MdeModulePkg PeiCore: Fix grammatical errors
Date: Thu, 28 Nov 2019 06:57:36 +0000 [thread overview]
Message-ID: <D827630B58408649ACB04F44C5100036259B870C@SHSMSX107.ccr.corp.intel.com> (raw)
In-Reply-To: <20191127195747.3192-1-michael.a.kubacki@intel.com>
For this patch series,
Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
Regards,
Jian
> -----Original Message-----
> From: Kubacki, Michael A <michael.a.kubacki@intel.com>
> Sent: Thursday, November 28, 2019 3:58 AM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <liming.gao@intel.com>;
> Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
> Subject: [PATCH V2 0/2] MdeModulePkg PeiCore: Fix grammatical errors
>
> V2 Changes:
> * "The index of the FV to search." to "Index of the FV to search"
> in the "Instance" parameter of ProcessFvFile ()
> * Removed "in this FV format" in the function description of
> AddUnknownFormatFvInfo ()
> * Explicitly stated the implied subject noun in the commit message
> of patch 2/2
>
> This patch series fixes grammatical errors in the PeiCore module.
>
> Originally, this was sent as a single patch which received two
> Reviewed-by responses:
> https://edk2.groups.io/g/devel/message/50841
>
> However, a suggestion was made to split the patch into syntactical
> and semantical changes. That suggestion is implemented in this
> series.
>
> The Reviewed-by responses were not carried forward so the maintainers
> can evaluate this series as a whole. The previous patch has been
> dropped.
>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
>
> Michael Kubacki (2):
> MdeModulePkg PeiCore: Fix typos
> MdeModulePkg PeiCore: Improve comment semantics
>
> MdeModulePkg/Core/Pei/PeiMain.inf | 10 +--
> MdeModulePkg/Core/Pei/FwVol/FwVol.h | 23 +++----
> MdeModulePkg/Core/Pei/PeiMain.h | 49 +++++++--------
> MdeModulePkg/Core/Pei/Dependency/Dependency.c | 12 ++--
> MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 52 ++++++++--------
> MdeModulePkg/Core/Pei/FwVol/FwVol.c | 64 ++++++++++----------
> MdeModulePkg/Core/Pei/Hob/Hob.c | 4 +-
> MdeModulePkg/Core/Pei/Image/Image.c | 10 +--
> MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 18 +++---
> MdeModulePkg/Core/Pei/PeiMain/PeiMain.c | 2 +-
> MdeModulePkg/Core/Pei/Ppi/Ppi.c | 4 +-
> MdeModulePkg/Core/Pei/Security/Security.c | 12 ++--
> 12 files changed, 132 insertions(+), 128 deletions(-)
>
> --
> 2.16.2.windows.1
next prev parent reply other threads:[~2019-11-28 6:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 19:57 [PATCH V2 0/2] MdeModulePkg PeiCore: Fix grammatical errors Kubacki, Michael A
2019-11-27 19:57 ` [PATCH V2 1/2] MdeModulePkg PeiCore: Fix typos Kubacki, Michael A
2019-11-28 13:02 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-11-27 19:57 ` [PATCH V2 2/2] MdeModulePkg PeiCore: Improve comment semantics Kubacki, Michael A
2019-11-28 13:06 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-11-28 6:57 ` Wang, Jian J [this message]
2019-12-11 6:38 ` [PATCH V2 0/2] MdeModulePkg PeiCore: Fix grammatical errors Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D827630B58408649ACB04F44C5100036259B870C@SHSMSX107.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox