From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web09.3684.1574924261065574680 for ; Wed, 27 Nov 2019 22:57:41 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: jian.j.wang@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Nov 2019 22:57:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,252,1571727600"; d="scan'208";a="410598995" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 27 Nov 2019 22:57:40 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 27 Nov 2019 22:57:39 -0800 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 27 Nov 2019 22:57:39 -0800 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.63]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.248]) with mapi id 14.03.0439.000; Thu, 28 Nov 2019 14:57:37 +0800 From: "Wang, Jian J" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Bi, Dandan" , "Gao, Liming" , "Wu, Hao A" Subject: Re: [PATCH V2 0/2] MdeModulePkg PeiCore: Fix grammatical errors Thread-Topic: [PATCH V2 0/2] MdeModulePkg PeiCore: Fix grammatical errors Thread-Index: AQHVpV1nBag0+6plfkSxUKB+PT8BOKegJ2QQ Date: Thu, 28 Nov 2019 06:57:36 +0000 Message-ID: References: <20191127195747.3192-1-michael.a.kubacki@intel.com> In-Reply-To: <20191127195747.3192-1-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjY5ZjQ1M2MtZmRiYi00NTQ1LWFjMjgtMTRiY2ZhMTk5OWVjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMHR3MmRSZWF6S2xVQnEwOG5oN0YyVnkxQ2p4aUc2TitHdFJIMWlEXC9vQ0xuNGVTbmZhdDlRSldJSlRrTHhGYUMifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jian.j.wang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For this patch series, Reviewed-by: Jian J Wang Regards, Jian > -----Original Message----- > From: Kubacki, Michael A > Sent: Thursday, November 28, 2019 3:58 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming ; > Wang, Jian J ; Wu, Hao A > Subject: [PATCH V2 0/2] MdeModulePkg PeiCore: Fix grammatical errors >=20 > V2 Changes: > * "The index of the FV to search." to "Index of the FV to search" > in the "Instance" parameter of ProcessFvFile () > * Removed "in this FV format" in the function description of > AddUnknownFormatFvInfo () > * Explicitly stated the implied subject noun in the commit message > of patch 2/2 >=20 > This patch series fixes grammatical errors in the PeiCore module. >=20 > Originally, this was sent as a single patch which received two > Reviewed-by responses: > https://edk2.groups.io/g/devel/message/50841 >=20 > However, a suggestion was made to split the patch into syntactical > and semantical changes. That suggestion is implemented in this > series. >=20 > The Reviewed-by responses were not carried forward so the maintainers > can evaluate this series as a whole. The previous patch has been > dropped. >=20 > Cc: Dandan Bi > Cc: Liming Gao > Cc: Jian J Wang > Cc: Hao A Wu > Signed-off-by: Michael Kubacki >=20 > Michael Kubacki (2): > MdeModulePkg PeiCore: Fix typos > MdeModulePkg PeiCore: Improve comment semantics >=20 > MdeModulePkg/Core/Pei/PeiMain.inf | 10 +-- > MdeModulePkg/Core/Pei/FwVol/FwVol.h | 23 +++---- > MdeModulePkg/Core/Pei/PeiMain.h | 49 +++++++-------- > MdeModulePkg/Core/Pei/Dependency/Dependency.c | 12 ++-- > MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 52 ++++++++-------- > MdeModulePkg/Core/Pei/FwVol/FwVol.c | 64 ++++++++++---------- > MdeModulePkg/Core/Pei/Hob/Hob.c | 4 +- > MdeModulePkg/Core/Pei/Image/Image.c | 10 +-- > MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 18 +++--- > MdeModulePkg/Core/Pei/PeiMain/PeiMain.c | 2 +- > MdeModulePkg/Core/Pei/Ppi/Ppi.c | 4 +- > MdeModulePkg/Core/Pei/Security/Security.c | 12 ++-- > 12 files changed, 132 insertions(+), 128 deletions(-) >=20 > -- > 2.16.2.windows.1