Re: [PATCH 1/6] SecurityPkg/Guid: Add TCG 800-155 event GUID definition.

["Wang, Jian J" <jian.j.wang@intel.com>]

Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

Regards,
Jian

> -----Original Message-----
> From: Yao, Jiewen <jiewen.yao@intel.com>
> Sent: Tuesday, December 31, 2019 2:44 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Zhang, Chao B
> <chao.b.zhang@intel.com>
> Subject: [PATCH 1/6] SecurityPkg/Guid: Add TCG 800-155 event GUID definition.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2439
> 
> The PEIM can produce the 800-155 event and the event
> will be recorded to TCG event log by the TCG2 DXE.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
> ---
>  SecurityPkg/Include/Guid/TcgEventHob.h | 11 +++++++++++
>  SecurityPkg/SecurityPkg.dec            |  4 ++++
>  2 files changed, 15 insertions(+)
> 
> diff --git a/SecurityPkg/Include/Guid/TcgEventHob.h
> b/SecurityPkg/Include/Guid/TcgEventHob.h
> index eef3f92abd..97e40b47d0 100644
> --- a/SecurityPkg/Include/Guid/TcgEventHob.h
> +++ b/SecurityPkg/Include/Guid/TcgEventHob.h
> @@ -49,4 +49,15 @@ extern EFI_GUID gTpmErrorHobGuid;
> 
>  extern EFI_GUID gTpm2StartupLocalityHobGuid;
> 
> +///
> +/// The Global ID of a GUIDed HOB used to record TCG 800-155 PlatformId
> Event.
> +/// HOB payload is the whole TCG_Sp800_155_PlatformId_Event2 according to
> TCG 800-155 PlatformId Event.
> +///
> +#define EFI_TCG_800_155_PLATFORM_ID_EVENT_HOB_GUID \
> +  { \
> +    0xe2c3bc69, 0x615c, 0x4b5b, { 0x8e, 0x5c, 0xa0, 0x33, 0xa9, 0xc2, 0x5e,
> 0xd6 } \
> +  }
> +
> +extern EFI_GUID gTcg800155PlatformIdEventHobGuid;
> +
>  #endif
> diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec
> index cac36caf0a..5335cc5397 100644
> --- a/SecurityPkg/SecurityPkg.dec
> +++ b/SecurityPkg/SecurityPkg.dec
> @@ -121,6 +121,10 @@
>    ## Include/Guid/TcgEventHob.h
>    gTpm2StartupLocalityHobGuid        = { 0x397b0c9, 0x22e8, 0x459e, { 0xa4, 0xff,
> 0x99, 0xbc, 0x65, 0x27, 0x9, 0x29 }}
> 
> +  ## HOB GUID used to record TCG 800-155 PlatformId Event
> +  ## Include/Guid/TcgEventHob.h
> +  gTcg800155PlatformIdEventHobGuid   = { 0xe2c3bc69, 0x615c, 0x4b5b, { 0x8e,
> 0x5c, 0xa0, 0x33, 0xa9, 0xc2, 0x5e, 0xd6 }}
> +
>    ## HOB GUID used to pass all PEI measured FV info to DXE Driver.
>    #  Include/Guid/MeasuredFvHob.h
>    gMeasuredFvHobGuid                 = { 0xb2360b42, 0x7173, 0x420a, { 0x86, 0x96,
> 0x46, 0xca, 0x6b, 0xab, 0x10, 0x60 }}
> --
> 2.19.2.windows.1