From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web09.239.1578291120467894606 for ; Sun, 05 Jan 2020 22:12:00 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: jian.j.wang@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jan 2020 22:12:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,401,1571727600"; d="scan'208";a="394921610" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga005.jf.intel.com with ESMTP; 05 Jan 2020 22:11:59 -0800 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 5 Jan 2020 22:11:59 -0800 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 5 Jan 2020 22:11:58 -0800 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.210]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.89]) with mapi id 14.03.0439.000; Mon, 6 Jan 2020 14:11:57 +0800 From: "Wang, Jian J" To: "devel@edk2.groups.io" , "Yao, Jiewen" CC: "Zhang, Chao B" Subject: Re: [edk2-devel] [PATCH 0/6] TCG: Add TCG PFP rev 105 and 800-155 event support. Thread-Topic: [edk2-devel] [PATCH 0/6] TCG: Add TCG PFP rev 105 and 800-155 event support. Thread-Index: AQHVv6XAFBmIX7kqkUWcDBG0UbtsEafdLdRQ Date: Mon, 6 Jan 2020 06:11:56 +0000 Message-ID: References: <20191231064412.22988-1-jiewen.yao@intel.com> In-Reply-To: <20191231064412.22988-1-jiewen.yao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjE4MWMxNDYtNWU4Ni00YzY0LWJmMmYtNTFlNjY0MGI3NTgxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRUpJblZ3S3pZbG5idnozVHpjU1B6T1J2RzNUdEUzejZHOVFOSnEyZDlaWUcwWjlSVVVub2lxWk5HOVF1U213cCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jian.j.wang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jiewen, Did you do tests on real platforms? I remember there're regressions caused= by TCG driver changes made months ago. Regards, Jian > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Yao, Jiew= en > Sent: Tuesday, December 31, 2019 2:44 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Zhang, Chao B > > Subject: [edk2-devel] [PATCH 0/6] TCG: Add TCG PFP rev 105 and 800-155 e= vent > support. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2439 >=20 > This patch series adds TCG PFP rev 105 and 800-155 event support. >=20 > TCG published Platform Firmware Profile spec revision 105 > (https://trustedcomputinggroup.org/wp- > content/uploads/TCG_PCClient_PFP_r1p05_05_3feb20.pdf) > and Firmware Integrity Measurement spec > (https://trustedcomputinggroup.org/wp-content/uploads/TCG_PC_Client- > FIM_v1r24_3feb20.pdf) >=20 > 2 major impact to the BIOS: >=20 > 1) Need add 800-155 event at the beginning of the TCG2 event log. >=20 > 2) Need use EV_EFI_PLATFORM_FIRMWARE_BLOB2 to replace > EV_EFI_PLATFORM_FIRMWARE_BLOB > and use EV_EFI_HANDOFF_TABLES2 to replace EV_EFI_HANDOFF_TABLES. >=20 > TCG2 DXE update: Add 800-155 event handling. > TCG2 PEI update: Use EV_EFI_PLATFORM_FIRMWARE_BLOB2. > Smbios Update: Use EV_EFI_HANDOFF_TABLES2. >=20 > This patch series is tested on EmulatorPkg with TPM2 simulator. > (https://github.com/jyao1/edk2/tree/feature_tpm_emulator). >=20 > The new entries - 800-155 event, EV_EFI_PLATFORM_FIRMWARE_BLOB2, > EV_EFI_HANDOFF_TABLES2, > can be dumpped with UEFI Tcg2DumpLog tool. > (https://github.com/jyao1/EdkiiShellTool/tree/master/EdkiiShellToolPkg/T= cg2D > umpLog) >=20 > NOTE: To support the full 800-155 requirement in TCG, a platform need re= port > the > platform specific 800-155 event. >=20 > If the platform chooses to report in PEI, it can refer to the example at > https://github.com/jyao1/edk2/tree/feature_tpm_emulator/EmulatorPkg/Tpm2 > /Platform800155EventPei. >=20 > If the platform chooses to report in DXE, it can refer to the example at > https://github.com/jyao1/edk2/tree/feature_tpm_emulator/EmulatorPkg/Tpm2 > /Platform800155EventDxe. >=20 > Multiple 800-155 events are support. >=20 > Cc: Jian J Wang > Cc: Chao Zhang > Signed-off-by: Jiewen Yao >=20 >=20 >=20 > Jiewen Yao (6): > SecurityPkg/Guid: Add TCG 800-155 event GUID definition. > SecurityPkg/Tcg2Dxe: Add Tcg2Dxe to support 800-155 event. > MdeModulePkg/Smbios: Done measure Smbios multiple times. > MdeModulePkg/dec: add PcdTcgPfpMeasurementRevision PCD > MdeModulePkg/Smbios: Add TCG PFP rev 105 support. > SecurityPkg/Tcg2Pei: Add TCG PFP 105 support. >=20 > MdeModulePkg/MdeModulePkg.dec | 8 + > .../SmbiosMeasurementDxe.c | 39 ++++- > .../SmbiosMeasurementDxe.inf | 3 + > SecurityPkg/Include/Guid/TcgEventHob.h | 11 ++ > SecurityPkg/SecurityPkg.dec | 4 + > SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 157 ++++++++++++++---- > SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf | 1 + > SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 91 +++++++++- > SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf | 2 + > 9 files changed, 273 insertions(+), 43 deletions(-) >=20 > -- > 2.19.2.windows.1 >=20 >=20 >=20