From: "Wang, Jian J" <jian.j.wang@intel.com>
To: "Lu, XiaoyuX" <xiaoyux.lu@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Laszlo Ersek <lersek@redhat.com>
Subject: Re: [edk2-devel] [PATCH v3 0/2] Remove deprecated code in BaseCryptLib
Date: Mon, 20 Jan 2020 16:25:16 +0000 [thread overview]
Message-ID: <D827630B58408649ACB04F44C5100036259F6E0B@SHSMSX107.ccr.corp.intel.com> (raw)
In-Reply-To: <793d4ce1388b46dd814d660a2d71836d@intel.com>
Thanks for the comment. It will be updated before push.
Regards,
Jian
> -----Original Message-----
> From: Lu, XiaoyuX <xiaoyux.lu@intel.com>
> Sent: Sunday, January 19, 2020 10:05 AM
> To: devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Subject: RE: [edk2-devel] [PATCH v3 0/2] Remove deprecated code in
> BaseCryptLib
>
> Hi Jian,
>
> The date of copyright info should be update to 2020 in each changed file. with
> these changed:
> Reviewed-by: Xiaoyu Lu <xiaoyux.lu@intel.com>
>
> Thanks.
>
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Wang, Jian J
> > Sent: Thursday, January 16, 2020 2:10 PM
> > To: devel@edk2.groups.io
> > Cc: Lu, XiaoyuX <xiaoyux.lu@intel.com>; Laszlo Ersek <lersek@redhat.com>
> > Subject: [edk2-devel] [PATCH v3 0/2] Remove deprecated code in
> > BaseCryptLib
> >
> > v3 changes per Laszlo's comments:
> >
> > - Fix typos
> >
> > - Change api name also for BaseCryptLibNull
> >
> > - Split the patch into two
> >
> > (v3 branch: https://github.com/jwang36/edk2/tree/fix-bz1792-v3)
> >
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1792
> >
> > Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> >
> > Cc: Laszlo Ersek <lersek@redhat.com>
> >
> > Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
> >
> > Jian J Wang (2):
> > CryptoPkg/BaseCryptLib: replace HmacXxxInit API with HmacXxxSetKey
> > CryptoPkg/BaseCryptLib: remove HmacXxxGetContextSize interface
> >
> > CryptoPkg/Include/Library/BaseCryptLib.h | 111 +++++-------------
> > .../Library/BaseCryptLib/Hmac/CryptHmacMd5.c | 58 ++-------
> > .../BaseCryptLib/Hmac/CryptHmacMd5Null.c | 28 +----
> > .../Library/BaseCryptLib/Hmac/CryptHmacSha1.c | 59 ++--------
> > .../BaseCryptLib/Hmac/CryptHmacSha1Null.c | 28 +----
> > .../BaseCryptLib/Hmac/CryptHmacSha256.c | 58 ++-------
> > .../BaseCryptLib/Hmac/CryptHmacSha256Null.c | 28 +----
> > .../BaseCryptLibNull/Hmac/CryptHmacMd5Null.c | 28 +----
> > .../BaseCryptLibNull/Hmac/CryptHmacSha1Null.c | 28 +----
> > .../Hmac/CryptHmacSha256Null.c | 28 +----
> > 10 files changed, 84 insertions(+), 370 deletions(-)
> >
> > --
> > 2.24.0.windows.2
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> >
> > View/Reply Online (#53299): https://edk2.groups.io/g/devel/message/53299
> > Mute This Topic: https://groups.io/mt/69742158/1780156
> > Group Owner: devel+owner@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub [xiaoyux.lu@intel.com]
> > -=-=-=-=-=-=
prev parent reply other threads:[~2020-01-20 16:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 6:10 [PATCH v3 0/2] Remove deprecated code in BaseCryptLib Wang, Jian J
2020-01-16 6:10 ` [PATCH v3 1/2] CryptoPkg/BaseCryptLib: replace HmacXxxInit API with HmacXxxSetKey Wang, Jian J
2020-01-16 9:08 ` Laszlo Ersek
2020-01-17 2:19 ` Wang, Jian J
2020-01-16 6:10 ` [PATCH v3 2/2] CryptoPkg/BaseCryptLib: remove HmacXxxGetContextSize interface Wang, Jian J
2020-01-16 9:13 ` Laszlo Ersek
2020-01-19 2:04 ` [edk2-devel] [PATCH v3 0/2] Remove deprecated code in BaseCryptLib Xiaoyu Lu
2020-01-20 16:25 ` Wang, Jian J [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D827630B58408649ACB04F44C5100036259F6E0B@SHSMSX107.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox