Re: [PATCH v4 1/2] CryptoPkg: Add CryptoPkg Token Space GUID

["Wang, Jian J" <jian.j.wang@intel.com>]

Amol,

One comment below.

> -----Original Message-----
> From: Sukerkar, Amol N <amol.n.sukerkar@intel.com>
> Sent: Saturday, January 18, 2020 6:32 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Agrawal,
> Sachin <sachin.agrawal@intel.com>; Musti, Srinivas <srinivas.musti@intel.com>;
> Lakkimsetti, Subash <subash.lakkimsetti@intel.com>
> Subject: [PATCH v4 1/2] CryptoPkg: Add CryptoPkg Token Space GUID
> 
> Added CryptoPkg Token Space GUID to be able to define PCDs.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Sukerkar, Amol N <amol.n.sukerkar@intel.com>
> ---
>  CryptoPkg/CryptoPkg.dec                      |  7 ++++++-
>  CryptoPkg/Include/Guid/CryptoPkgTokenSpace.h | 19 +++++++++++++++++++
>  2 files changed, 25 insertions(+), 1 deletion(-)
> 
> diff --git a/CryptoPkg/CryptoPkg.dec b/CryptoPkg/CryptoPkg.dec
> index 08bedd57daad..a548ec7ddc71 100644
> --- a/CryptoPkg/CryptoPkg.dec
> +++ b/CryptoPkg/CryptoPkg.dec
> @@ -4,7 +4,7 @@
>  #  This Package provides cryptographic-related libraries for UEFI security
> modules.
>  #  It also provides a test application to test libraries.
>  #
> -#  Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
> +#  Copyright (c) 2009 - 2020, Intel Corporation. All rights reserved.<BR>
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
>  ##
> @@ -33,5 +33,10 @@ [LibraryClasses]
>    ##
>    TlsLib|Include/Library/TlsLib.h
> 
> +[Guids]
> +  ## Security package token space guid.
> +  # Include/Guid/CryptoPkgTokenSpace.h
> +  gEfiCryptoPkgTokenSpaceGuid      = { 0xd3fb176, 0x9569, 0x4d51, { 0xa3, 0xef,
> 0x7d, 0x61, 0xc6, 0x4f, 0xea, 0xba }}
> +
>  [UserExtensions.TianoCore."ExtraFiles"]
>    CryptoPkgExtra.uni
> diff --git a/CryptoPkg/Include/Guid/CryptoPkgTokenSpace.h
> b/CryptoPkg/Include/Guid/CryptoPkgTokenSpace.h
> new file mode 100644
> index 000000000000..ed3626d7b4e1
> --- /dev/null
> +++ b/CryptoPkg/Include/Guid/CryptoPkgTokenSpace.h
> @@ -0,0 +1,19 @@
> +/** @file
> +  GUID for CryptoPkg PCD Token Space.
> +
> +Copyright (c) 2009 - 2020, Intel Corporation. All rights reserved.<BR>

I think this is new file, which should start from this year

Regards,
Jian

> +SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#ifndef _CRYPTOPKG_TOKEN_SPACE_GUID_H_
> +#define _CRYPTOPKG_TOKEN_SPACE_GUID_H_
> +
> +#define CRYPTOPKG_TOKEN_SPACE_GUID \
> +  { \
> +    0x7c4b0548, 0xd267, 0x451f, { 0xb5, 0x68, 0x58, 0x4f, 0x82, 0xb2, 0x1c,
> 0x89 } \
> +  }
> +
> +extern EFI_GUID gEfiCryptoPkgTokenSpaceGuid;
> +
> +#endif
> --
> 2.16.2.windows.1