From: "Wang, Jian J" <jian.j.wang@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Lu, XiaoyuX" <xiaoyux.lu@intel.com>
Subject: Re: [Patch v7 0/5] CryptoPkg: Add modules that produce BaseCryptLib services
Date: Wed, 5 Feb 2020 06:03:22 +0000 [thread overview]
Message-ID: <D827630B58408649ACB04F44C510003625A0804E@SHSMSX107.ccr.corp.intel.com> (raw)
In-Reply-To: <20200205025845.9764-1-michael.d.kinney@intel.com>
For the whole patch series,
Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
Regards,
Jian
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Wednesday, February 05, 2020 10:59 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>
> Subject: [Patch v7 0/5] CryptoPkg: Add modules that produce BaseCryptLib
> services
>
> New in V7
> * Sync with edk2/master to align with HashApiLib commits
> * Fix typos and comment spelling
> * Update supported archs
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=2420
>
> Based on the following package with changes to merge into CryptoPkg.
>
> https://github.com/microsoft/mu_plus/tree/dev/201908/SharedCryptoPkg
>
> * Add X509ConstructCertificateStackV() to BaseCryptLib. This is required to
> have a VA_LIST version of X509ConstructCertificateStack() so it can be
> maped into a Protocol/PPI.
> * Add EDK II Crypto Protocols/PPIs/PCDs
> * Add PEIM, DXE Driver, SMM Driver that produce the EDK II Crypto
> Protocols/PPIs
> using the services of the BaseCryptLib and TlsLib with families of services
> and individual services enabled/disables in the Protocols/PPIs using a PCD.
> * Add new BaseCryptLib library instance that calls the EDK II Crypto
> Protocols/PPIs.
> * Update DSC file to build all modules/libs and provide ability to build binary
> versions of the PEIM, DXE Driver, SMM Driver with different sets of Crypto
> services enabled.
>
> This patch series depends on the following bugs that must be resolved
> before this patch series will build and pass EDK II CI.
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=2495
> https://bugzilla.tianocore.org/show_bug.cgi?id=2496
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
>
> Michael D Kinney (5):
> CryptoPkg/BaseCryptLib: Add X509ConstructCertificateStackV().
> CryptoPkg: Add EDK II Crypto Protocols/PPIs/PCDs
> CryptoPkg/Driver: Add Crypto PEIM, DXE, and SMM modules
> CryptoPkg/Library: Add BaseCryptLibOnProtocolPpi instances
> CryptoPkg/CryptoPkg.dsc: Add build of Crypto libraries/modules
>
> CryptoPkg/CryptoPkg.dec | 28 +
> CryptoPkg/CryptoPkg.dsc | 207 +-
> CryptoPkg/CryptoPkg.uni | 5 +-
> .../BaseCryptLib.h => Driver/Crypto.c} | 2139 ++++++-
> CryptoPkg/Driver/Crypto.uni | 13 +
> CryptoPkg/Driver/CryptoDxe.c | 38 +
> CryptoPkg/Driver/CryptoDxe.inf | 49 +
> CryptoPkg/Driver/CryptoPei.c | 99 +
> CryptoPkg/Driver/CryptoPei.inf | 51 +
> CryptoPkg/Driver/CryptoSmm.c | 41 +
> CryptoPkg/Driver/CryptoSmm.inf | 49 +
> CryptoPkg/Include/Library/BaseCryptLib.h | 26 +
> .../Pcd/PcdCryptoServiceFamilyEnable.h | 293 +
> CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c | 50 +-
> .../Library/BaseCryptLib/Pk/CryptX509Null.c | 32 +-
> .../BaseCryptLibNull/Pk/CryptX509Null.c | 32 +-
> .../BaseCryptLibOnProtocolPpi/CryptLib.c} | 1701 +++++-
> .../BaseCryptLibOnProtocolPpi/CryptLib.uni | 12 +
> .../BaseCryptLibOnProtocolPpi/DxeCryptLib.c | 68 +
> .../BaseCryptLibOnProtocolPpi/DxeCryptLib.inf | 44 +
> .../BaseCryptLibOnProtocolPpi/PeiCryptLib.c | 57 +
> .../BaseCryptLibOnProtocolPpi/PeiCryptLib.inf | 43 +
> .../BaseCryptLibOnProtocolPpi/SmmCryptLib.c | 79 +
> .../BaseCryptLibOnProtocolPpi/SmmCryptLib.inf | 44 +
> CryptoPkg/Private/Ppi/Crypto.h | 21 +
> .../Protocol/Crypto.h} | 5330 ++++++++++-------
> CryptoPkg/Private/Protocol/SmmCrypto.h | 21 +
> 27 files changed, 7860 insertions(+), 2712 deletions(-)
> copy CryptoPkg/{Include/Library/BaseCryptLib.h => Driver/Crypto.c} (61%)
> create mode 100644 CryptoPkg/Driver/Crypto.uni
> create mode 100644 CryptoPkg/Driver/CryptoDxe.c
> create mode 100644 CryptoPkg/Driver/CryptoDxe.inf
> create mode 100644 CryptoPkg/Driver/CryptoPei.c
> create mode 100644 CryptoPkg/Driver/CryptoPei.inf
> create mode 100644 CryptoPkg/Driver/CryptoSmm.c
> create mode 100644 CryptoPkg/Driver/CryptoSmm.inf
> create mode 100644 CryptoPkg/Include/Pcd/PcdCryptoServiceFamilyEnable.h
> copy CryptoPkg/{Include/Library/BaseCryptLib.h =>
> Library/BaseCryptLibOnProtocolPpi/CryptLib.c} (67%)
> create mode 100644
> CryptoPkg/Library/BaseCryptLibOnProtocolPpi/CryptLib.uni
> create mode 100644
> CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
> create mode 100644
> CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.inf
> create mode 100644
> CryptoPkg/Library/BaseCryptLibOnProtocolPpi/PeiCryptLib.c
> create mode 100644
> CryptoPkg/Library/BaseCryptLibOnProtocolPpi/PeiCryptLib.inf
> create mode 100644
> CryptoPkg/Library/BaseCryptLibOnProtocolPpi/SmmCryptLib.c
> create mode 100644
> CryptoPkg/Library/BaseCryptLibOnProtocolPpi/SmmCryptLib.inf
> create mode 100644 CryptoPkg/Private/Ppi/Crypto.h
> copy CryptoPkg/{Include/Library/BaseCryptLib.h => Private/Protocol/Crypto.h}
> (62%)
> create mode 100644 CryptoPkg/Private/Protocol/SmmCrypto.h
>
> --
> 2.21.0.windows.1
prev parent reply other threads:[~2020-02-05 6:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 2:58 [Patch v7 0/5] CryptoPkg: Add modules that produce BaseCryptLib services Michael D Kinney
2020-02-05 2:58 ` [Patch v7 1/5] CryptoPkg/BaseCryptLib: Add X509ConstructCertificateStackV() Michael D Kinney
2020-02-05 2:58 ` [Patch v7 2/5] CryptoPkg: Add EDK II Crypto Protocols/PPIs/PCDs Michael D Kinney
2020-02-05 2:58 ` [Patch v7 3/5] CryptoPkg/Driver: Add Crypto PEIM, DXE, and SMM modules Michael D Kinney
2020-02-05 2:58 ` [Patch v7 4/5] CryptoPkg/Library: Add BaseCryptLibOnProtocolPpi instances Michael D Kinney
2020-02-05 2:58 ` [Patch v7 5/5] CryptoPkg/CryptoPkg.dsc: Add build of Crypto libraries/modules Michael D Kinney
2020-02-05 6:03 ` Wang, Jian J [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D827630B58408649ACB04F44C510003625A0804E@SHSMSX107.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox