From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.3199.1580882607653371625 for ; Tue, 04 Feb 2020 22:03:27 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: jian.j.wang@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Feb 2020 22:03:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,404,1574150400"; d="scan'208";a="249599344" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 04 Feb 2020 22:03:26 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 4 Feb 2020 22:03:24 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 4 Feb 2020 22:03:24 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 4 Feb 2020 22:03:23 -0800 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.46]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.98]) with mapi id 14.03.0439.000; Wed, 5 Feb 2020 14:03:22 +0800 From: "Wang, Jian J" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Lu, XiaoyuX" Subject: Re: [Patch v7 0/5] CryptoPkg: Add modules that produce BaseCryptLib services Thread-Topic: [Patch v7 0/5] CryptoPkg: Add modules that produce BaseCryptLib services Thread-Index: AQHV29AxSJHbL+ZvJ0GhRjvF85vhWKgMHB3g Date: Wed, 5 Feb 2020 06:03:22 +0000 Message-ID: References: <20200205025845.9764-1-michael.d.kinney@intel.com> In-Reply-To: <20200205025845.9764-1-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTg2MmI1ZGYtZjE4MS00ZDNiLWFlMGEtMmI0NTQ5N2RlYjRkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZlBUSnJJZjlsSU9VMVwvUHNxV2htT2pQRGRuUTNYcnVmOFU5N21ONDhSblY4ZWV2UGtUcHhMU1lodkxKcDlGdCsifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jian.j.wang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For the whole patch series, Reviewed-by: Jian J Wang Regards, Jian > -----Original Message----- > From: Kinney, Michael D > Sent: Wednesday, February 05, 2020 10:59 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, XiaoyuX > Subject: [Patch v7 0/5] CryptoPkg: Add modules that produce BaseCryptLib > services >=20 > New in V7 > * Sync with edk2/master to align with HashApiLib commits > * Fix typos and comment spelling > * Update supported archs >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2420 >=20 > Based on the following package with changes to merge into CryptoPkg. >=20 > https://github.com/microsoft/mu_plus/tree/dev/201908/SharedCryptoPkg >=20 > * Add X509ConstructCertificateStackV() to BaseCryptLib. This is required= to > have a VA_LIST version of X509ConstructCertificateStack() so it can be > maped into a Protocol/PPI. > * Add EDK II Crypto Protocols/PPIs/PCDs > * Add PEIM, DXE Driver, SMM Driver that produce the EDK II Crypto > Protocols/PPIs > using the services of the BaseCryptLib and TlsLib with families of serv= ices > and individual services enabled/disables in the Protocols/PPIs using a = PCD. > * Add new BaseCryptLib library instance that calls the EDK II Crypto > Protocols/PPIs. > * Update DSC file to build all modules/libs and provide ability to build = binary > versions of the PEIM, DXE Driver, SMM Driver with different sets of Cry= pto > services enabled. >=20 > This patch series depends on the following bugs that must be resolved > before this patch series will build and pass EDK II CI. >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2495 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2496 >=20 > Cc: Jian J Wang > Cc: Xiaoyu Lu > Signed-off-by: Michael D Kinney >=20 > Michael D Kinney (5): > CryptoPkg/BaseCryptLib: Add X509ConstructCertificateStackV(). > CryptoPkg: Add EDK II Crypto Protocols/PPIs/PCDs > CryptoPkg/Driver: Add Crypto PEIM, DXE, and SMM modules > CryptoPkg/Library: Add BaseCryptLibOnProtocolPpi instances > CryptoPkg/CryptoPkg.dsc: Add build of Crypto libraries/modules >=20 > CryptoPkg/CryptoPkg.dec | 28 + > CryptoPkg/CryptoPkg.dsc | 207 +- > CryptoPkg/CryptoPkg.uni | 5 +- > .../BaseCryptLib.h =3D> Driver/Crypto.c} | 2139 ++++++- > CryptoPkg/Driver/Crypto.uni | 13 + > CryptoPkg/Driver/CryptoDxe.c | 38 + > CryptoPkg/Driver/CryptoDxe.inf | 49 + > CryptoPkg/Driver/CryptoPei.c | 99 + > CryptoPkg/Driver/CryptoPei.inf | 51 + > CryptoPkg/Driver/CryptoSmm.c | 41 + > CryptoPkg/Driver/CryptoSmm.inf | 49 + > CryptoPkg/Include/Library/BaseCryptLib.h | 26 + > .../Pcd/PcdCryptoServiceFamilyEnable.h | 293 + > CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c | 50 +- > .../Library/BaseCryptLib/Pk/CryptX509Null.c | 32 +- > .../BaseCryptLibNull/Pk/CryptX509Null.c | 32 +- > .../BaseCryptLibOnProtocolPpi/CryptLib.c} | 1701 +++++- > .../BaseCryptLibOnProtocolPpi/CryptLib.uni | 12 + > .../BaseCryptLibOnProtocolPpi/DxeCryptLib.c | 68 + > .../BaseCryptLibOnProtocolPpi/DxeCryptLib.inf | 44 + > .../BaseCryptLibOnProtocolPpi/PeiCryptLib.c | 57 + > .../BaseCryptLibOnProtocolPpi/PeiCryptLib.inf | 43 + > .../BaseCryptLibOnProtocolPpi/SmmCryptLib.c | 79 + > .../BaseCryptLibOnProtocolPpi/SmmCryptLib.inf | 44 + > CryptoPkg/Private/Ppi/Crypto.h | 21 + > .../Protocol/Crypto.h} | 5330 ++++++++++------- > CryptoPkg/Private/Protocol/SmmCrypto.h | 21 + > 27 files changed, 7860 insertions(+), 2712 deletions(-) > copy CryptoPkg/{Include/Library/BaseCryptLib.h =3D> Driver/Crypto.c} (61= %) > create mode 100644 CryptoPkg/Driver/Crypto.uni > create mode 100644 CryptoPkg/Driver/CryptoDxe.c > create mode 100644 CryptoPkg/Driver/CryptoDxe.inf > create mode 100644 CryptoPkg/Driver/CryptoPei.c > create mode 100644 CryptoPkg/Driver/CryptoPei.inf > create mode 100644 CryptoPkg/Driver/CryptoSmm.c > create mode 100644 CryptoPkg/Driver/CryptoSmm.inf > create mode 100644 CryptoPkg/Include/Pcd/PcdCryptoServiceFamilyEnable.h > copy CryptoPkg/{Include/Library/BaseCryptLib.h =3D> > Library/BaseCryptLibOnProtocolPpi/CryptLib.c} (67%) > create mode 100644 > CryptoPkg/Library/BaseCryptLibOnProtocolPpi/CryptLib.uni > create mode 100644 > CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c > create mode 100644 > CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.inf > create mode 100644 > CryptoPkg/Library/BaseCryptLibOnProtocolPpi/PeiCryptLib.c > create mode 100644 > CryptoPkg/Library/BaseCryptLibOnProtocolPpi/PeiCryptLib.inf > create mode 100644 > CryptoPkg/Library/BaseCryptLibOnProtocolPpi/SmmCryptLib.c > create mode 100644 > CryptoPkg/Library/BaseCryptLibOnProtocolPpi/SmmCryptLib.inf > create mode 100644 CryptoPkg/Private/Ppi/Crypto.h > copy CryptoPkg/{Include/Library/BaseCryptLib.h =3D> Private/Protocol/Cry= pto.h} > (62%) > create mode 100644 CryptoPkg/Private/Protocol/SmmCrypto.h >=20 > -- > 2.21.0.windows.1