From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web09.5330.1581922230288851046 for ; Sun, 16 Feb 2020 22:50:30 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: jian.j.wang@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Feb 2020 22:50:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,451,1574150400"; d="scan'208";a="227953028" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga007.fm.intel.com with ESMTP; 16 Feb 2020 22:50:29 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 16 Feb 2020 22:50:29 -0800 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 16 Feb 2020 22:50:29 -0800 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.46]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.141]) with mapi id 14.03.0439.000; Mon, 17 Feb 2020 14:50:26 +0800 From: "Wang, Jian J" To: "devel@edk2.groups.io" , "Zurcher, Christopher J" CC: "Lu, XiaoyuX" Subject: Re: [edk2-devel] [PATCH v3 0/2] CryptoPkg/OpensslLib: Remove "no-autoalginit" flag from OpenSSL build Thread-Topic: [edk2-devel] [PATCH v3 0/2] CryptoPkg/OpensslLib: Remove "no-autoalginit" flag from OpenSSL build Thread-Index: AQHV4s9bTEqSnK2TpUCupAgLdfHhp6ge91Zw Date: Mon, 17 Feb 2020 06:50:26 +0000 Message-ID: References: <20200214004021.17300-1-christopher.j.zurcher@intel.com> In-Reply-To: <20200214004021.17300-1-christopher.j.zurcher@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGNkM2Y3YjctZWUxYy00YjRkLWIyM2UtNjlhZTU0NTM1MWU0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUjZmWFlBTSs2cUdGdVI2cWIzcFhyclIrNUdEXC9mNEFlVXU5WFpZbE5ObkI2b3VwV2FPdEJDamRyclozSEd3MkMifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jian.j.wang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For the patch series, Reviewed-by: Jian J Wang Regards, Jian > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Zurcher, > Christopher J > Sent: Friday, February 14, 2020 8:40 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, XiaoyuX > Subject: [edk2-devel] [PATCH v3 0/2] CryptoPkg/OpensslLib: Remove "no- > autoalginit" flag from OpenSSL build >=20 > In order to implement the EVP interface, the EVP_get_digestbyname functi= on > requires the desired digest to be already initialized. Removing the > "no-autoalginit" build option will allow algorithms to be retrieved by n= ame. > I plan to submit a future patch with an EVP implementation; the OpenSSL > documentation has stated that the EVP interface "should almost always be > used" over direct digest interfaces at least as far back as version 0.9.= 6c. >=20 > This patch set also adds the "sort" keyword to the header file parsing l= oop > so the .inf files aren't randomized after every run of process_files.pl. >=20 > Cc: Jian J Wang > Cc: Xiaoyu Lu >=20 > Christopher J Zurcher (2): > CryptoPkg/OpensslLib: Add "sort" keyword to header file parsing loop > CryptoPkg/OpensslLib: Remove "no-autoalginit" flag from OpenSSL build >=20 > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 66 ++++++++++------= ---- > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 62 +++++++++-------= -- > CryptoPkg/Library/Include/openssl/opensslconf.h | 3 - > CryptoPkg/Library/OpensslLib/process_files.pl | 5 +- > 4 files changed, 66 insertions(+), 70 deletions(-) >=20 > -- > 2.16.2.windows.1 >=20 >=20 >=20