From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.3166.1581990507786722809 for ; Mon, 17 Feb 2020 17:48:27 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: jian.j.wang@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Feb 2020 17:48:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,454,1574150400"; d="scan'208";a="253567335" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 17 Feb 2020 17:48:27 -0800 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 17 Feb 2020 17:48:26 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 17 Feb 2020 17:48:26 -0800 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.46]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.196]) with mapi id 14.03.0439.000; Tue, 18 Feb 2020 09:48:23 +0800 From: "Wang, Jian J" To: "Sukerkar, Amol N" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Yao, Jiewen" , "Agrawal, Sachin" , "Gao, Liming" Subject: Re: [PATCH v6 0/2] Enhancement and Fixes to BaseHashApiLib Thread-Topic: [PATCH v6 0/2] Enhancement and Fixes to BaseHashApiLib Thread-Index: AQHV5DlF4OtyxNcJEUGgVktd6+T4QqggMnig Date: Tue, 18 Feb 2020 01:48:23 +0000 Message-ID: References: <20200215195103.9848-1-amol.n.sukerkar@intel.com> In-Reply-To: <20200215195103.9848-1-amol.n.sukerkar@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGUyMDE5MTgtYzQzNS00NDZiLTkwMDctNDVmMmNkMjhlY2ExIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoia2dsamVyWTR0NFVrbyttNm5QMHhlVnM2bnpxWW5Ia3ErUzZRUTBZaUFXV01ZMmMrQU9qNldXb1hIXC9vRnh0dmEifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jian.j.wang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For the whole patch series, Reviewed-by: Jian J Wang Regards, Jian > -----Original Message----- > From: Sukerkar, Amol N > Sent: Sunday, February 16, 2020 3:51 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Yao, Jiewen > ; Wang, Jian J ; Agrawal, > Sachin ; Gao, Liming > Subject: [PATCH v6 0/2] Enhancement and Fixes to BaseHashApiLib >=20 > This patch implements the fixes and enhancement to BaseHashApiLib in > the following manner: > - Remove reference to MD4 and MD5 hashing algorithms as they are > deprecated; > - Align the enumeration for hashing algorithmswith the one used in > TPM 2.0 implementation defined in IndustryStandard/Tpm20.h; > - Change the type of PcdHashApiLibPolicy to PcdsFixedAtBuild to > optimize away the unused hashing algorithms for a particular > instance of HashApiLib. >=20 > More information can be found at Bugzilla ticket, > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2511. >=20 > Amol N Sukerkar (2): > CryptoPkg/BaseHashApiLib: Align BaseHashApiLib with TPM 2.0 > Implementation > CryptoPkg/BaseHashApiLib: Change PcdHashApiLibPolicy type to > FixedAtBuild >=20 > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c | 121 ++++++----------= ---- > CryptoPkg/CryptoPkg.dec | 17 ++- > CryptoPkg/CryptoPkg.uni | 12 +- > CryptoPkg/Include/Library/HashApiLib.h | 16 +-- > 4 files changed, 51 insertions(+), 115 deletions(-) >=20 > -- > 2.16.2.windows.1