From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.13819.1582127044333219413 for ; Wed, 19 Feb 2020 07:44:04 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: jian.j.wang@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Feb 2020 07:44:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,461,1574150400"; d="scan'208";a="283133221" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 19 Feb 2020 07:44:03 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 19 Feb 2020 07:44:02 -0800 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.46]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.158]) with mapi id 14.03.0439.000; Wed, 19 Feb 2020 23:43:39 +0800 From: "Wang, Jian J" To: "devel@edk2.groups.io" , "lersek@redhat.com" , "Bi, Dandan" , "Wu, Hao A" CC: "xypron.glpk@gmx.de" , "Jin, Eric" , Supreeth Venkatesh , Stephano Cetola , "Gao, Liming" , "Zeng, Star" , "Yao, Jiewen" Subject: Re: [edk2-devel] [edk2-core] [PATCH v3 1/1] MdeModulePkg: Make retval in UninstallMultipleProtocol follow Spec Thread-Topic: [edk2-devel] [edk2-core] [PATCH v3 1/1] MdeModulePkg: Make retval in UninstallMultipleProtocol follow Spec Thread-Index: AQHVaTQ1KByHyWfaBk6UoNhu41rySqgiepcAgAAx+oCAAPeskA== Date: Wed, 19 Feb 2020 15:43:38 +0000 Message-ID: References: <20190912063406.9477-1-xypron.glpk@gmx.de> <3C0D5C461C9E904E8F62152F6274C0BB40D41D76@SHSMSX104.ccr.corp.intel.com> <37dc6139-c76e-4277-88fa-5a1e0ddd7903@redhat.com> In-Reply-To: <37dc6139-c76e-4277-88fa-5a1e0ddd7903@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTlkNjA5NWItNTUxOC00Yzg1LTg2NWQtODczM2Y4ZDUzNDQ3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoid3FiZTVkSGtYdXI2VzZwNlVWWnlVTjJEaDBKaFQ2TlhMOHlcL05Ya1JRMFZubFgyZUNmcFZVbHhrUG1FMCszU1wvIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jian.j.wang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable It's done (pushed at 0997352ddb4761c49dfedf6fef46b4cd15f6c9bf) Regards, Jian > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Laszlo Er= sek > Sent: Wednesday, February 19, 2020 4:57 PM > To: Bi, Dandan ; Wu, Hao A ; > Wang, Jian J > Cc: devel@edk2.groups.io; xypron.glpk@gmx.de; Jin, Eric ; > Supreeth Venkatesh ; Stephano Cetola > ; Gao, Liming ; Z= eng, > Star ; Yao, Jiewen > Subject: Re: [edk2-devel] [edk2-core] [PATCH v3 1/1] MdeModulePkg: Make > retval in UninstallMultipleProtocol follow Spec >=20 > On 02/19/20 06:58, Dandan Bi wrote: > > This patch seems be reviewed but not submitted. Hope it can be covered= in Q1 > stable tag. >=20 > Should have been merged months ago. >=20 > Jian, Hao, can you pick up this patch now please? >=20 > Thanks > Laszlo >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Heinric= h > Schuchardt > > Sent: Thursday, September 12, 2019 2:34 PM > > To: EDK II Development ; Bi, Dandan > > > Cc: Jin, Eric ; Supreeth Venkatesh > ; Stephano Cetola > ; Wu, Hao A ; Wang, > Jian J ; Gao, Liming ; Zeng= , Star > ; Yao, Jiewen ; Laszlo Ersek > ; Heinrich Schuchardt > > Subject: [edk2-devel] [edk2-core] [PATCH v3 1/1] MdeModulePkg: Make re= tval > in UninstallMultipleProtocol follow Spec > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1869 > > > > The UEFI spec requires that if any error occurs in > UninstallMultipleProtocolInterfaces(), EFI_INVALID_PARAMETER is returned= and > not the return code of UninstallProtocolInterface(). > > > > Signed-off-by: Heinrich Schuchardt > > Reviewed-by: Dandan Bi > > --- > > v3 > > Use @retval instead of @return. > > The protocols are reinstalled in the same order in which they = are > > uninstalled. > > v2 > > =09Adjust the subject line. > > =09Adjust the function comments to clarify the behavior. > > =09This replaces https://edk2.groups.io/g/devel/message/46974 > > --- > > MdeModulePkg/Core/Dxe/Hand/Handle.c | 20 ++++++++++++++------ > > 1 file changed, 14 insertions(+), 6 deletions(-) > > > > diff --git a/MdeModulePkg/Core/Dxe/Hand/Handle.c > b/MdeModulePkg/Core/Dxe/Hand/Handle.c > > index b2721b3ab2..81a13c6ae5 100644 > > --- a/MdeModulePkg/Core/Dxe/Hand/Handle.c > > +++ b/MdeModulePkg/Core/Dxe/Hand/Handle.c > > @@ -802,20 +802,27 @@ Done: > > - /** Uninstalls a list of protocol interface in the boot service= s > environment.- This function calls UnisatllProtocolInterface() in a loop= . This is+ > This function calls UninstallProtocolInterface() in a loop. This is ba= sically a lib > function to save space. - @param Handle The handle to = uninstall the > protocol+ If any errors are generated while the protocol interfaces are= being+ > uninstalled, then the protocol interfaces uninstalled prior to the error= will+ be > reinstalled and EFI_INVALID_PARAMETER will be returned.++ @param Handl= e > The handle to uninstall the protocol interfaces+ = from. > @param ... EFI_GUID followed by protocol instance. A= NULL- > terminates the list. The pairs are the+ = terminates the list. The > pairs are the arguments to UninstallPro= tocolInterface(). All > the protocols are added to Handle. - @return Status code-+ @retval > EFI_SUCCESS if all protocol interfaces where uninstalled.+ @= retval > EFI_INVALID_PARAMETER if any protocol interface could not be+ > uninstalled and an attempt was made to+ = reinstall previously > uninstalled protocol+ interfaces. **/ EF= I_STATUS EFIAPI@@ - > 864,6 +871,7 @@ CoreUninstallMultipleProtocolInterfaces ( > > CoreInstallProtocolInterface (&Handle, Protocol, EFI_NATIVE_INT= ERFACE, > Interface); } VA_END (Args);+ Status =3D EFI_INVALID_PARAMETE= R; } > return Status;-- > > 2.20.1 > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > Groups.io Links: You receive all messages sent to this group. > > > > View/Reply Online (#47177): https://edk2.groups.io/g/devel/message/471= 77 > > Mute This Topic: https://groups.io/mt/34112406/1768738 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub [dandan.bi@intel.co= m] - > =3D-=3D-=3D-=3D-=3D-=3D > > > > > > > > >=20 >=20 >=20