From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web12.4407.1583992697658480176 for ; Wed, 11 Mar 2020 22:58:18 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: jian.j.wang@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Mar 2020 22:58:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,543,1574150400"; d="scan'208";a="236707547" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga008.jf.intel.com with ESMTP; 11 Mar 2020 22:58:16 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 11 Mar 2020 22:58:16 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 11 Mar 2020 22:58:15 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 11 Mar 2020 22:58:15 -0700 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.232]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.235]) with mapi id 14.03.0439.000; Thu, 12 Mar 2020 13:58:06 +0800 From: "Wang, Jian J" To: "devel@edk2.groups.io" , "Bi, Dandan" , Daniel Schaefer CC: Abner Chang , Gilbert Chen , Leif Lindholm , "Dong, Eric" Subject: Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment Thread-Topic: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment Thread-Index: AQHV8H4EBi82wLfAKUiIO7icPHfZ6Kg4pg0AgAvfNmA= Date: Thu, 12 Mar 2020 05:58:05 +0000 Message-ID: References: <20200302103238.25726-1-daniel.schaefer@hpe.com> <20200302103238.25726-4-daniel.schaefer@hpe.com> <3C0D5C461C9E904E8F62152F6274C0BB40D6BDA4@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <3C0D5C461C9E904E8F62152F6274C0BB40D6BDA4@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jian.j.wang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed @ 64a228f5f89320fd632bb6c55e154961f2410680 Regards, Jian > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Dandan Bi > Sent: Thursday, March 05, 2020 8:40 AM > To: Daniel Schaefer ; devel@edk2.groups.io > Cc: Abner Chang ; Gilbert Chen > ; Leif Lindholm ; Dong, Eric > > Subject: Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem > instead of GUID assignment >=20 > Reviewed-by: Dandan Bi >=20 >=20 > Thanks, > Dandan > > -----Original Message----- > > From: Daniel Schaefer [mailto:daniel.schaefer@hpe.com] > > Sent: Monday, March 2, 2020 6:33 PM > > To: devel@edk2.groups.io > > Cc: Abner Chang ; Gilbert Chen > > ; Leif Lindholm ; Bi, Dandan > > ; Dong, Eric > > Subject: [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID > > assignment > > > > GCC translates a simple assignment to memcpy, which EDKII doesn't prov= ide. > > See: https://www.mail-archive.com/edk2-devel@lists.01.org/msg11928.htm= l > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2547 > > > > Signed-off-by: Daniel Schaefer > > Cc: Abner Chang > > Cc: Gilbert Chen > > Cc: Leif Lindholm > > Cc: Dandan Bi > > Cc: Eric Dong > > --- > > > > Notes: > > v2: > > - Use CopyMem instead of CopyGuid [Dandan] > > > > MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c > > b/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c > > index 5cc527679a78..0540e6fa8a44 100644 > > --- a/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c > > +++ b/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c > > @@ -619,7 +619,7 @@ CreateDeviceManagerForm( > > TokenHelp =3D HiiSetString (HiiHandle, 0, String, NULL); > > > > FreePool (String); > > > > > > > > - FormSetGuid =3D ((EFI_IFR_FORM_SET *)Ptr)->Guid; > > > > + CopyMem (&FormSetGuid, &((EFI_IFR_FORM_SET *) Ptr)->Guid, siz= eof > > (EFI_GUID)); > > > > > > > > // > > > > // Network device process > > > > -- > > 2.25.0 >=20 >=20 >=20