From: "Wang, Jian J" <jian.j.wang@intel.com>
To: Michael Kubacki <michael.kubacki@outlook.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
"Zhang, Chao B" <chao.b.zhang@intel.com>,
"Mistry, Nishant C" <nishant.c.mistry@intel.com>
Subject: Re: [edk2-devel] [PATCH v5 0/3] Add RpmcLib and VariableKeyLib
Date: Fri, 27 Mar 2020 01:45:49 +0000 [thread overview]
Message-ID: <D827630B58408649ACB04F44C510003625A335BA@SHSMSX107.ccr.corp.intel.com> (raw)
In-Reply-To: <MWHPR07MB344023C0561C02525749FF76E9CF0@MWHPR07MB3440.namprd07.prod.outlook.com>
Michael,
Good to see you "back"😊 and thanks for the review.
Regards,
Jian
> -----Original Message-----
> From: Michael Kubacki <michael.kubacki@outlook.com>
> Sent: Friday, March 27, 2020 1:25 AM
> To: devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Zhang, Chao B
> <chao.b.zhang@intel.com>; Mistry, Nishant C <nishant.c.mistry@intel.com>
> Subject: Re: [edk2-devel] [PATCH v5 0/3] Add RpmcLib and VariableKeyLib
>
> For the series:
>
> Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>
>
> On 3/26/2020 12:49 AM, Wang, Jian J wrote:
> >> v5: change VariableRootKey to VariableKey
> >
> >> v4: remove CounterId which should not be exposed
> >
> >> v3: update retval description in RpmcLib.h and RpmcLibNull.c
> >
> >> v2: change CounterIndex to CounterId in RpmcLib prototype.
> >
> >
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
> >
> > Patch branch: https://github.com/jwang36/edk2/tree/bz2594-part1-common-
> interfaces-between-platform-and-edk2-v5
> >
> >
> >
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> >
> > Cc: Chao Zhang <chao.b.zhang@intel.com>
> >
> > Cc: Nishant C Mistry <nishant.c.mistry@intel.com>
> >
> > Jian J Wang (3):
> > SecurityPkg: add RpmcLib and VariableKeyLib public headers
> > SecurityPkg: add null version of RpmcLib
> > SecurityPkg: add null version of VariableKeyLib
> >
> > SecurityPkg/Include/Library/RpmcLib.h | 42 ++++++++++++
> > SecurityPkg/Include/Library/VariableKeyLib.h | 59 ++++++++++++++++
> > SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c | 47 +++++++++++++
> > .../Library/RpmcLibNull/RpmcLibNull.inf | 33 +++++++++
> > .../VariableKeyLibNull/VariableKeyLibNull.c | 67 +++++++++++++++++++
> > .../VariableKeyLibNull/VariableKeyLibNull.inf | 33 +++++++++
> > SecurityPkg/SecurityPkg.dec | 8 +++
> > SecurityPkg/SecurityPkg.dsc | 8 +++
> > 8 files changed, 297 insertions(+)
> > create mode 100644 SecurityPkg/Include/Library/RpmcLib.h
> > create mode 100644 SecurityPkg/Include/Library/VariableKeyLib.h
> > create mode 100644 SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c
> > create mode 100644 SecurityPkg/Library/RpmcLibNull/RpmcLibNull.inf
> > create mode 100644
> SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c
> > create mode 100644
> SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.inf
> >
next prev parent reply other threads:[~2020-03-27 1:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 7:49 [PATCH v5 0/3] Add RpmcLib and VariableKeyLib Wang, Jian J
2020-03-26 7:49 ` [PATCH v5 1/3] SecurityPkg: add RpmcLib and VariableKeyLib public headers Wang, Jian J
2020-03-26 7:49 ` [PATCH v5 2/3] SecurityPkg: add null version of RpmcLib Wang, Jian J
2020-03-26 7:49 ` [PATCH v5 3/3] SecurityPkg: add null version of VariableKeyLib Wang, Jian J
2020-03-26 17:24 ` [edk2-devel] [PATCH v5 0/3] Add RpmcLib and VariableKeyLib Michael Kubacki
2020-03-27 1:45 ` Wang, Jian J [this message]
2020-03-27 1:48 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D827630B58408649ACB04F44C510003625A335BA@SHSMSX107.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox