From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.6350.1589377729888164918 for ; Wed, 13 May 2020 06:48:50 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: jian.j.wang@intel.com) IronPort-SDR: 5lAWEp0PDMb3NACtd8DuPR2ZxQIxK+5u/tRYbx9cHHdXu4sVUFphhv8d4S0U4ryWjpnV0azZZk j1pHeg0ePB2A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2020 06:48:49 -0700 IronPort-SDR: CQB0DHNvfkDwYDGllS/PocTKSqFL6tbnIJ3gn/fS8xSvAp+8yAU5Stu3XGC5S4J8rVYF2dgZpu DExMeMBwdNfw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,387,1583222400"; d="scan'208";a="251254688" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga007.jf.intel.com with ESMTP; 13 May 2020 06:48:48 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 06:48:48 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 06:48:48 -0700 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.110]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.34]) with mapi id 14.03.0439.000; Wed, 13 May 2020 21:48:45 +0800 From: "Wang, Jian J" To: "Gao, Zhichao" , "devel@edk2.groups.io" , "Fu, Siyuan" , "Kinney, Michael D" , "Yao, Jiewen" , Philippe Mathieu-Daude , "Lu, XiaoyuX" Subject: Re: [PATCH V4 00/11] CryptoPkg: Retire the deprecated functions Thread-Topic: [PATCH V4 00/11] CryptoPkg: Retire the deprecated functions Thread-Index: AQHWJ8Ha/KDxt/qdI0iHRyvCNDz8pKimCmNg Date: Wed, 13 May 2020 13:48:45 +0000 Message-ID: References: <20200511182718.7728-1-zhichao.gao@intel.com> In-Reply-To: <20200511182718.7728-1-zhichao.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jian.j.wang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Zhichao, Two general comments for improvement needed in your future patches: 1. Add r-b for those patch files which have got r-b 2. It'd be better to add summary of changes between this and previous versi= on of patches For v4, patch 8: the updates of OpensslLib should be done by process_files.pl With this addressed (for the whole patch series), Reviewed-by: Jian J Wang Mike, Jiewen, Siyuan, Philippe: any more comments for v4? Regards, Jian > -----Original Message----- > From: Gao, Zhichao > Sent: Tuesday, May 12, 2020 2:27 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, XiaoyuX ; > Fu, Siyuan ; Kinney, Michael D > ; Yao, Jiewen ; Philipp= e > Mathieu-Daude > Subject: [PATCH V4 00/11] CryptoPkg: Retire the deprecated functions >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1898 >=20 > Retire below deprecated functions: > MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1. >=20 > V2: > Seprate the MD5 and SHA1 changes to other patch set. > Change the deprecated function wrapper implementatuion in > EDKII_CRYPTO_PROTOCOL to call a dummy function to print debug > message and assert. >=20 > V3: > Remove the missing part of deprecated functions in V2. > Change the name field in the EDKII_CRYPTO_PROTOCOL to indicate > the function is deprecated and unsupported. >=20 > V4: > Fixed some typos. > Separate the change of OpensslLib and make the change with > process_files.pl. > Moving the incorrect changes of AES_ECB from HAMC MD5 patch > to Aes Ecb one. >=20 > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Siyuan Fu > Cc: Michael D Kinney > Cc: Jiewen Yao > Cc: Philippe Mathieu-Daude > Signed-off-by: Zhichao Gao >=20 > Zhichao Gao (8): > CryptoPkg/CryptoDxe: Add function to indicate the deprecated algorithm > CryptoPkg/BaseCrpytLib: Retire MD4 algorithm > CryptoPkg/BaseCryptLib: Retire ARC4 algorithm > CryptoPkg/BaseCryptLib: Retire the Tdes algorithm > CryptoPkg/BaseCryptLib: Retire Aes Ecb mode algorithm > CryptoPkg/BaseCryptLib: Retire HMAC MD5 algorithm > CryptoPkg/BaseCryptLib: Retire HMAC SHA1 algorithm > CryptoPkg/Crypto.h: Update the version of Crypto Driver >=20 > Zhiguang Liu (3): > CryptoPkg/OpensslLib: Set MD4 disable in OpensslLib > CryptoPkg/OpensslLib: Set ARC4 disable in OpensslLib > CryptoPkg/OpensslLib: Set TDES disable in OpensslLib >=20 > CryptoPkg/CryptoPkg.dsc | 46 +- > CryptoPkg/Driver/Crypto.c | 786 ++--------- > CryptoPkg/Include/Library/BaseCryptLib.h | 809 ------------ > .../Library/BaseCryptLib/BaseCryptLib.inf | 7 +- > .../Library/BaseCryptLib/Cipher/CryptAes.c | 114 -- > .../BaseCryptLib/Cipher/CryptAesNull.c | 52 - > .../Library/BaseCryptLib/Cipher/CryptArc4.c | 205 --- > .../BaseCryptLib/Cipher/CryptArc4Null.c | 124 -- > .../Library/BaseCryptLib/Cipher/CryptTdes.c | 364 ------ > .../BaseCryptLib/Cipher/CryptTdesNull.c | 160 --- > .../Library/BaseCryptLib/Hash/CryptMd4.c | 223 ---- > .../Library/BaseCryptLib/Hash/CryptMd4Null.c | 143 -- > .../Library/BaseCryptLib/Hmac/CryptHmacMd5.c | 216 --- > .../BaseCryptLib/Hmac/CryptHmacMd5Null.c | 139 -- > .../Library/BaseCryptLib/Hmac/CryptHmacSha1.c | 216 --- > .../BaseCryptLib/Hmac/CryptHmacSha1Null.c | 139 -- > .../Library/BaseCryptLib/PeiCryptLib.inf | 11 +- > .../Library/BaseCryptLib/PeiCryptLib.uni | 8 +- > CryptoPkg/Library/BaseCryptLib/Pem/CryptPem.c | 7 +- > .../Library/BaseCryptLib/RuntimeCryptLib.inf | 11 +- > .../Library/BaseCryptLib/RuntimeCryptLib.uni | 8 +- > .../Library/BaseCryptLib/SmmCryptLib.inf | 12 +- > .../Library/BaseCryptLib/SmmCryptLib.uni | 8 +- > .../BaseCryptLibNull/BaseCryptLibNull.inf | 5 - > .../BaseCryptLibNull/Cipher/CryptAesNull.c | 52 - > .../BaseCryptLibNull/Cipher/CryptArc4Null.c | 124 -- > .../BaseCryptLibNull/Cipher/CryptTdesNull.c | 160 --- > .../BaseCryptLibNull/Hash/CryptMd4Null.c | 143 -- > .../BaseCryptLibNull/Hmac/CryptHmacMd5Null.c | 139 -- > .../BaseCryptLibNull/Hmac/CryptHmacSha1Null.c | 139 -- > .../BaseCryptLibOnProtocolPpi/CryptLib.c | 1157 ++--------------- > .../Library/Include/openssl/opensslconf.h | 9 + > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 28 - > .../Library/OpensslLib/OpensslLibCrypto.inf | 28 - > CryptoPkg/Library/OpensslLib/process_files.pl | 3 + > CryptoPkg/Private/Protocol/Crypto.h | 709 ++-------- > 36 files changed, 402 insertions(+), 6102 deletions(-) > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptArc4.c > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptArc4Null.c > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptTdes.c > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptTdesNull.c > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4.c > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4Null.c > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5Null.c > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha1.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha1Null.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptArc4Null.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptTdesNull.c > delete mode 100644 CryptoPkg/Library/BaseCryptLibNull/Hash/CryptMd4Null.= c > delete mode 100644 > CryptoPkg/Library/BaseCryptLibNull/Hmac/CryptHmacMd5Null.c > delete mode 100644 > CryptoPkg/Library/BaseCryptLibNull/Hmac/CryptHmacSha1Null.c >=20 > -- > 2.21.0.windows.1