From: "Wang, Jian J" <jian.j.wang@intel.com>
To: "Gao, Zhichao" <zhichao.gao@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Fu, Siyuan" <siyuan.fu@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
Philippe Mathieu-Daude <philmd@redhat.com>,
"Lu, XiaoyuX" <xiaoyux.lu@intel.com>
Subject: Re: [PATCH V4 00/11] CryptoPkg: Retire the deprecated functions
Date: Thu, 14 May 2020 05:11:37 +0000 [thread overview]
Message-ID: <D827630B58408649ACB04F44C510003625A95924@SHSMSX107.ccr.corp.intel.com> (raw)
In-Reply-To: <DM6PR11MB4425BE611F669C007F3DDB87F6BC0@DM6PR11MB4425.namprd11.prod.outlook.com>
Zhichao
> -----Original Message-----
> From: Gao, Zhichao <zhichao.gao@intel.com>
> Sent: Thursday, May 14, 2020 10:49 AM
> To: Wang, Jian J <jian.j.wang@intel.com>; devel@edk2.groups.io; Fu, Siyuan
> <siyuan.fu@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Yao,
> Jiewen <jiewen.yao@intel.com>; Philippe Mathieu-Daude
> <philmd@redhat.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>
> Subject: RE: [PATCH V4 00/11] CryptoPkg: Retire the deprecated functions
>
>
> > -----Original Message-----
> > From: Wang, Jian J <jian.j.wang@intel.com>
> > Sent: Wednesday, May 13, 2020 9:49 PM
> > To: Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io; Fu, Siyuan
> > <siyuan.fu@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Yao,
> > Jiewen <jiewen.yao@intel.com>; Philippe Mathieu-Daude
> <philmd@redhat.com>;
> > Lu, XiaoyuX <xiaoyux.lu@intel.com>
> > Subject: RE: [PATCH V4 00/11] CryptoPkg: Retire the deprecated functions
> >
> > Zhichao,
> >
> > Two general comments for improvement needed in your future patches:
> > 1. Add r-b for those patch files which have got r-b 2. It'd be better to add
> > summary of changes between this and previous version
> > of patches
>
> 1. I change the typo of the function definition. So all the patches are changed.
> That is why I didn't keep any R-B
> 2. I put the summary change in cover-letter. Thanks for the suggestion. I would
> put the changes for every patch but not put them in the commit message.
>
> >
> > For v4,
> > patch 8: the updates of OpensslLib should be done by process_files.pl
>
> I didn't find the config string to disable the AES ECB mode only. Can you help
> guide me on this? Or should I remove the change of OpensslLib in patch #8?
You can remove those files from .inf by excluding them from @cryptofilelist
and @sslfilelist in process_files.pl. Don't manually remove anything from
autogenerated content in inf file.
Regards,
Jian
>
> Thanks,
> Zhichao
>
> >
> > With this addressed (for the whole patch series),
> >
> > Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
> >
> >
> > Mike, Jiewen, Siyuan, Philippe: any more comments for v4?
> >
> > Regards,
> > Jian
> >
> > > -----Original Message-----
> > > From: Gao, Zhichao <zhichao.gao@intel.com>
> > > Sent: Tuesday, May 12, 2020 2:27 AM
> > > To: devel@edk2.groups.io
> > > Cc: Wang, Jian J <jian.j.wang@intel.com>; Lu, XiaoyuX
> > > <xiaoyux.lu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Kinney,
> > > Michael D <michael.d.kinney@intel.com>; Yao, Jiewen
> > > <jiewen.yao@intel.com>; Philippe Mathieu-Daude <philmd@redhat.com>
> > > Subject: [PATCH V4 00/11] CryptoPkg: Retire the deprecated functions
> > >
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
> > >
> > > Retire below deprecated functions:
> > > MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1.
> > >
> > > V2:
> > > Seprate the MD5 and SHA1 changes to other patch set.
> > > Change the deprecated function wrapper implementatuion in
> > > EDKII_CRYPTO_PROTOCOL to call a dummy function to print debug message
> > > and assert.
> > >
> > > V3:
> > > Remove the missing part of deprecated functions in V2.
> > > Change the name field in the EDKII_CRYPTO_PROTOCOL to indicate the
> > > function is deprecated and unsupported.
> > >
> > > V4:
> > > Fixed some typos.
> > > Separate the change of OpensslLib and make the change with
> > > process_files.pl.
> > > Moving the incorrect changes of AES_ECB from HAMC MD5 patch to Aes Ecb
> > > one.
> > >
> > > Cc: Jian J Wang <jian.j.wang@intel.com>
> > > Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> > > Cc: Siyuan Fu <siyuan.fu@intel.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > > Cc: Philippe Mathieu-Daude <philmd@redhat.com>
> > > Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> > >
> > > Zhichao Gao (8):
> > > CryptoPkg/CryptoDxe: Add function to indicate the deprecated algorithm
> > > CryptoPkg/BaseCrpytLib: Retire MD4 algorithm
> > > CryptoPkg/BaseCryptLib: Retire ARC4 algorithm
> > > CryptoPkg/BaseCryptLib: Retire the Tdes algorithm
> > > CryptoPkg/BaseCryptLib: Retire Aes Ecb mode algorithm
> > > CryptoPkg/BaseCryptLib: Retire HMAC MD5 algorithm
> > > CryptoPkg/BaseCryptLib: Retire HMAC SHA1 algorithm
> > > CryptoPkg/Crypto.h: Update the version of Crypto Driver
> > >
> > > Zhiguang Liu (3):
> > > CryptoPkg/OpensslLib: Set MD4 disable in OpensslLib
> > > CryptoPkg/OpensslLib: Set ARC4 disable in OpensslLib
> > > CryptoPkg/OpensslLib: Set TDES disable in OpensslLib
> > >
> > > CryptoPkg/CryptoPkg.dsc | 46 +-
> > > CryptoPkg/Driver/Crypto.c | 786 ++---------
> > > CryptoPkg/Include/Library/BaseCryptLib.h | 809 ------------
> > > .../Library/BaseCryptLib/BaseCryptLib.inf | 7 +-
> > > .../Library/BaseCryptLib/Cipher/CryptAes.c | 114 --
> > > .../BaseCryptLib/Cipher/CryptAesNull.c | 52 -
> > > .../Library/BaseCryptLib/Cipher/CryptArc4.c | 205 ---
> > > .../BaseCryptLib/Cipher/CryptArc4Null.c | 124 --
> > > .../Library/BaseCryptLib/Cipher/CryptTdes.c | 364 ------
> > > .../BaseCryptLib/Cipher/CryptTdesNull.c | 160 ---
> > > .../Library/BaseCryptLib/Hash/CryptMd4.c | 223 ----
> > > .../Library/BaseCryptLib/Hash/CryptMd4Null.c | 143 --
> > > .../Library/BaseCryptLib/Hmac/CryptHmacMd5.c | 216 ---
> > > .../BaseCryptLib/Hmac/CryptHmacMd5Null.c | 139 --
> > > .../Library/BaseCryptLib/Hmac/CryptHmacSha1.c | 216 ---
> > > .../BaseCryptLib/Hmac/CryptHmacSha1Null.c | 139 --
> > > .../Library/BaseCryptLib/PeiCryptLib.inf | 11 +-
> > > .../Library/BaseCryptLib/PeiCryptLib.uni | 8 +-
> > > CryptoPkg/Library/BaseCryptLib/Pem/CryptPem.c | 7 +-
> > > .../Library/BaseCryptLib/RuntimeCryptLib.inf | 11 +-
> > > .../Library/BaseCryptLib/RuntimeCryptLib.uni | 8 +-
> > > .../Library/BaseCryptLib/SmmCryptLib.inf | 12 +-
> > > .../Library/BaseCryptLib/SmmCryptLib.uni | 8 +-
> > > .../BaseCryptLibNull/BaseCryptLibNull.inf | 5 -
> > > .../BaseCryptLibNull/Cipher/CryptAesNull.c | 52 -
> > > .../BaseCryptLibNull/Cipher/CryptArc4Null.c | 124 --
> > > .../BaseCryptLibNull/Cipher/CryptTdesNull.c | 160 ---
> > > .../BaseCryptLibNull/Hash/CryptMd4Null.c | 143 --
> > > .../BaseCryptLibNull/Hmac/CryptHmacMd5Null.c | 139 --
> > > .../BaseCryptLibNull/Hmac/CryptHmacSha1Null.c | 139 --
> > > .../BaseCryptLibOnProtocolPpi/CryptLib.c | 1157 ++---------------
> > > .../Library/Include/openssl/opensslconf.h | 9 +
> > > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 28 -
> > > .../Library/OpensslLib/OpensslLibCrypto.inf | 28 -
> > > CryptoPkg/Library/OpensslLib/process_files.pl | 3 +
> > > CryptoPkg/Private/Protocol/Crypto.h | 709 ++--------
> > > 36 files changed, 402 insertions(+), 6102 deletions(-) delete mode
> > > 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptArc4.c
> > > delete mode 100644
> > > CryptoPkg/Library/BaseCryptLib/Cipher/CryptArc4Null.c
> > > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptTdes.c
> > > delete mode 100644
> > > CryptoPkg/Library/BaseCryptLib/Cipher/CryptTdesNull.c
> > > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4.c
> > > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4Null.c
> > > delete mode 100644
> CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5.c
> > > delete mode 100644
> > > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5Null.c
> > > delete mode 100644
> > > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha1.c
> > > delete mode 100644
> > > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha1Null.c
> > > delete mode 100644
> > > CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptArc4Null.c
> > > delete mode 100644
> > > CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptTdesNull.c
> > > delete mode 100644
> > > CryptoPkg/Library/BaseCryptLibNull/Hash/CryptMd4Null.c
> > > delete mode 100644
> > > CryptoPkg/Library/BaseCryptLibNull/Hmac/CryptHmacMd5Null.c
> > > delete mode 100644
> > > CryptoPkg/Library/BaseCryptLibNull/Hmac/CryptHmacSha1Null.c
> > >
> > > --
> > > 2.21.0.windows.1
> >
>
next prev parent reply other threads:[~2020-05-14 5:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 18:27 [PATCH V4 00/11] CryptoPkg: Retire the deprecated functions Gao, Zhichao
2020-05-11 18:27 ` [PATCH V4 01/11] CryptoPkg/CryptoDxe: Add function to indicate the deprecated algorithm Gao, Zhichao
2020-05-11 18:27 ` [PATCH V4 02/11] CryptoPkg/BaseCrpytLib: Retire MD4 algorithm Gao, Zhichao
2020-05-14 3:13 ` [edk2-devel] " Guomin Jiang
2020-05-14 5:58 ` Gao, Zhichao
2020-05-11 18:27 ` [PATCH V4 03/11] CryptoPkg/OpensslLib: Set MD4 disable in OpensslLib Gao, Zhichao
2020-05-11 18:27 ` [PATCH V4 04/11] CryptoPkg/BaseCryptLib: Retire ARC4 algorithm Gao, Zhichao
2020-05-11 18:27 ` [PATCH V4 05/11] CryptoPkg/OpensslLib: Set ARC4 disable in OpensslLib Gao, Zhichao
2020-05-11 18:27 ` [PATCH V4 06/11] CryptoPkg/BaseCryptLib: Retire the TDES algorithm Gao, Zhichao
2020-05-11 18:27 ` [PATCH V4 07/11] CryptoPkg/OpensslLib: Set TDES disable in OpensslLib Gao, Zhichao
2020-05-11 18:27 ` [PATCH V4 08/11] CryptoPkg/BaseCryptLib: Retire Aes Ecb mode algorithm Gao, Zhichao
2020-05-11 18:27 ` [PATCH V4 09/11] CryptoPkg/BaseCryptLib: Retire HMAC MD5 algorithm Gao, Zhichao
2020-05-11 18:27 ` [PATCH V4 10/11] CryptoPkg/BaseCryptLib: Retire HMAC SHA1 algorithm Gao, Zhichao
2020-05-11 18:27 ` [PATCH V4 11/11] CryptoPkg/Crypto.h: Update the version of Crypto Driver Gao, Zhichao
2020-05-13 13:48 ` [PATCH V4 00/11] CryptoPkg: Retire the deprecated functions Wang, Jian J
2020-05-14 2:49 ` Gao, Zhichao
2020-05-14 5:11 ` Wang, Jian J [this message]
2020-05-14 6:14 ` Gao, Zhichao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D827630B58408649ACB04F44C510003625A95924@SHSMSX107.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox