From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.6849.1589433104328302800 for ; Wed, 13 May 2020 22:11:44 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: jian.j.wang@intel.com) IronPort-SDR: qh1to1u93PPWm29CP4DPNS7xvx84FrKWXQxQi+Kir2Ls31mY04sK1xcOBwavUYVlliuSbqIovX eZZLoq2/U3Bw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2020 22:11:43 -0700 IronPort-SDR: 2qn0IVr0gbDn9tk88RGWVB0XgB98AO5qZgR9wy+W2syfXarvJjBvzWhz/+UWGMRlp1MQ1CvMyn 9fM0iye7dm0g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,390,1583222400"; d="scan'208";a="287282996" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 13 May 2020 22:11:43 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 22:11:43 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 22:11:43 -0700 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.110]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.178]) with mapi id 14.03.0439.000; Thu, 14 May 2020 13:11:38 +0800 From: "Wang, Jian J" To: "Gao, Zhichao" , "devel@edk2.groups.io" , "Fu, Siyuan" , "Kinney, Michael D" , "Yao, Jiewen" , Philippe Mathieu-Daude , "Lu, XiaoyuX" Subject: Re: [PATCH V4 00/11] CryptoPkg: Retire the deprecated functions Thread-Topic: [PATCH V4 00/11] CryptoPkg: Retire the deprecated functions Thread-Index: AQHWJ8Ha/KDxt/qdI0iHRyvCNDz8pKimCmNggADVUoCAACuSgA== Date: Thu, 14 May 2020 05:11:37 +0000 Message-ID: References: <20200511182718.7728-1-zhichao.gao@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: jian.j.wang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Zhichao > -----Original Message----- > From: Gao, Zhichao > Sent: Thursday, May 14, 2020 10:49 AM > To: Wang, Jian J ; devel@edk2.groups.io; Fu, Siyua= n > ; Kinney, Michael D ; Ya= o, > Jiewen ; Philippe Mathieu-Daude > ; Lu, XiaoyuX > Subject: RE: [PATCH V4 00/11] CryptoPkg: Retire the deprecated functions >=20 >=20 > > -----Original Message----- > > From: Wang, Jian J > > Sent: Wednesday, May 13, 2020 9:49 PM > > To: Gao, Zhichao ; devel@edk2.groups.io; Fu, Siy= uan > > ; Kinney, Michael D ; = Yao, > > Jiewen ; Philippe Mathieu-Daude > ; > > Lu, XiaoyuX > > Subject: RE: [PATCH V4 00/11] CryptoPkg: Retire the deprecated function= s > > > > Zhichao, > > > > Two general comments for improvement needed in your future patches: > > 1. Add r-b for those patch files which have got r-b 2. It'd be better t= o add > > summary of changes between this and previous version > > of patches >=20 > 1. I change the typo of the function definition. So all the patches are c= hanged. > That is why I didn't keep any R-B > 2. I put the summary change in cover-letter. Thanks for the suggestion. I= would > put the changes for every patch but not put them in the commit message. >=20 > > > > For v4, > > patch 8: the updates of OpensslLib should be done by process_files.= pl >=20 > I didn't find the config string to disable the AES ECB mode only. Can you= help > guide me on this? Or should I remove the change of OpensslLib in patch #8= ? You can remove those files from .inf by excluding them from @cryptofilelist and @sslfilelist in process_files.pl. Don't manually remove anything from=20 autogenerated content in inf file. Regards, Jian >=20 > Thanks, > Zhichao >=20 > > > > With this addressed (for the whole patch series), > > > > Reviewed-by: Jian J Wang > > > > > > Mike, Jiewen, Siyuan, Philippe: any more comments for v4? > > > > Regards, > > Jian > > > > > -----Original Message----- > > > From: Gao, Zhichao > > > Sent: Tuesday, May 12, 2020 2:27 AM > > > To: devel@edk2.groups.io > > > Cc: Wang, Jian J ; Lu, XiaoyuX > > > ; Fu, Siyuan ; Kinney, > > > Michael D ; Yao, Jiewen > > > ; Philippe Mathieu-Daude > > > Subject: [PATCH V4 00/11] CryptoPkg: Retire the deprecated functions > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1898 > > > > > > Retire below deprecated functions: > > > MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1. > > > > > > V2: > > > Seprate the MD5 and SHA1 changes to other patch set. > > > Change the deprecated function wrapper implementatuion in > > > EDKII_CRYPTO_PROTOCOL to call a dummy function to print debug message > > > and assert. > > > > > > V3: > > > Remove the missing part of deprecated functions in V2. > > > Change the name field in the EDKII_CRYPTO_PROTOCOL to indicate the > > > function is deprecated and unsupported. > > > > > > V4: > > > Fixed some typos. > > > Separate the change of OpensslLib and make the change with > > > process_files.pl. > > > Moving the incorrect changes of AES_ECB from HAMC MD5 patch to Aes Ec= b > > > one. > > > > > > Cc: Jian J Wang > > > Cc: Xiaoyu Lu > > > Cc: Siyuan Fu > > > Cc: Michael D Kinney > > > Cc: Jiewen Yao > > > Cc: Philippe Mathieu-Daude > > > Signed-off-by: Zhichao Gao > > > > > > Zhichao Gao (8): > > > CryptoPkg/CryptoDxe: Add function to indicate the deprecated algori= thm > > > CryptoPkg/BaseCrpytLib: Retire MD4 algorithm > > > CryptoPkg/BaseCryptLib: Retire ARC4 algorithm > > > CryptoPkg/BaseCryptLib: Retire the Tdes algorithm > > > CryptoPkg/BaseCryptLib: Retire Aes Ecb mode algorithm > > > CryptoPkg/BaseCryptLib: Retire HMAC MD5 algorithm > > > CryptoPkg/BaseCryptLib: Retire HMAC SHA1 algorithm > > > CryptoPkg/Crypto.h: Update the version of Crypto Driver > > > > > > Zhiguang Liu (3): > > > CryptoPkg/OpensslLib: Set MD4 disable in OpensslLib > > > CryptoPkg/OpensslLib: Set ARC4 disable in OpensslLib > > > CryptoPkg/OpensslLib: Set TDES disable in OpensslLib > > > > > > CryptoPkg/CryptoPkg.dsc | 46 +- > > > CryptoPkg/Driver/Crypto.c | 786 ++--------- > > > CryptoPkg/Include/Library/BaseCryptLib.h | 809 ------------ > > > .../Library/BaseCryptLib/BaseCryptLib.inf | 7 +- > > > .../Library/BaseCryptLib/Cipher/CryptAes.c | 114 -- > > > .../BaseCryptLib/Cipher/CryptAesNull.c | 52 - > > > .../Library/BaseCryptLib/Cipher/CryptArc4.c | 205 --- > > > .../BaseCryptLib/Cipher/CryptArc4Null.c | 124 -- > > > .../Library/BaseCryptLib/Cipher/CryptTdes.c | 364 ------ > > > .../BaseCryptLib/Cipher/CryptTdesNull.c | 160 --- > > > .../Library/BaseCryptLib/Hash/CryptMd4.c | 223 ---- > > > .../Library/BaseCryptLib/Hash/CryptMd4Null.c | 143 -- > > > .../Library/BaseCryptLib/Hmac/CryptHmacMd5.c | 216 --- > > > .../BaseCryptLib/Hmac/CryptHmacMd5Null.c | 139 -- > > > .../Library/BaseCryptLib/Hmac/CryptHmacSha1.c | 216 --- > > > .../BaseCryptLib/Hmac/CryptHmacSha1Null.c | 139 -- > > > .../Library/BaseCryptLib/PeiCryptLib.inf | 11 +- > > > .../Library/BaseCryptLib/PeiCryptLib.uni | 8 +- > > > CryptoPkg/Library/BaseCryptLib/Pem/CryptPem.c | 7 +- > > > .../Library/BaseCryptLib/RuntimeCryptLib.inf | 11 +- > > > .../Library/BaseCryptLib/RuntimeCryptLib.uni | 8 +- > > > .../Library/BaseCryptLib/SmmCryptLib.inf | 12 +- > > > .../Library/BaseCryptLib/SmmCryptLib.uni | 8 +- > > > .../BaseCryptLibNull/BaseCryptLibNull.inf | 5 - > > > .../BaseCryptLibNull/Cipher/CryptAesNull.c | 52 - > > > .../BaseCryptLibNull/Cipher/CryptArc4Null.c | 124 -- > > > .../BaseCryptLibNull/Cipher/CryptTdesNull.c | 160 --- > > > .../BaseCryptLibNull/Hash/CryptMd4Null.c | 143 -- > > > .../BaseCryptLibNull/Hmac/CryptHmacMd5Null.c | 139 -- > > > .../BaseCryptLibNull/Hmac/CryptHmacSha1Null.c | 139 -- > > > .../BaseCryptLibOnProtocolPpi/CryptLib.c | 1157 ++-------------= -- > > > .../Library/Include/openssl/opensslconf.h | 9 + > > > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 28 - > > > .../Library/OpensslLib/OpensslLibCrypto.inf | 28 - > > > CryptoPkg/Library/OpensslLib/process_files.pl | 3 + > > > CryptoPkg/Private/Protocol/Crypto.h | 709 ++-------- > > > 36 files changed, 402 insertions(+), 6102 deletions(-) delete mode > > > 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptArc4.c > > > delete mode 100644 > > > CryptoPkg/Library/BaseCryptLib/Cipher/CryptArc4Null.c > > > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptTdes.c > > > delete mode 100644 > > > CryptoPkg/Library/BaseCryptLib/Cipher/CryptTdesNull.c > > > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4.c > > > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4Null.= c > > > delete mode 100644 > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5.c > > > delete mode 100644 > > > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5Null.c > > > delete mode 100644 > > > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha1.c > > > delete mode 100644 > > > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha1Null.c > > > delete mode 100644 > > > CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptArc4Null.c > > > delete mode 100644 > > > CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptTdesNull.c > > > delete mode 100644 > > > CryptoPkg/Library/BaseCryptLibNull/Hash/CryptMd4Null.c > > > delete mode 100644 > > > CryptoPkg/Library/BaseCryptLibNull/Hmac/CryptHmacMd5Null.c > > > delete mode 100644 > > > CryptoPkg/Library/BaseCryptLibNull/Hmac/CryptHmacSha1Null.c > > > > > > -- > > > 2.21.0.windows.1 > > >=20