From: Andrew Fish <afish@apple.com>
To: Mike Kinney <michael.d.kinney@intel.com>
Cc: edk2-devel@lists.01.org, Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
Subject: Re: [staging/edk2-test PATCH 0/6] Fix XCODE and GCC build issues
Date: Wed, 01 Feb 2017 14:08:03 -0800 [thread overview]
Message-ID: <D97AEAD0-F914-49A8-90FC-B64DE37604B7@apple.com> (raw)
In-Reply-To: <1485888322-56072-1-git-send-email-michael.d.kinney@intel.com>
Mike,
This patch set looks good to me.
Reviewed-by: Andrew Fish <afish@apple.com <mailto:afish@apple.com>>
Thanks,
Andrew Fish
> On Jan 31, 2017, at 10:45 AM, Michael Kinney <michael.d.kinney@intel.com> wrote:
>
> This series fixes a number of XCODE and GCC build compatibility issues
> with the edk2-test branch. It also updates Readme.md with the Linux
> build instructions and addresses a few typos.
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
>
> Michael Kinney (6):
> edk2-test: Update Readme.md
> TestFrameworkPkg: Fix XCODE compatibility issues
> TestFrameworkPkg: Fix VS2015 compatibility issues
> TestFrameworkPkg: Fix GCC compatibility issues
> TestCasePkg: Fix XCODE compatibility issues
> TestCasePkg: Fix GCC compatibility issues
>
> Readme.md | 50 +-
> TestCasePkg/Timer/ArchTimerBBTestConformance.c | 7 +-
> TestCasePkg/Timer/ArchTimerBBTestFunction.c | 12 +-
> TestCasePkg/Timer/ArchTimerBBTestMain.c | 4 +-
> TestCasePkg/Timer/Guid.h | 41 +-
> TestFrameworkPkg/Eftp/ComponentName.c | 4 +
> TestFrameworkPkg/Eftp/EftpCommon.h | 2 +-
> TestFrameworkPkg/Eftp/EftpDriver.h | 5 +
> TestFrameworkPkg/Eftp/EftpMain.c | 6 +-
> TestFrameworkPkg/Eftp/EftpMain.h | 8 +-
> TestFrameworkPkg/Eftp/EftpOption.c | 36 +-
> TestFrameworkPkg/Eftp/EftpOption.h | 4 +-
> TestFrameworkPkg/Eftp/EftpPacket.c | 8 +-
> TestFrameworkPkg/Eftp/EftpPacket.h | 4 +-
> TestFrameworkPkg/Eftp/EftpRRQ.c | 34 +-
> TestFrameworkPkg/Eftp/EftpRRQ.h | 8 +-
> TestFrameworkPkg/Eftp/EftpWRQ.c | 21 +-
> TestFrameworkPkg/Eftp/EftpWRQ.h | 2 +
> TestFrameworkPkg/Include/Library/EntsLib.h | 225 -------
> TestFrameworkPkg/Include/Protocol/BbTest.h | 8 +-
> TestFrameworkPkg/Include/Protocol/Eftp.h | 24 +-
> .../Include/Protocol/EntsMonitorProtocol.h | 4 +-
> TestFrameworkPkg/Include/Protocol/LibPrivate.h | 12 +-
> .../Include/Protocol/StandardTestLibrary.h | 4 +-
> .../Include/Protocol/TestLoggingLibrary.h | 4 +-
> .../Include/Protocol/TestOutputLibrary.h | 4 +-
> .../Include/Protocol/TestProfileLibrary.h | 9 +-
> .../Include/Protocol/TestRecoveryLibrary.h | 4 +-
> TestFrameworkPkg/Include/Protocol/TslInit.h | 4 +-
> TestFrameworkPkg/Include/Protocol/WBTest.h | 84 ---
> TestFrameworkPkg/Include/Protocol/WbTest.h | 84 +++
> TestFrameworkPkg/InstallSct/InstallSct.c | 10 +-
> TestFrameworkPkg/Library/EasLib/EntsContext.c | 85 +--
> TestFrameworkPkg/Library/EasLib/EntsDpath.c | 62 +-
> TestFrameworkPkg/Library/EasLib/EntsGuid.c | 113 ++--
> TestFrameworkPkg/Library/EasLib/EntsLib.c | 21 +-
> TestFrameworkPkg/Library/EasLib/EntsLib.inf | 21 +-
> TestFrameworkPkg/Library/EasLib/EntsMisc.c | 4 +-
> TestFrameworkPkg/Library/EasLib/EntsPrint.c | 6 +-
> TestFrameworkPkg/Library/EasLib/EntsStr.c | 690 ---------------------
> TestFrameworkPkg/Library/EasLib/EntsSupport.c | 50 +-
> TestFrameworkPkg/Library/EasLib/EntsTime.c | 2 +-
> TestFrameworkPkg/Library/EfiTestLib/EfiTestLib.c | 22 +-
> .../IP4NetworkMonitor/IP4NetworkMonitor.c | 33 +-
> .../IP4NetworkMonitor/IP4NetworkMonitor.h | 8 +-
> .../ManagedNetworkMonitor/ManagedNetworkMonitor.c | 30 +-
> .../ManagedNetworkMonitor/ManagedNetworkMonitor.h | 6 +
> .../MonitorServices/SerialMonitor/SerialMonitor.c | 8 +-
> .../PeiSctManageModule/PeiSctManageModule.c | 4 +-
> TestFrameworkPkg/Sct/Core/SctInit.c | 2 +-
> TestFrameworkPkg/Sct/Data/ApTest.c | 4 +-
> TestFrameworkPkg/Sct/Data/Category.c | 2 +-
> TestFrameworkPkg/Sct/Data/TestCase.c | 2 +-
> TestFrameworkPkg/Sct/Data/TestNode.c | 2 +-
> TestFrameworkPkg/Sct/DeviceConfig/DeviceConfig.c | 12 +-
> .../Sct/ENTS/EasDispatcher/Arg/EasArg.c | 2 +-
> .../Sct/ENTS/EasDispatcher/Core/EasInit.c | 6 +-
> .../Sct/ENTS/EasDispatcher/Exec/EasCmdDisp.c | 6 +-
> .../Sct/ENTS/EasDispatcher/Exec/EftpImplement.c | 17 +-
> .../Sct/ENTS/EasDispatcher/Load/EasSupportFile.c | 12 +-
> .../Sct/ENTS/EasDispatcher/Load/EasTestFile.c | 10 +-
> .../Sct/ENTS/EasDispatcher/Rivl/RivlType.c | 5 +-
> .../Sct/ENTS/EasDispatcher/Rivl/RivlVariable.c | 16 +-
> TestFrameworkPkg/Sct/Execute/ExecuteSupport.c | 22 +-
> TestFrameworkPkg/Sct/Execute/ExecuteSupport.h | 1 +
> TestFrameworkPkg/Sct/Execute/Reset.c | 6 +-
> TestFrameworkPkg/Sct/Include/ApTest.h | 4 +-
> TestFrameworkPkg/Sct/Include/SctCore.h | 1 +
> TestFrameworkPkg/Sct/Include/SctDef.h | 2 +-
> TestFrameworkPkg/Sct/Include/SctOutput.h | 4 +-
> TestFrameworkPkg/Sct/Load/SupportFile.c | 32 +-
> TestFrameworkPkg/Sct/Load/TestFile.c | 14 +-
> TestFrameworkPkg/Sct/Misc/SctMisc.c | 6 +-
> TestFrameworkPkg/Sct/Operation/Operation.c | 2 +-
> TestFrameworkPkg/Sct/Report/Report.c | 14 +-
> TestFrameworkPkg/Sct/Report/ReportConfig.c | 2 +-
> TestFrameworkPkg/Sct/Report/ReportDatabase.c | 14 +-
> TestFrameworkPkg/Sct/Report/ReportSupport.c | 10 +-
> TestFrameworkPkg/Sct/Report/ReportSupport.h | 8 +-
> TestFrameworkPkg/Sct/UI/BuildMenu.c | 8 +-
> TestFrameworkPkg/Sct/UI/BuildMenu.h | 11 +-
> TestFrameworkPkg/Sct/UI/ConfigMenu.c | 38 +-
> TestFrameworkPkg/Sct/UI/Dialog.h | 2 +-
> TestFrameworkPkg/Sct/UI/DisplayUi.c | 12 +
> TestFrameworkPkg/Sct/UI/FileDialog.c | 2 +-
> TestFrameworkPkg/Sct/UI/FileDialog.h | 2 +-
> TestFrameworkPkg/Sct/UI/KeyFunction.c | 48 +-
> TestFrameworkPkg/Sct/UI/LogFileDialog.c | 6 +-
> TestFrameworkPkg/Sct/UI/LogFileDialog.h | 2 +-
> TestFrameworkPkg/Sct/UI/MainMenu.c | 18 +
> TestFrameworkPkg/Sct/UI/TestNodeMenu.c | 18 +-
> TestFrameworkPkg/Sct/UI/TestNodeMenu.h | 2 +-
> TestFrameworkPkg/Sct/UI/UI.h | 32 +-
> TestFrameworkPkg/Sct/print.c | 8 +-
> .../Support/StandardTest/StandardTest.c | 57 +-
> TestFrameworkPkg/Support/TestLogging/TestLogging.c | 8 +-
> TestFrameworkPkg/Support/TestProfile/TestProfile.c | 670 ++++++--------------
> .../Support/TestProfile/TestProfile.inf | 1 +
> .../Support/TestRecovery/TestRecovery.c | 6 +-
> TestFrameworkPkg/TestFrameworkPkg.dsc | 2 +-
> 100 files changed, 998 insertions(+), 2096 deletions(-)
> delete mode 100644 TestFrameworkPkg/Include/Protocol/WBTest.h
> create mode 100644 TestFrameworkPkg/Include/Protocol/WbTest.h
>
> --
> 2.6.3.windows.1
>
prev parent reply other threads:[~2017-02-01 22:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 18:45 [staging/edk2-test PATCH 0/6] Fix XCODE and GCC build issues Michael Kinney
2017-01-31 18:45 ` [staging/edk2-test PATCH 1/6] edk2-test: Update Readme.md Michael Kinney
2017-01-31 19:29 ` Michael Zimmermann
2017-01-31 22:41 ` Supreeth Venkatesh
2017-01-31 23:02 ` Andrew Fish
2017-01-31 23:08 ` Supreeth Venkatesh
2017-01-31 23:32 ` Kinney, Michael D
2017-01-31 23:42 ` Supreeth Venkatesh
2017-02-01 2:01 ` Kinney, Michael D
2017-02-03 6:39 ` Gao, Liming
2017-01-31 18:45 ` [staging/edk2-test PATCH 2/6] TestFrameworkPkg: Fix XCODE compatibility issues Michael Kinney
2017-01-31 18:45 ` [staging/edk2-test PATCH 3/6] TestFrameworkPkg: Fix VS2015 " Michael Kinney
2017-01-31 18:45 ` [staging/edk2-test PATCH 4/6] TestFrameworkPkg: Fix GCC " Michael Kinney
2017-01-31 18:45 ` [staging/edk2-test PATCH 5/6] TestCasePkg: Fix XCODE " Michael Kinney
2017-01-31 18:45 ` [staging/edk2-test PATCH 6/6] TestCasePkg: Fix GCC " Michael Kinney
2017-02-01 22:08 ` Andrew Fish [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D97AEAD0-F914-49A8-90FC-B64DE37604B7@apple.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox