From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in4.apple.com (mail-out4.apple.com [17.151.62.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 38E0081FC1 for ; Wed, 1 Feb 2017 14:08:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1485986884; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-reply-to:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=olzDnNGrkNvhS0lpl44tl2Kbdf2cpxkVBx9ha9fElDI=; b=c4B2tw+D5jNxTSA7X5yf9ohEUp7/1vsHWzsq0INgx2WvRRHa4VVsA/Q8JRy0Rx9n ZhmpsbieBr7P3FcjnM+C69L076oAf6EEzNLHYIcaUblHKzBfeozZKnvxWDL354C1 ZiC9QduLfdwcr3kf0Ug5/OFMZWHayDiNovM1/d+Q9qBv1oK3XKBOPdtPgBR7K5Xn slgrzThqCaz9oZXvVX10vAhZHVrpK/v5lBq7bpPaVeedDCG5Hk6PX0WjLhLUt9MP o4bWAoETTHVH48xk599can5oSen8Nlb3pD+TNv5yr3Azj+AqMJGIWG0LonWIbV/x c0pifHGC6I4jCPcSdMCQeQ==; Received: from relay7.apple.com (relay7.apple.com [17.128.113.101]) by mail-in4.apple.com (Apple Secure Mail Relay) with SMTP id F7.3C.10104.44C52985; Wed, 1 Feb 2017 14:08:04 -0800 (PST) X-AuditID: 11973e12-ad23a9a000002778-20-58925c449f09 Received: from nwk-mmpp-sz11.apple.com (nwk-mmpp-sz11.apple.com [17.128.115.155]) by relay7.apple.com (Apple SCV relay) with SMTP id D5.E8.06316.44C52985; Wed, 1 Feb 2017 14:08:04 -0800 (PST) MIME-version: 1.0 Received: from [17.153.47.30] (unknown [17.153.47.30]) by nwk-mmpp-sz11.apple.com (Oracle Communications Messaging Server 8.0.1.1.0 64bit (built Jun 15 2016)) with ESMTPSA id <0OKP007N3UTF5I00@nwk-mmpp-sz11.apple.com>; Wed, 01 Feb 2017 14:08:04 -0800 (PST) Sender: afish@apple.com From: Andrew Fish Message-id: Date: Wed, 01 Feb 2017 14:08:03 -0800 In-reply-to: <1485888322-56072-1-git-send-email-michael.d.kinney@intel.com> Cc: edk2-devel@lists.01.org, Supreeth Venkatesh To: Mike Kinney References: <1485888322-56072-1-git-send-email-michael.d.kinney@intel.com> X-Mailer: Apple Mail (2.3226) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLLMWRmVeSWpSXmKPExsUi2FCYqusSMynC4PY6Q4s9h44yW3R0/GOy 2Heon9WB2WPNvDWMHov3vGTy6J79jyWAOYrLJiU1J7MstUjfLoEr48/eo2wFtw8yVlw6uZe9 gfHPcsYuRk4OCQETiYn7FgDZXBxCAvsYJf4faGDvYuQAS7zYXgQRP8QosbNjAgtIA6+AoMSP yffAbGaBMImPD14wQRR1MEn0Xb0INlVYQFzi3ZlNzCA2m4CyxIr5H9ghmm0k5rR+YIGo8ZTY uWEXmM0ioCpx8vFaJhCbU8Bb4uL/h4wQC3wktm36xwZykIiAjkT3ymiQsJCAl8Tuaz9ZIe6U lZj9ywvkBAmBHWwSX3ZsYprAKDQLyamzkJwKYWtJfH/UChTnALLlJQ6el4UIa0o8u/eJHcLW lnjy7gLrAka2VYxCuYmZObqZeSZ6iQUFOal6yfm5mxhB8THdTmgH46lVVocYBTgYlXh4M8Qm RQixJpYVV+YeYpTmYFES5z1uAxQSSE8sSc1OTS1ILYovKs1JLT7EyMTBKdXAuILpykqNEwpb krJ2TJVvr71TvXuT2qwu9zvnL+R11+Y+/qv6Iq7+gpVfdf7fjet9sxI+S8U99LRflRTEG8n9 gsUg+bT26qq6WTbPFp0M3FC+K2Day4r6NzUrXj2QWzdbb1Nj0SXhSZHWzQ8XB0XGGC/RTpLZ HNcSuenD/ddS7Ft1/a/dPXkuUImlOCPRUIu5qDgRAIa5IOpwAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrDLMWRmVeSWpSXmKPExsUi2FA8W9clZlKEwYQ+LYs9h44yW3R0/GOy 2Heon9WB2WPNvDWMHov3vGTy6J79jyWAOYrLJiU1J7MstUjfLoEr48/eo2wFtw8yVlw6uZe9 gfHPcsYuRg4OCQETiRfbi7oYOYFMMYkL99azdTFycQgJHGKU2NkxgQUkwSsgKPFj8j0wm1kg TOLjgxdMEEUdTBJ9Vy8ygiSEBcQl3p3ZxAxiswkoS6yY/4EdotlGYk7rBxaIGk+JnRt2gdks AqoSJx+vZQKxOQW8JS7+f8gIscBHYtumf2wgx4kI6Eh0r4wGCQsJeEnsvvaTFeJmWYnZv7wm MArMQnLdLCTXQdhaEt8ftQLFOYBseYmD52UhwpoSz+59YoewtSWevLvAuoCRbRWjQFFqTmKl uV5iQUFOql5yfu4mRnCYF6buYGxcbnWIUYCDUYmH94DEpAgh1sSy4spcYBBxMCuJ8DJFAYV4 UxIrq1KL8uOLSnNSiw8xSnOwKInzTheaGCEkkJ5YkpqdmlqQWgSTZeLglGpgTLV/EsjWa6p4 4HbEzrn/Lnf+bP2hMsEnOyFf+khxxUyx9b8khX50eb+rudNzIfXxGb0t6Z+zRJbaM8+wuHNf ylL8Prt4etpNboNEObbvf8+wL5pbM0//5p+XueLKz4S3PmPhYnVjzJu28YGopPvRwpVhNznW 5OybbTXP2q+pTHjfCvPDS2dEKbEUZyQaajEXFScCAD9KMrhvAgAA X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [staging/edk2-test PATCH 0/6] Fix XCODE and GCC build issues X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Feb 2017 22:08:05 -0000 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT Mike, This patch set looks good to me. Reviewed-by: Andrew Fish > Thanks, Andrew Fish > On Jan 31, 2017, at 10:45 AM, Michael Kinney wrote: > > This series fixes a number of XCODE and GCC build compatibility issues > with the edk2-test branch. It also updates Readme.md with the Linux > build instructions and addresses a few typos. > > Cc: Andrew Fish > Cc: Supreeth Venkatesh > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Michael Kinney > > Michael Kinney (6): > edk2-test: Update Readme.md > TestFrameworkPkg: Fix XCODE compatibility issues > TestFrameworkPkg: Fix VS2015 compatibility issues > TestFrameworkPkg: Fix GCC compatibility issues > TestCasePkg: Fix XCODE compatibility issues > TestCasePkg: Fix GCC compatibility issues > > Readme.md | 50 +- > TestCasePkg/Timer/ArchTimerBBTestConformance.c | 7 +- > TestCasePkg/Timer/ArchTimerBBTestFunction.c | 12 +- > TestCasePkg/Timer/ArchTimerBBTestMain.c | 4 +- > TestCasePkg/Timer/Guid.h | 41 +- > TestFrameworkPkg/Eftp/ComponentName.c | 4 + > TestFrameworkPkg/Eftp/EftpCommon.h | 2 +- > TestFrameworkPkg/Eftp/EftpDriver.h | 5 + > TestFrameworkPkg/Eftp/EftpMain.c | 6 +- > TestFrameworkPkg/Eftp/EftpMain.h | 8 +- > TestFrameworkPkg/Eftp/EftpOption.c | 36 +- > TestFrameworkPkg/Eftp/EftpOption.h | 4 +- > TestFrameworkPkg/Eftp/EftpPacket.c | 8 +- > TestFrameworkPkg/Eftp/EftpPacket.h | 4 +- > TestFrameworkPkg/Eftp/EftpRRQ.c | 34 +- > TestFrameworkPkg/Eftp/EftpRRQ.h | 8 +- > TestFrameworkPkg/Eftp/EftpWRQ.c | 21 +- > TestFrameworkPkg/Eftp/EftpWRQ.h | 2 + > TestFrameworkPkg/Include/Library/EntsLib.h | 225 ------- > TestFrameworkPkg/Include/Protocol/BbTest.h | 8 +- > TestFrameworkPkg/Include/Protocol/Eftp.h | 24 +- > .../Include/Protocol/EntsMonitorProtocol.h | 4 +- > TestFrameworkPkg/Include/Protocol/LibPrivate.h | 12 +- > .../Include/Protocol/StandardTestLibrary.h | 4 +- > .../Include/Protocol/TestLoggingLibrary.h | 4 +- > .../Include/Protocol/TestOutputLibrary.h | 4 +- > .../Include/Protocol/TestProfileLibrary.h | 9 +- > .../Include/Protocol/TestRecoveryLibrary.h | 4 +- > TestFrameworkPkg/Include/Protocol/TslInit.h | 4 +- > TestFrameworkPkg/Include/Protocol/WBTest.h | 84 --- > TestFrameworkPkg/Include/Protocol/WbTest.h | 84 +++ > TestFrameworkPkg/InstallSct/InstallSct.c | 10 +- > TestFrameworkPkg/Library/EasLib/EntsContext.c | 85 +-- > TestFrameworkPkg/Library/EasLib/EntsDpath.c | 62 +- > TestFrameworkPkg/Library/EasLib/EntsGuid.c | 113 ++-- > TestFrameworkPkg/Library/EasLib/EntsLib.c | 21 +- > TestFrameworkPkg/Library/EasLib/EntsLib.inf | 21 +- > TestFrameworkPkg/Library/EasLib/EntsMisc.c | 4 +- > TestFrameworkPkg/Library/EasLib/EntsPrint.c | 6 +- > TestFrameworkPkg/Library/EasLib/EntsStr.c | 690 --------------------- > TestFrameworkPkg/Library/EasLib/EntsSupport.c | 50 +- > TestFrameworkPkg/Library/EasLib/EntsTime.c | 2 +- > TestFrameworkPkg/Library/EfiTestLib/EfiTestLib.c | 22 +- > .../IP4NetworkMonitor/IP4NetworkMonitor.c | 33 +- > .../IP4NetworkMonitor/IP4NetworkMonitor.h | 8 +- > .../ManagedNetworkMonitor/ManagedNetworkMonitor.c | 30 +- > .../ManagedNetworkMonitor/ManagedNetworkMonitor.h | 6 + > .../MonitorServices/SerialMonitor/SerialMonitor.c | 8 +- > .../PeiSctManageModule/PeiSctManageModule.c | 4 +- > TestFrameworkPkg/Sct/Core/SctInit.c | 2 +- > TestFrameworkPkg/Sct/Data/ApTest.c | 4 +- > TestFrameworkPkg/Sct/Data/Category.c | 2 +- > TestFrameworkPkg/Sct/Data/TestCase.c | 2 +- > TestFrameworkPkg/Sct/Data/TestNode.c | 2 +- > TestFrameworkPkg/Sct/DeviceConfig/DeviceConfig.c | 12 +- > .../Sct/ENTS/EasDispatcher/Arg/EasArg.c | 2 +- > .../Sct/ENTS/EasDispatcher/Core/EasInit.c | 6 +- > .../Sct/ENTS/EasDispatcher/Exec/EasCmdDisp.c | 6 +- > .../Sct/ENTS/EasDispatcher/Exec/EftpImplement.c | 17 +- > .../Sct/ENTS/EasDispatcher/Load/EasSupportFile.c | 12 +- > .../Sct/ENTS/EasDispatcher/Load/EasTestFile.c | 10 +- > .../Sct/ENTS/EasDispatcher/Rivl/RivlType.c | 5 +- > .../Sct/ENTS/EasDispatcher/Rivl/RivlVariable.c | 16 +- > TestFrameworkPkg/Sct/Execute/ExecuteSupport.c | 22 +- > TestFrameworkPkg/Sct/Execute/ExecuteSupport.h | 1 + > TestFrameworkPkg/Sct/Execute/Reset.c | 6 +- > TestFrameworkPkg/Sct/Include/ApTest.h | 4 +- > TestFrameworkPkg/Sct/Include/SctCore.h | 1 + > TestFrameworkPkg/Sct/Include/SctDef.h | 2 +- > TestFrameworkPkg/Sct/Include/SctOutput.h | 4 +- > TestFrameworkPkg/Sct/Load/SupportFile.c | 32 +- > TestFrameworkPkg/Sct/Load/TestFile.c | 14 +- > TestFrameworkPkg/Sct/Misc/SctMisc.c | 6 +- > TestFrameworkPkg/Sct/Operation/Operation.c | 2 +- > TestFrameworkPkg/Sct/Report/Report.c | 14 +- > TestFrameworkPkg/Sct/Report/ReportConfig.c | 2 +- > TestFrameworkPkg/Sct/Report/ReportDatabase.c | 14 +- > TestFrameworkPkg/Sct/Report/ReportSupport.c | 10 +- > TestFrameworkPkg/Sct/Report/ReportSupport.h | 8 +- > TestFrameworkPkg/Sct/UI/BuildMenu.c | 8 +- > TestFrameworkPkg/Sct/UI/BuildMenu.h | 11 +- > TestFrameworkPkg/Sct/UI/ConfigMenu.c | 38 +- > TestFrameworkPkg/Sct/UI/Dialog.h | 2 +- > TestFrameworkPkg/Sct/UI/DisplayUi.c | 12 + > TestFrameworkPkg/Sct/UI/FileDialog.c | 2 +- > TestFrameworkPkg/Sct/UI/FileDialog.h | 2 +- > TestFrameworkPkg/Sct/UI/KeyFunction.c | 48 +- > TestFrameworkPkg/Sct/UI/LogFileDialog.c | 6 +- > TestFrameworkPkg/Sct/UI/LogFileDialog.h | 2 +- > TestFrameworkPkg/Sct/UI/MainMenu.c | 18 + > TestFrameworkPkg/Sct/UI/TestNodeMenu.c | 18 +- > TestFrameworkPkg/Sct/UI/TestNodeMenu.h | 2 +- > TestFrameworkPkg/Sct/UI/UI.h | 32 +- > TestFrameworkPkg/Sct/print.c | 8 +- > .../Support/StandardTest/StandardTest.c | 57 +- > TestFrameworkPkg/Support/TestLogging/TestLogging.c | 8 +- > TestFrameworkPkg/Support/TestProfile/TestProfile.c | 670 ++++++-------------- > .../Support/TestProfile/TestProfile.inf | 1 + > .../Support/TestRecovery/TestRecovery.c | 6 +- > TestFrameworkPkg/TestFrameworkPkg.dsc | 2 +- > 100 files changed, 998 insertions(+), 2096 deletions(-) > delete mode 100644 TestFrameworkPkg/Include/Protocol/WBTest.h > create mode 100644 TestFrameworkPkg/Include/Protocol/WbTest.h > > -- > 2.6.3.windows.1 >