Re: [edk2-test][RFC PATCH 11/12] uefi-sct/SctPkg: sbbr: Bugfix for MemoryMap Check Test.

["Jin, Eric" <eric.jin@intel.com>]

Add the maintainer Supreeth.

Hello Sakar,

Thank for the patches in this series.
The common comments is: 
The keyword 'SBBR' exists on the FilePath or in the FileName. But 'SBBR' string or related description is not mentioned in UEFI spec at all. 
Could you please add more detail for the checkpoint requirement in the UEFI spec? Please remove the 'SBBR' in the new patch.
If the checkpoint is not related to UEFI spec, uefi-sct/sctpkg may not be the proper space for these patch landing. Thanks. 

Best Regards
Eric

-----Original Message-----
From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of Sakar Arora
Sent: Tuesday, November 6, 2018 4:48 PM
To: edk2-devel@lists.01.org
Cc: prasanth.pulla@arm.com
Subject: [edk2] [edk2-test][RFC PATCH 11/12] uefi-sct/SctPkg: sbbr: Bugfix for MemoryMap Check Test.

As per SBBR specification, "A UEFI runtime environment compliant with SBBR must not be written with any assumption of an identity mapping between virtual and physical memory maps."

Test case implementation was failing the test, if it is not identity mapped, which is incorrect.

Corrected test case to warn the user that UEFI runtime environment is identity mapped, instead of failure.

Signed-off-by: Sakar Arora <sakar.arora@arm.com>
Reported-by: Felix Poludov <Felixp@ami.com>
---
 .../SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTestFunction.c  | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTestFunction.c
index fb50702..c88d60b 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/Bl
+++ ackBoxTest/SbbrBootServicesBBTestFunction.c
@@ -201,13 +201,13 @@ BBTestMemoryMapTest (
     //
     // Checking for identity mapping
     //
-    if (MemoryMapDescriptor->PhysicalStart != MemoryMapDescriptor->VirtualStart) {
+    if (MemoryMapDescriptor->PhysicalStart == 
+ MemoryMapDescriptor->VirtualStart) {
       StandardLib->RecordAssertion (
                   StandardLib,
-                  EFI_TEST_ASSERTION_FAILED,
+                  EFI_TEST_ASSERTION_WARNING,
                   gSbbrBootServicesAssertion001Guid,
                   L"MemoryMap",
-                  L"%a:%d - MemoryMap 0x%X Not Identity Mapped",
+                  L"%a:%d - MemoryMap 0x%X is Identity Mapped. UEFI 
+ runtime environment must not be written with any assumption of an 
+ identity mapping between virtual and physical memory maps.",
                   __FILE__,
                   __LINE__,
                   MemoryMapDescriptor
--
2.7.4

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel