From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=eric.jin@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5552021183ED7 for ; Mon, 19 Nov 2018 23:55:49 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Nov 2018 23:55:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,256,1539673200"; d="scan'208";a="87795752" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga008.fm.intel.com with ESMTP; 19 Nov 2018 23:55:48 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 19 Nov 2018 23:55:48 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 19 Nov 2018 23:55:48 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.161]) by shsmsx102.ccr.corp.intel.com ([169.254.2.84]) with mapi id 14.03.0415.000; Tue, 20 Nov 2018 15:55:46 +0800 From: "Jin, Eric" To: Sakar Arora , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [edk2-test][RFC PATCH 11/12] uefi-sct/SctPkg: sbbr: Bugfix for MemoryMap Check Test. Thread-Index: AQHUdbqG2Qfltu0JqEe2yrwAJ/e5MaVYX0yg Date: Tue, 20 Nov 2018 07:55:45 +0000 Message-ID: References: <1541494066-16288-1-git-send-email-sakar.arora@arm.com> <1541494066-16288-11-git-send-email-sakar.arora@arm.com> In-Reply-To: <1541494066-16288-11-git-send-email-sakar.arora@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [edk2-test][RFC PATCH 11/12] uefi-sct/SctPkg: sbbr: Bugfix for MemoryMap Check Test. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 07:55:49 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Add the maintainer Supreeth. Hello Sakar, Thank for the patches in this series. The common comments is:=20 The keyword 'SBBR' exists on the FilePath or in the FileName. But 'SBBR' st= ring or related description is not mentioned in UEFI spec at all.=20 Could you please add more detail for the checkpoint requirement in the UEFI= spec? Please remove the 'SBBR' in the new patch. If the checkpoint is not related to UEFI spec, uefi-sct/sctpkg may not be t= he proper space for these patch landing. Thanks.=20 Best Regards Eric -----Original Message----- From: edk2-devel On Behalf Of Sakar Arora Sent: Tuesday, November 6, 2018 4:48 PM To: edk2-devel@lists.01.org Cc: prasanth.pulla@arm.com Subject: [edk2] [edk2-test][RFC PATCH 11/12] uefi-sct/SctPkg: sbbr: Bugfix = for MemoryMap Check Test. As per SBBR specification, "A UEFI runtime environment compliant with SBBR = must not be written with any assumption of an identity mapping between virt= ual and physical memory maps." Test case implementation was failing the test, if it is not identity mapped= , which is incorrect. Corrected test case to warn the user that UEFI runtime environment is ident= ity mapped, instead of failure. Signed-off-by: Sakar Arora Reported-by: Felix Poludov --- .../SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTestFunction.c | 6 ++= +--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootService= s/BlackBoxTest/SbbrBootServicesBBTestFunction.c b/uefi-sct/SctPkg/TestCase/= UEFI/EFI/BootServices/SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTestF= unction.c index fb50702..c88d60b 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/Black= BoxTest/SbbrBootServicesBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/Bl +++ ackBoxTest/SbbrBootServicesBBTestFunction.c @@ -201,13 +201,13 @@ BBTestMemoryMapTest ( // // Checking for identity mapping // - if (MemoryMapDescriptor->PhysicalStart !=3D MemoryMapDescriptor->Virtu= alStart) { + if (MemoryMapDescriptor->PhysicalStart =3D=3D=20 + MemoryMapDescriptor->VirtualStart) { StandardLib->RecordAssertion ( StandardLib, - EFI_TEST_ASSERTION_FAILED, + EFI_TEST_ASSERTION_WARNING, gSbbrBootServicesAssertion001Guid, L"MemoryMap", - L"%a:%d - MemoryMap 0x%X Not Identity Mapped", + L"%a:%d - MemoryMap 0x%X is Identity Mapped. UEFI=20 + runtime environment must not be written with any assumption of an=20 + identity mapping between virtual and physical memory maps.", __FILE__, __LINE__, MemoryMapDescriptor -- 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel