public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Jin, Eric" <eric.jin@intel.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [edk2-test][v2 Patch 0/3] Add VerifySignature() Test
Date: Wed, 5 Dec 2018 02:47:42 +0000	[thread overview]
Message-ID: <DA72DC7456565B47808A57108259571F63720BA6@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <22732d66-0578-bf26-c69a-7fe23ed4b801@redhat.com>

Hi Laszlo,

Thank for the comments. Will send out new patch series later. 

Best Regards
Eric

-----Original Message-----
From: Laszlo Ersek <lersek@redhat.com> 
Sent: Monday, December 3, 2018 9:50 PM
To: Jin, Eric <eric.jin@intel.com>
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2] [edk2-test][v2 Patch 0/3] Add VerifySignature() Test

On 12/03/18 08:53, Eric Jin wrote:
> This is the cover letter.
> The series of patches are listed below.
> 
>   uefi-sct/SctPkg:Format code style in PKCS7Verify
>   uefi-sct/SctPkg:Add VerifySignature() Func Test
>   uefi-sct/SctPkg:Add VerifySignature() Conf Test
> 
> 
>  .../EFI/Protocol/PKCS7Verify/BlackBoxTest/Guid.c   |   93 +-
>  .../EFI/Protocol/PKCS7Verify/BlackBoxTest/Guid.h   |  192 +--
>  .../PKCS7Verify/BlackBoxTest/Pkcs7BBTest.inf       |  126 +-
>  .../BlackBoxTest/Pkcs7BBTestConformance.c          | 1305 +++++++++-------
>  .../PKCS7Verify/BlackBoxTest/Pkcs7BBTestData.c     | 1568 +++++++++++++-------
>  .../PKCS7Verify/BlackBoxTest/Pkcs7BBTestFunction.c |  553 ++++---
>  .../PKCS7Verify/BlackBoxTest/Pkcs7BBTestMain.c     |  458 +++---
>  .../PKCS7Verify/BlackBoxTest/Pkcs7BBTestMain.h     |  248 ++--
>  8 files changed, 2689 insertions(+), 1854 deletions(-)
> 

A cover letter like this doesn't make any sense.

- Please enable shallow threading for git-send-email, so that the patch emails are (direct) children of the cover letter. One of the goals of the cover letter is to group the patches under a common parent message.

- The other purpose of cover letters is to summarize the goal of the patch series (high level problem statement, chosen solution, maybe mention one or two details if they are important).

Thanks
Laszlo

      reply	other threads:[~2018-12-05  2:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-03  7:53 [edk2-test][v2 Patch 0/3] Add VerifySignature() Test Eric Jin
2018-12-03 13:49 ` Laszlo Ersek
2018-12-05  2:47   ` Jin, Eric [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DA72DC7456565B47808A57108259571F63720BA6@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox