From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=eric.jin@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7A4D2211E9FDF for ; Fri, 29 Mar 2019 02:03:34 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Mar 2019 02:03:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,284,1549958400"; d="scan'208";a="311412102" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga005.jf.intel.com with ESMTP; 29 Mar 2019 02:03:33 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 29 Mar 2019 02:03:33 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 29 Mar 2019 02:03:32 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.134]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.113]) with mapi id 14.03.0415.000; Fri, 29 Mar 2019 17:03:31 +0800 From: "Jin, Eric" To: Supreeth Venkatesh , "edk2-devel@lists.01.org" CC: "Jin, Eric" Thread-Topic: [edk2-test][PATCH v1 30/30] UEFI/UEFI.dec: Add missing protocol GUIDs in declaration file. Thread-Index: AQHU5bvan5lPBOBDwkGS8i3zf1o/taYiSHGA Date: Fri, 29 Mar 2019 09:03:31 +0000 Message-ID: References: <20190328231222.4717-1-supreeth.venkatesh@arm.com> <20190328231222.4717-30-supreeth.venkatesh@arm.com> In-Reply-To: <20190328231222.4717-30-supreeth.venkatesh@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [edk2-test][PATCH v1 30/30] UEFI/UEFI.dec: Add missing protocol GUIDs in declaration file. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Mar 2019 09:03:34 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Supreeth, Thanks a lot to fix this build issue at first. Comments for this series of patches are replied below. Patch 1/2 :=20 1. Could the two patches can be re-organized? For example, merge the change= of *.dsc in patch 2 to patch 1 to make it clear. 2. The change of CommonGenFramework.sh in patch 2 will remove the ebc from = binary package.=20 =20 Patch 24 :=20 1. Please don't forget change the copyright part 2. Do you meet the similar issue that "UEFI_CONFIG_LANG" : macro redefiniti= on while build? Other Patches : 1. Please remove "COMPONENT_TYPE =3D BS_DRIVER" With that Reviewed-by: Eric Jin Best Regards Eric -----Original Message----- From: Supreeth Venkatesh =20 Sent: Friday, March 29, 2019 7:12 AM To: edk2-devel@lists.01.org Cc: Supreeth Venkatesh ; Jin, Eric Subject: [edk2-test][PATCH v1 30/30] UEFI/UEFI.dec: Add missing protocol GU= IDs in declaration file. Fix compilation issues in inf files when compiled against edk2 stable tag e= dk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- uefi-sct/SctPkg/UEFI/UEFI.dec | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/uefi-sct/SctPkg/UEFI/UEFI.dec b/uefi-sct/SctPkg/UEFI/UEFI.dec = index 8495a4e1..bdf3323f 100644 --- a/uefi-sct/SctPkg/UEFI/UEFI.dec +++ b/uefi-sct/SctPkg/UEFI/UEFI.dec @@ -1,7 +1,7 @@ ## @file # # Copyright 2004 - 2017 Unified EFI, Inc.
-# Copyright (c) 2014 - 20= 18, ARM Limited. All rights reserved. +# Copyright (c) 2014 - 2019, ARM Limited. All rights reserved. # Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.
= # (C) Copyright 2017 Hewlett Packard Enterprise Development LP
# @@ = -119,14 +119,22 @@ gBlackBoxEfiHIIStringProtocolGuid =3D {0xfd96974, 0x23aa, 0x4cdc, { 0xb9= , 0xcb, 0x98, 0xd1, 0x77, 0x50, 0x32, 0x2a }} gBlackBoxEfiHIIImageProtocolGuid =3D { 0x31a6406a, 0x6bdf, 0x4e46, {0xb2= , 0xa2, 0xeb, 0xaa, 0x89, 0xc4, 0x9, 0x20 }} gBlackBoxEfiHIIImageExProtocolGuid =3D { 0x1a1241e6, 0x8f19, 0x41a9, { 0= xbc, 0xe, 0xe8, 0xef,0x39, 0xe0, 0x65, 0x46 }} + gBlackBoxEfiHIIDatabaseProtocolGuid =3D { 0xef9fc172, 0xa1b2, 0x4693, {= =20 + 0xb3, 0x27, 0x6d, 0x32, 0xfc, 0x41, 0x60, 0x42 }} =20 + gBlackBoxEfiHIIPackageListProtocolGuid =3D { 0x6a1ee763, 0xd47a, 0x43b4,= =20 + { 0xaa, 0xbe, 0xef, 0x1d, 0xe2, 0xab, 0x56, 0xfc }} =20 + gBlackBoxEfiHIIStringProtocolGuid =3D {0xfd96974, 0x23aa, 0x4cdc, {=20 + 0xb9, 0xcb, 0x98, 0xd1, 0x77, 0x50, 0x32, 0x2a }} =20 + gBlackBoxEfiHIIConfigAccessProtocolGuid =3D { 0x330d4706, 0xf2a0,=20 + 0x4e4f, { 0xa3, 0x69, 0xb6, 0x6f, 0xa8, 0xd5, 0x43, 0x85 }} =20 + gBlackBoxEfiHIIConfigRoutingProtocolGuid =3D { 0x587e72d7, 0xcc50,=20 + 0x4f79, { 0x82, 0x09, 0xca, 0x29, 0x1f, 0xc1, 0xa1, 0x0f }} gBlackBoxEfiHIIFontProtocolGuid =3D { 0xe9ca4775, 0x8657, 0x47fc, { 0x97= , 0xe7, 0x7e, 0xd6, 0x5a, 0x8, 0x43, 0x24 }} gBlackBoxEfiHIIFontExProtocolGuid =3D { 0x849e6875, 0xdb35, 0x4df8, { 0x= b4, 0x1e, 0xc8, 0xf3, 0x37, 0x18, 0x7, 0x3f }} gBlackBoxEfiHttpProtocolGuid =3D { 0x7A59B29B, 0x910B, 0x4171, { 0x82, 0= x42, 0xA8, 0x5A, 0x0D, 0xF2, 0x5B, 0x5B }} gBlackBoxEfiHttpServiceBindingProtocolGuid =3D { 0xbdc8e6af, 0xd9bc, 0x4= 379, { 0xa7, 0x2a, 0xe0, 0xc4, 0xe7, 0x5d, 0xae, 0x1c }} gBlackBoxEfiIp4ServiceBindingProtocolGuid =3D { 0xc51711e7, 0xb4bf, 0x40= 4a, {0xbf, 0xb8, 0x0a, 0x04, 0x8e, 0xf1, 0xff, 0xe4 } } gBlackBoxEfiIp4ProtocolGuid =3D { 0x41d94cd2, 0x35b6, 0x455a, {0x82, 0x5= 8, 0xd4, 0xe5, 0x13, 0x34, 0xaa, 0xdd } } + gBlackBoxEfiIp4ConfigProtocolGuid =3D { 0x3B95AA31, 0x3793, 0x434B,=20 + {0x86, 0x67, 0xC8, 0x07, 0x08, 0x92, 0xE0, 0x5E } } =20 + gBlackBoxEfiIp4Config2ProtocolGuid =3D { 0x5b446ed1, 0xe30b, 0x4faa,=20 + {0x87, 0x1a, 0x36, 0x54, 0xec, 0xa3, 0x60, 0x80 } } gBlackBoxEfiIp6ServiceBindingProtocolGuid =3D { 0xec835dd3, 0xfe0f, 0x61= 7b, {0xa6, 0x21, 0xb3, 0x50, 0xc3, 0xe1, 0x33, 0x88 } } gBlackBoxEfiIp6ProtocolGuid =3D { 0xec835dd3, 0xfe0f, 0x617b, {0xa6, 0x2= 1, 0xb3, 0x50, 0xc3, 0xe1, 0x33, 0x88 } } + gBlackBoxEfiIp6ConfigProtocolGuid =3D { 0x937fe521, 0x95ae, 0x4d1a,=20 + {0x89, 0x29, 0x48, 0xbc, 0xd9, 0x0a, 0xd3, 0x1a } } gBlackBoxEfiIPsec2ProtocolGuid =3D {0xa3979e64, 0xace8, 0x4ddc, { 0xbc, = 0x7, 0x4d, 0x66, 0xb8, 0xfd, 0x9, 0x77 }} gBlackBoxEfiIPsecConfigProtocolGuid =3D { 0xce5e5929, 0xc7a3, 0x4602, { = 0xad, 0x9e, 0xc9, 0xda, 0xf9, 0x4e, 0xbf, 0xcf }} gBlackBoxEfiIScsiInitiatorNameProtocolGuid =3D { 0x59324945, 0xec44, 0x4= c0d, {0xb1, 0xcd, 0x9d, 0xb1, 0x39, 0xdf, 0x7, 0xc }} -- 2.17.1