Re: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple controllers

["Eric Jin" <eric.jin@intel.com>]

Hao,

Thank you for the suggestion. I have sent the patch v2 out and merge series to one patch.
Let's wait one day to follow the possible comments from stewards. Thanks.

Best Regards
Eric

-----Original Message-----
From: Wu, Hao A <hao.a.wu@intel.com> 
Sent: Monday, August 5, 2019 2:20 PM
To: devel@edk2.groups.io; Jin, Eric <eric.jin@intel.com>
Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; afish@apple.com; lersek@redhat.com; leif.lindholm@linaro.org
Subject: RE: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple controllers

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of 
> Eric Jin
> Sent: Wednesday, July 31, 2019 10:59 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple 
> controllers
> 
> Multiple Controllers Support solution
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525
> 
> The patch set is to makes enhancement to the ESRT when multiple same 
> controllers exist in one system.
> 
> Eric Jin (3):
>   MdeModulePkg/EsrtFmpDxe: Merge multiple FMP into ESRT
>   MdeModulePkg/EsrtFmpDxe: Correct LastAttemptVersion algorithm in ESRT
>   MdeModulePkg/EsrtFmpDxe: Detect duplicate GUID/HardwareInstance


Hello Eric,

After looking into the series, I found that patches 2/3 & 3/3 are actually addressing issues introduced by the 1/3 patch. It looks to me that these
3 patches should be squashed into 1 commit, since they all focus on adding a feature for ESRT to support multiple controllers.

However, originally, the 3 separate commits come from the edk2-staging repository, so I am not very sure what approach should be adopted when merging them back to the edk2 repo master branch.

(Includes the stewards here for suggestions.)

My personal preference is to merge them together as one patch.

Best Regards,
Hao Wu


> 
>  MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmp.c | 394 +++++++++++++---
> ----
>  1 file changed, 257 insertions(+), 137 deletions(-)
> 
> --
> 2.20.1.windows.1
> 
> 
>