From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: eric.jin@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Mon, 05 Aug 2019 01:15:19 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Aug 2019 01:15:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,349,1559545200"; d="scan'208";a="197893314" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 05 Aug 2019 01:15:19 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 5 Aug 2019 01:15:19 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 5 Aug 2019 01:15:19 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.139]) by shsmsx102.ccr.corp.intel.com ([169.254.2.19]) with mapi id 14.03.0439.000; Mon, 5 Aug 2019 16:15:17 +0800 From: "Eric Jin" To: "Wu, Hao A" , "devel@edk2.groups.io" CC: "Gao, Liming" , "Kinney, Michael D" , "afish@apple.com" , "lersek@redhat.com" , "leif.lindholm@linaro.org" Subject: Re: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple controllers Thread-Topic: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple controllers Thread-Index: AQHVR7Cc4Lt2fFzjukORDinrxWk8vqbsFlswgAAkrPA= Date: Mon, 5 Aug 2019 08:15:16 +0000 Message-ID: References: <20190731145903.13820-1-eric.jin@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.jin@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hao, Thank you for the suggestion. I have sent the patch v2 out and merge serie= s to one patch. Let's wait one day to follow the possible comments from stewards. Thanks. Best Regards Eric -----Original Message----- From: Wu, Hao A =20 Sent: Monday, August 5, 2019 2:20 PM To: devel@edk2.groups.io; Jin, Eric Cc: Gao, Liming ; Kinney, Michael D ; afish@apple.com; lersek@redhat.com; leif.lindholm@linaro.org Subject: RE: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple con= trollers > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of=20 > Eric Jin > Sent: Wednesday, July 31, 2019 10:59 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple=20 > controllers >=20 > Multiple Controllers Support solution >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1525 >=20 > The patch set is to makes enhancement to the ESRT when multiple same=20 > controllers exist in one system. >=20 > Eric Jin (3): > MdeModulePkg/EsrtFmpDxe: Merge multiple FMP into ESRT > MdeModulePkg/EsrtFmpDxe: Correct LastAttemptVersion algorithm in ESRT > MdeModulePkg/EsrtFmpDxe: Detect duplicate GUID/HardwareInstance Hello Eric, After looking into the series, I found that patches 2/3 & 3/3 are actually= addressing issues introduced by the 1/3 patch. It looks to me that these 3 patches should be squashed into 1 commit, since they all focus on adding= a feature for ESRT to support multiple controllers. However, originally, the 3 separate commits come from the edk2-staging rep= ository, so I am not very sure what approach should be adopted when merging= them back to the edk2 repo master branch. (Includes the stewards here for suggestions.) My personal preference is to merge them together as one patch. Best Regards, Hao Wu >=20 > MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmp.c | 394 +++++++++++++--- > ---- > 1 file changed, 257 insertions(+), 137 deletions(-) >=20 > -- > 2.20.1.windows.1 >=20 >=20 >=20