From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: eric.jin@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Mon, 12 Aug 2019 00:14:06 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Aug 2019 00:14:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,376,1559545200"; d="scan'208";a="183482338" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 12 Aug 2019 00:14:05 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 12 Aug 2019 00:14:04 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.139]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.15]) with mapi id 14.03.0439.000; Mon, 12 Aug 2019 15:14:03 +0800 From: "Eric Jin" To: "Gao, Liming" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH V2 00/10] Multiple Controllers Support solution Thread-Topic: [edk2-devel] [PATCH V2 00/10] Multiple Controllers Support solution Thread-Index: AQHVUK/GfmXT1zZvMUi+7vtQ9Vb6x6b2+XWAgAAJl7A= Date: Mon, 12 Aug 2019 07:14:02 +0000 Message-ID: References: <20190812014603.42484-1-eric.jin@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4CE84D@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4CE84D@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjdiZGY5MjMtZjU2OS00MzFmLTljM2QtY2NhNGM0ZmIxZjRjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibXdxQ2pxS1ZqQUdEcHpTRVl4R1lnMzJGTTFmYms1NmcrdmZENk96XC9XQmc1SEpVZmtMQjlkYTlROFJLVWJvTUsifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.jin@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Liming, The differences between V2 and V1 are listed below. 1) The series is composed of 10 patches in V2 (14 in V1). patch 14 is merg= ed into patch 4, and patch 11/12/13 are merged into patch 5. 2) Try to fix the issue exposed by ECC.=20 Btw, the patch of edk2-platform Platform\Intel\Vlv2TbltDevicePkg\Feature\C= apsule\Library\FmpDeviceLib to support new APIs is provided in separated pa= tch https://edk2.groups.io/g/devel/message/45328 Best Regards Eric -----Original Message----- From: Gao, Liming=20 Sent: Monday, August 12, 2019 1:19 PM To: devel@edk2.groups.io; Jin, Eric Subject: RE: [edk2-devel] [PATCH V2 00/10] Multiple Controllers Support so= lution Eric: Can you list the difference compared to version 1? Thanks Liming >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of=20 >Eric Jin >Sent: Monday, August 12, 2019 9:46 AM >To: devel@edk2.groups.io >Subject: [edk2-devel] [PATCH V2 00/10] Multiple Controllers Support=20 >solution > >REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1525 > >The patch set is to support drivers that manage multiple controllers=20 >and also provide a firmware update capability to each managed controller. > >The following modules are related to Multiple Controllers Support=20 >solution > >FmpDevicePkg\FmpDxe\FmpDxe.inf - Driver to manage multiple controllers=20 >and provide the firmware update capability to each managed controller. >FmpDevicePkg\CapsuleUpdatePolicyDxe\CapsuleUpdatePolicyDxe.inf - Driver= =20 >to produce the Capsule Update Policy Protocol using the services of the= =20 >CapsuleUpdatePolicyLib class. The protocol is a private interface to=20 >the FmpDevicePkg=20 >FmpDevicePkg\Library\CapsuleUpdatePolicyLibOnProtocol\CapsuleUpdatePo >licyLibOnProtocol.inf - >CapsuleUpdatePolicyLib instance that uses the services of the Capsule=20 >Update Policy Protocol produced by CapsuleUpdatePolicyDxe=20 >FmpDevicePkg\Library\CapsuleUpdatePolicyLibNull\CapsuleUpdatePolicyLibN >ull.inf - >Null CapsuleUpdatePolicyLib instance and the template for platform=20 >specific implementation=20 >FmpDevicePkg\Library\FmpDeviceLibNull\FmpDeviceLibNull.inf - Null=20 >FmpDeviceLib instance and the template for platform specific=20 >implementation > >Eric Jin (10): > FmpDevicePkg: Add UEFI_DRIVER support > FmpDevicePkg: Add APIs to FmpDeviceLib > FmpDEvicePkg/FmpDeviceLibNull: Implement new APIs > FmpDevicePkg/FmpDxe: Use new FmpDeviceLib APIs > FmpDevicePkg/FmpDxe: Different variable for each FMP Descriptor > FmpDevicePkg: Add Capsule Update Policy Protocol > FmpDevicePkg/FmpDxe: Improve all DEBUG() messages > FmpDevicePkg/FmpDxe: Add PcdFmpDeviceImageTypeIdGuid > FmpDevicePkg/FmpDxe: Add PcdFmpDeviceStorageAccessEnable > FmpDevicePkg/FmpDxe: Remove use of CatSprint() > > .../CapsuleUpdatePolicyDxe.c | 173 ++++ > .../CapsuleUpdatePolicyDxe.h | 140 +++ > .../CapsuleUpdatePolicyDxe.inf | 48 + > .../CapsuleUpdatePolicyDxe.uni | 14 + > .../CapsuleUpdatePolicyDxeExtra.uni | 14 + > FmpDevicePkg/FmpDevicePkg.dec | 43 +- > FmpDevicePkg/FmpDevicePkg.dsc | 64 +- > FmpDevicePkg/FmpDevicePkg.uni | 16 +- > FmpDevicePkg/FmpDxe/DetectTestKey.c | 16 +- > FmpDevicePkg/FmpDxe/FmpDxe.c | 792 ++++++++++------ > FmpDevicePkg/FmpDxe/FmpDxe.h | 355 ++++++++ > FmpDevicePkg/FmpDxe/FmpDxe.inf | 7 +- > FmpDevicePkg/FmpDxe/FmpDxeLib.inf | 7 +- > FmpDevicePkg/FmpDxe/VariableSupport.c | 844 +++++++++++++----- > FmpDevicePkg/FmpDxe/VariableSupport.h | 135 ++- > FmpDevicePkg/Include/Library/FmpDeviceLib.h | 104 ++- > .../CapsuleUpdatePolicyLibOnProtocol.c | 171 ++++ > .../CapsuleUpdatePolicyLibOnProtocol.inf | 40 + > .../CapsuleUpdatePolicyLibOnProtocol.uni | 15 + > .../Library/FmpDeviceLibNull/FmpDeviceLib.c | 93 +- > .../FmpDeviceLibNull/FmpDeviceLibNull.inf | 4 +- > .../FmpPayloadHeaderLibV1.inf | 4 +- > .../Library/FmpPayloadHeaderLib.h | 0 > .../Protocol/CapsuleUpdatePolicy.h | 132 +++ > 24 files changed, 2644 insertions(+), 587 deletions(-) create mode=20 >100644 FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.c > create mode 100644 >FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.h > create mode 100644 >FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.inf > create mode 100644 >FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.uni > create mode 100644 >FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxeExtra.uni > create mode 100644 FmpDevicePkg/FmpDxe/FmpDxe.h create mode 100644=20 >FmpDevicePkg/Library/CapsuleUpdatePolicyLibOnProtocol/CapsuleUpdatePo >licyLibOnProtocol.c > create mode 100644 >FmpDevicePkg/Library/CapsuleUpdatePolicyLibOnProtocol/CapsuleUpdatePo >licyLibOnProtocol.inf > create mode 100644 >FmpDevicePkg/Library/CapsuleUpdatePolicyLibOnProtocol/CapsuleUpdatePo >licyLibOnProtocol.uni > rename FmpDevicePkg/{Include =3D> >PrivateInclude}/Library/FmpPayloadHeaderLib.h (100%) create mode=20 >100644 FmpDevicePkg/PrivateInclude/Protocol/CapsuleUpdatePolicy.h > >-- >2.20.1.windows.1 > > >